Skip to content

Remove responsive-revision-gc config from config-features#11309

Merged
knative-prow-robot merged 1 commit into
knative:mainfrom
nak3:clean-up-gc
May 10, 2021
Merged

Remove responsive-revision-gc config from config-features#11309
knative-prow-robot merged 1 commit into
knative:mainfrom
nak3:clean-up-gc

Conversation

@nak3
Copy link
Copy Markdown
Contributor

@nak3 nak3 commented May 6, 2021

Since #10084 deleted old GC and started using responsive GC,
responsive-revision-gc in config-feature is not used at all.

This patch removes the config from the config-feature configmap.

/kind cleanup
/cc @whaught @julz @dprotaso

@nak3
Remove responsive-revision-gc config from config-features
056337f 
knative#10084 deleted old GC
and `responsive-revision-gc` in `config-feature` is not used at all.

This patch removes the config from the config-feature configmap.
@knative-prow-robot knative-prow-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 6, 2021
@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label May 6, 2021
@knative-prow-robot knative-prow-robot added area/API API objects and controllers size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 6, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2021 •
edited
Loading

Codecov Report

Merging #11309 (056337f) into main (f8f26b7) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11309      +/-   ##
==========================================
+ Coverage   87.67%   87.72%   +0.04%     
==========================================
  Files         191      191              
  Lines        9211     9211              
==========================================
+ Hits         8076     8080       +4     
+ Misses        881      878       -3     
+ Partials      254      253       -1
Impacted Files Coverage Δ
pkg/autoscaler/statforwarder/leases.go 78.41% <0.00%> (+1.43%) ⬆️
pkg/autoscaler/scaling/multiscaler.go 89.38% <0.00%> (+1.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8f26b7...056337f. Read the comment docs.

@nak3
Copy link
Copy Markdown
Contributor Author

nak3 commented May 7, 2021

/retest

TLS test failed which is not related to this PR.

@nak3
Copy link
Copy Markdown
Contributor Author

nak3 commented May 7, 2021

/retest

webhook error.

julz
julz approved these changes May 7, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@julz julz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2021
@nak3 nak3 mentioned this pull request May 9, 2021
Merged
markusthoemmes
markusthoemmes approved these changes May 10, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented May 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: julz, markusthoemmes, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2021
@knative-prow-robot knative-prow-robot merged commit 9997277 into knative:main May 10, 2021
@julz julz mentioned this pull request Jun 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dprotaso dprotaso Awaiting requested review from dprotaso

3 more reviewers

@julz julz julz approved these changes

@markusthoemmes markusthoemmes markusthoemmes approved these changes

@whaught whaught whaught approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@julz julz

@markusthoemmes markusthoemmes

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers cla: yes Indicates the PR's author has signed the CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nak3 @knative-prow-robot @julz @markusthoemmes @whaught