Delete old GC by whaught · Pull Request #10084 · knative/serving

whaught · 2020-11-11T06:20:36Z

Proposed Changes

Delete the old GC and Labeler
Delete v1 GC config
Remove LastPinned refresh from Route reconciliation
LastPinned adn LastPinnedDebounce are deprecated, but still accepted for validation.

Release Note

Remove the GC feature flag and v1 GC/Labeler

codecov · 2020-11-11T07:51:15Z

Codecov Report

Merging #10084 (452d94e) into master (f8325b7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #10084      +/-   ##
==========================================
+ Coverage   87.95%   87.97%   +0.01%     
==========================================
  Files         185      184       -1     
  Lines        8729     8585     -144     
==========================================
- Hits         7678     7553     -125     
+ Misses        800      789      -11     
+ Partials      251      243       -8

Impacted Files	Coverage Δ
pkg/apis/config/features.go	`93.33% <ø> (-0.42%)`	⬇️
pkg/reconciler/gc/config/store.go	`100.00% <ø> (ø)`
pkg/reconciler/gc/v2/gc.go	`97.05% <ø> (-0.09%)`	⬇️
pkg/reconciler/labeler/controller.go	`100.00% <ø> (ø)`
pkg/reconciler/route/reconcile_resources.go	`78.43% <ø> (+3.04%)`	⬆️
pkg/reconciler/route/route.go	`76.24% <ø> (+0.69%)`	⬆️
pkg/apis/serving/v1/revision_helpers.go	`100.00% <100.00%> (ø)`
pkg/gc/config.go	`95.83% <100.00%> (-4.17%)`	⬇️
pkg/reconciler/configuration/resources/revision.go	`86.84% <100.00%> (-10.60%)`	⬇️
pkg/reconciler/gc/reconciler.go	`100.00% <100.00%> (ø)`
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8325b7...452d94e. Read the comment docs.

whaught · 2020-11-11T16:14:39Z

/assign @dprotaso @mattmoor @vagababov

vagababov

Maybe for the followup PR, but I I think v2GC -> GC change is in order.

/lgtm
/assign mattmoor

whaught · 2020-11-11T19:14:05Z

Maybe for the followup PR, but I I think v2GC -> GC change is in order.

We can flatten the v2 folders, but I didn't want to mess up the diffbase in this PR with moves (we'll do that next)

dprotaso · 2020-11-17T14:18:38Z

/lgtm
/approve

just needs a rebase

dprotaso

/lgtm

knative-prow-robot · 2020-11-17T16:13:28Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~config/OWNERS~~ [dprotaso]
~~pkg/apis/OWNERS~~ [dprotaso]
~~pkg/gc/OWNERS~~ [dprotaso]
~~pkg/reconciler/OWNERS~~ [dprotaso]
~~pkg/testing/OWNERS~~ [dprotaso]
~~test/OWNERS~~ [dprotaso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vagababov · 2020-11-17T17:22:39Z

/lgtm
🎉

* Delete old GC * remove old settings * hash * remove unreffed tests * add in routingstate * lastpinned * routingstate * simpler * merge

knative#10084 deleted old GC and `responsive-revision-gc` in `config-feature` is not used at all. This patch removes the config from the config-feature configmap.

#10084 deleted old GC and `responsive-revision-gc` in `config-feature` is not used at all. This patch removes the config from the config-feature configmap.

Since knative/serving#10084 deleted old GC and started using responsive GC by default, `responsive-revision-gc` in `config-feature` is not used at all. This patch removes the configuration `responsive-revision-gc` in `config-feature` configmap.

…e website, create `/snippets` directory (#3610) * change name for menu item for preview (#3533) Signed-off-by: Carlos Santana <csantana23@gmail.com> * Added detail per issue #3425 (#3514) * Update knative/community files (#3553) Signed-off-by: Knative Automation <automation@knative.team> * tracing cm fix (#3506) * remove unnecessary requrirements to do a release (#3563) Signed-off-by: Carlos Santana <csantana23@gmail.com> * #3543 fix link (#3567) * Replace xip.io with sslip.io (#3574) * Update actions (#3535) Signed-off-by: Knative Automation <automation@knative.team> * Update common github actions (#3552) Signed-off-by: Knative Automation <automation@knative.team> * upgrade to latest dependencies (#3505) bumping knative.dev/hack 88c69cd...93ad912: > 93ad912 Print java and mvn version (# 65) > 86f9adc Fix default codegen pkg dir (# 67) Signed-off-by: Knative Automation <automation@knative.team> * Remove responsive-revision-gc config (#3545) Since knative/serving#10084 deleted old GC and started using responsive GC by default, `responsive-revision-gc` in `config-feature` is not used at all. This patch removes the configuration `responsive-revision-gc` in `config-feature` configmap. * Fixes #3117 and broken links (#3569) * Fix #3117 and broken links * Fix #3117 and broken links * remove spec folder and redirect page and update links * remove conflicts * Update shortcodes.md (#3550) minor grammar. * 💄 slight change to ordered delivery guarantees (#3536) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Add knative-release-leads to OWNERS (#3586) * add approvers ux (#3587) * Update the default value (#3530) * Adding notes on KafkaSource usage (#3596) * Adding some Kafka note for use-cases Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * changing the description Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Update actions (#3581) Signed-off-by: Knative Automation <automation@knative.team> * Remove python pycache (#3594) * Use correct setting in ClusterIssue setting (#3595) The doc uses ClusterIssuer `letsencrypt-http01-issuer` but the configuration uses `letsencrypt-issuer` so it is confusable. Actual report is #3560. So this patch changes the ClusterIssuer name to `letsencrypt-http01-issuer` which is used in this doc section. Fix #3560 * fix broken link #3568 #3577 (#3579) * fix Netlify build * Added Snippets folder and hidden Beta Contributor guide * Update docs/eventing/event-registry.md Co-authored-by: Carlos Santana <csantana23@gmail.com> * whitespace * more whitespace * removing this bit because linting is killing me * ok really the last one Co-authored-by: Carlos Santana <csantana23@gmail.com> Co-authored-by: RichardJJG <rijohnson@vmware.com> Co-authored-by: knative-automation <automation@knative.team> Co-authored-by: Shashankft9 <48708039+Shashankft9@users.noreply.github.com> Co-authored-by: Ashleigh Brennan <abrennan@redhat.com> Co-authored-by: Benjamin Tan Wei Hao <benjamintanweihao@gmail.com> Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com> Co-authored-by: Jonathan Johnson <jonathan.johnson@dijure.com> Co-authored-by: Matthias Wessendorf <mwessend@redhat.com> Co-authored-by: Evan Anderson <evana@vmware.com> Co-authored-by: RichieEscarez <rescarez@google.com> Co-authored-by: NovaHe <heqianfly@gmail.com>

* change name for menu item for preview (#3533) Signed-off-by: Carlos Santana <csantana23@gmail.com> * Added detail per issue #3425 (#3514) * Update knative/community files (#3553) Signed-off-by: Knative Automation <automation@knative.team> * tracing cm fix (#3506) * remove unnecessary requrirements to do a release (#3563) Signed-off-by: Carlos Santana <csantana23@gmail.com> * #3543 fix link (#3567) * Replace xip.io with sslip.io (#3574) * Update actions (#3535) Signed-off-by: Knative Automation <automation@knative.team> * Update common github actions (#3552) Signed-off-by: Knative Automation <automation@knative.team> * upgrade to latest dependencies (#3505) bumping knative.dev/hack 88c69cd...93ad912: > 93ad912 Print java and mvn version (# 65) > 86f9adc Fix default codegen pkg dir (# 67) Signed-off-by: Knative Automation <automation@knative.team> * Remove responsive-revision-gc config (#3545) Since knative/serving#10084 deleted old GC and started using responsive GC by default, `responsive-revision-gc` in `config-feature` is not used at all. This patch removes the configuration `responsive-revision-gc` in `config-feature` configmap. * Fixes #3117 and broken links (#3569) * Fix #3117 and broken links * Fix #3117 and broken links * remove spec folder and redirect page and update links * remove conflicts * Update shortcodes.md (#3550) minor grammar. * 💄 slight change to ordered delivery guarantees (#3536) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Add knative-release-leads to OWNERS (#3586) * add approvers ux (#3587) * Update the default value (#3530) * Adding notes on KafkaSource usage (#3596) * Adding some Kafka note for use-cases Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * changing the description Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Update actions (#3581) Signed-off-by: Knative Automation <automation@knative.team> * Remove python pycache (#3594) * Use correct setting in ClusterIssue setting (#3595) The doc uses ClusterIssuer `letsencrypt-http01-issuer` but the configuration uses `letsencrypt-issuer` so it is confusable. Actual report is #3560. So this patch changes the ClusterIssuer name to `letsencrypt-http01-issuer` which is used in this doc section. Fix #3560 * fix broken link #3568 #3577 (#3579) * fix Netlify build * Added Snippets folder and hidden Beta Contributor guide * Update docs/eventing/event-registry.md Co-authored-by: Carlos Santana <csantana23@gmail.com> * whitespace * more whitespace * removing this bit because linting is killing me * ok really the last one * Updating to latest API version of Strimzi. v1beta1 is now gone 🔥 (#3603) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * 📓 adding a note to not consume records of the kafkachannel's topic... (#3615) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * fix broken link in kogito example (#3602) * docs about usage of internal services in an "api-gateway" access model (#3597) Co-authored-by: Brüder, Lena <lena.brueder@maxxeed.com> * api specs for v0.23 (#3619) Signed-off-by: Carlos Santana <csantana23@gmail.com> * Update serving/_index.md with network layer option (#3585) * Update _index.md [#3117] Add ref for contour * Update docs/serving/_index.md Co-authored-by: Ashleigh Brennan <abrennan@redhat.com> Co-authored-by: Omer B <obensaadon@vmware.com> Co-authored-by: Ashleigh Brennan <abrennan@redhat.com> * Fix typos in the sample yaml file (#3616) * EventType is not yet part of the v1 eventing API (#3576) * Remaining changes from now closed PRs Co-authored-by: Carlos Santana <csantana23@gmail.com> Co-authored-by: RichardJJG <rijohnson@vmware.com> Co-authored-by: knative-automation <automation@knative.team> Co-authored-by: Shashankft9 <48708039+Shashankft9@users.noreply.github.com> Co-authored-by: Ashleigh Brennan <abrennan@redhat.com> Co-authored-by: Benjamin Tan Wei Hao <benjamintanweihao@gmail.com> Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com> Co-authored-by: Jonathan Johnson <jonathan.johnson@dijure.com> Co-authored-by: Matthias Wessendorf <mwessend@redhat.com> Co-authored-by: Evan Anderson <evana@vmware.com> Co-authored-by: RichieEscarez <rescarez@google.com> Co-authored-by: NovaHe <heqianfly@gmail.com> Co-authored-by: Kevin Marquardsen <mr.kmarq@gmail.com> Co-authored-by: Lena Brüder <oss@lena-brueder.de> Co-authored-by: Brüder, Lena <lena.brueder@maxxeed.com> Co-authored-by: Sameer Vohra <vsameer@vmware.com> Co-authored-by: Mahdi K. Fard <xclud@users.noreply.github.com>

…e website, create `/snippets` directory (knative#3610) * change name for menu item for preview (knative#3533) Signed-off-by: Carlos Santana <csantana23@gmail.com> * Added detail per issue knative#3425 (knative#3514) * Update knative/community files (knative#3553) Signed-off-by: Knative Automation <automation@knative.team> * tracing cm fix (knative#3506) * remove unnecessary requrirements to do a release (knative#3563) Signed-off-by: Carlos Santana <csantana23@gmail.com> * knative#3543 fix link (knative#3567) * Replace xip.io with sslip.io (knative#3574) * Update actions (knative#3535) Signed-off-by: Knative Automation <automation@knative.team> * Update common github actions (knative#3552) Signed-off-by: Knative Automation <automation@knative.team> * upgrade to latest dependencies (knative#3505) bumping knative.dev/hack 88c69cd...93ad912: > 93ad912 Print java and mvn version (# 65) > 86f9adc Fix default codegen pkg dir (# 67) Signed-off-by: Knative Automation <automation@knative.team> * Remove responsive-revision-gc config (knative#3545) Since knative/serving#10084 deleted old GC and started using responsive GC by default, `responsive-revision-gc` in `config-feature` is not used at all. This patch removes the configuration `responsive-revision-gc` in `config-feature` configmap. * Fixes knative#3117 and broken links (knative#3569) * Fix knative#3117 and broken links * Fix knative#3117 and broken links * remove spec folder and redirect page and update links * remove conflicts * Update shortcodes.md (knative#3550) minor grammar. * 💄 slight change to ordered delivery guarantees (knative#3536) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Add knative-release-leads to OWNERS (knative#3586) * add approvers ux (knative#3587) * Update the default value (knative#3530) * Adding notes on KafkaSource usage (knative#3596) * Adding some Kafka note for use-cases Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * changing the description Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Update actions (knative#3581) Signed-off-by: Knative Automation <automation@knative.team> * Remove python pycache (knative#3594) * Use correct setting in ClusterIssue setting (knative#3595) The doc uses ClusterIssuer `letsencrypt-http01-issuer` but the configuration uses `letsencrypt-issuer` so it is confusable. Actual report is knative#3560. So this patch changes the ClusterIssuer name to `letsencrypt-http01-issuer` which is used in this doc section. Fix knative#3560 * fix broken link knative#3568 knative#3577 (knative#3579) * fix Netlify build * Added Snippets folder and hidden Beta Contributor guide * Update docs/eventing/event-registry.md Co-authored-by: Carlos Santana <csantana23@gmail.com> * whitespace * more whitespace * removing this bit because linting is killing me * ok really the last one Co-authored-by: Carlos Santana <csantana23@gmail.com> Co-authored-by: RichardJJG <rijohnson@vmware.com> Co-authored-by: knative-automation <automation@knative.team> Co-authored-by: Shashankft9 <48708039+Shashankft9@users.noreply.github.com> Co-authored-by: Ashleigh Brennan <abrennan@redhat.com> Co-authored-by: Benjamin Tan Wei Hao <benjamintanweihao@gmail.com> Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com> Co-authored-by: Jonathan Johnson <jonathan.johnson@dijure.com> Co-authored-by: Matthias Wessendorf <mwessend@redhat.com> Co-authored-by: Evan Anderson <evana@vmware.com> Co-authored-by: RichieEscarez <rescarez@google.com> Co-authored-by: NovaHe <heqianfly@gmail.com>

* change name for menu item for preview (knative#3533) Signed-off-by: Carlos Santana <csantana23@gmail.com> * Added detail per issue knative#3425 (knative#3514) * Update knative/community files (knative#3553) Signed-off-by: Knative Automation <automation@knative.team> * tracing cm fix (knative#3506) * remove unnecessary requrirements to do a release (knative#3563) Signed-off-by: Carlos Santana <csantana23@gmail.com> * knative#3543 fix link (knative#3567) * Replace xip.io with sslip.io (knative#3574) * Update actions (knative#3535) Signed-off-by: Knative Automation <automation@knative.team> * Update common github actions (knative#3552) Signed-off-by: Knative Automation <automation@knative.team> * upgrade to latest dependencies (knative#3505) bumping knative.dev/hack 88c69cd...93ad912: > 93ad912 Print java and mvn version (# 65) > 86f9adc Fix default codegen pkg dir (# 67) Signed-off-by: Knative Automation <automation@knative.team> * Remove responsive-revision-gc config (knative#3545) Since knative/serving#10084 deleted old GC and started using responsive GC by default, `responsive-revision-gc` in `config-feature` is not used at all. This patch removes the configuration `responsive-revision-gc` in `config-feature` configmap. * Fixes knative#3117 and broken links (knative#3569) * Fix knative#3117 and broken links * Fix knative#3117 and broken links * remove spec folder and redirect page and update links * remove conflicts * Update shortcodes.md (knative#3550) minor grammar. * 💄 slight change to ordered delivery guarantees (knative#3536) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Add knative-release-leads to OWNERS (knative#3586) * add approvers ux (knative#3587) * Update the default value (knative#3530) * Adding notes on KafkaSource usage (knative#3596) * Adding some Kafka note for use-cases Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * changing the description Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Update actions (knative#3581) Signed-off-by: Knative Automation <automation@knative.team> * Remove python pycache (knative#3594) * Use correct setting in ClusterIssue setting (knative#3595) The doc uses ClusterIssuer `letsencrypt-http01-issuer` but the configuration uses `letsencrypt-issuer` so it is confusable. Actual report is knative#3560. So this patch changes the ClusterIssuer name to `letsencrypt-http01-issuer` which is used in this doc section. Fix knative#3560 * fix broken link knative#3568 knative#3577 (knative#3579) * fix Netlify build * Added Snippets folder and hidden Beta Contributor guide * Update docs/eventing/event-registry.md Co-authored-by: Carlos Santana <csantana23@gmail.com> * whitespace * more whitespace * removing this bit because linting is killing me * ok really the last one * Updating to latest API version of Strimzi. v1beta1 is now gone 🔥 (knative#3603) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * 📓 adding a note to not consume records of the kafkachannel's topic... (knative#3615) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * fix broken link in kogito example (knative#3602) * docs about usage of internal services in an "api-gateway" access model (knative#3597) Co-authored-by: Brüder, Lena <lena.brueder@maxxeed.com> * api specs for v0.23 (knative#3619) Signed-off-by: Carlos Santana <csantana23@gmail.com> * Update serving/_index.md with network layer option (knative#3585) * Update _index.md [knative#3117] Add ref for contour * Update docs/serving/_index.md Co-authored-by: Ashleigh Brennan <abrennan@redhat.com> Co-authored-by: Omer B <obensaadon@vmware.com> Co-authored-by: Ashleigh Brennan <abrennan@redhat.com> * Fix typos in the sample yaml file (knative#3616) * EventType is not yet part of the v1 eventing API (knative#3576) * Remaining changes from now closed PRs Co-authored-by: Carlos Santana <csantana23@gmail.com> Co-authored-by: RichardJJG <rijohnson@vmware.com> Co-authored-by: knative-automation <automation@knative.team> Co-authored-by: Shashankft9 <48708039+Shashankft9@users.noreply.github.com> Co-authored-by: Ashleigh Brennan <abrennan@redhat.com> Co-authored-by: Benjamin Tan Wei Hao <benjamintanweihao@gmail.com> Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com> Co-authored-by: Jonathan Johnson <jonathan.johnson@dijure.com> Co-authored-by: Matthias Wessendorf <mwessend@redhat.com> Co-authored-by: Evan Anderson <evana@vmware.com> Co-authored-by: RichieEscarez <rescarez@google.com> Co-authored-by: NovaHe <heqianfly@gmail.com> Co-authored-by: Kevin Marquardsen <mr.kmarq@gmail.com> Co-authored-by: Lena Brüder <oss@lena-brueder.de> Co-authored-by: Brüder, Lena <lena.brueder@maxxeed.com> Co-authored-by: Sameer Vohra <vsameer@vmware.com> Co-authored-by: Mahdi K. Fard <xclud@users.noreply.github.com>

…e website, create `/snippets` directory (knative#3610) * change name for menu item for preview (knative#3533) Signed-off-by: Carlos Santana <csantana23@gmail.com> * Added detail per issue knative#3425 (knative#3514) * Update knative/community files (knative#3553) Signed-off-by: Knative Automation <automation@knative.team> * tracing cm fix (knative#3506) * remove unnecessary requrirements to do a release (knative#3563) Signed-off-by: Carlos Santana <csantana23@gmail.com> * knative#3543 fix link (knative#3567) * Replace xip.io with sslip.io (knative#3574) * Update actions (knative#3535) Signed-off-by: Knative Automation <automation@knative.team> * Update common github actions (knative#3552) Signed-off-by: Knative Automation <automation@knative.team> * upgrade to latest dependencies (knative#3505) bumping knative.dev/hack 88c69cd...93ad912: > 93ad912 Print java and mvn version (# 65) > 86f9adc Fix default codegen pkg dir (# 67) Signed-off-by: Knative Automation <automation@knative.team> * Remove responsive-revision-gc config (knative#3545) Since knative/serving#10084 deleted old GC and started using responsive GC by default, `responsive-revision-gc` in `config-feature` is not used at all. This patch removes the configuration `responsive-revision-gc` in `config-feature` configmap. * Fixes knative#3117 and broken links (knative#3569) * Fix knative#3117 and broken links * Fix knative#3117 and broken links * remove spec folder and redirect page and update links * remove conflicts * Update shortcodes.md (knative#3550) minor grammar. * 💄 slight change to ordered delivery guarantees (knative#3536) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Add knative-release-leads to OWNERS (knative#3586) * add approvers ux (knative#3587) * Update the default value (knative#3530) * Adding notes on KafkaSource usage (knative#3596) * Adding some Kafka note for use-cases Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * changing the description Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Update actions (knative#3581) Signed-off-by: Knative Automation <automation@knative.team> * Remove python pycache (knative#3594) * Use correct setting in ClusterIssue setting (knative#3595) The doc uses ClusterIssuer `letsencrypt-http01-issuer` but the configuration uses `letsencrypt-issuer` so it is confusable. Actual report is knative#3560. So this patch changes the ClusterIssuer name to `letsencrypt-http01-issuer` which is used in this doc section. Fix knative#3560 * fix broken link knative#3568 knative#3577 (knative#3579) * fix Netlify build * Added Snippets folder and hidden Beta Contributor guide * Update docs/eventing/event-registry.md Co-authored-by: Carlos Santana <csantana23@gmail.com> * whitespace * more whitespace * removing this bit because linting is killing me * ok really the last one Co-authored-by: Carlos Santana <csantana23@gmail.com> Co-authored-by: RichardJJG <rijohnson@vmware.com> Co-authored-by: knative-automation <automation@knative.team> Co-authored-by: Shashankft9 <48708039+Shashankft9@users.noreply.github.com> Co-authored-by: Ashleigh Brennan <abrennan@redhat.com> Co-authored-by: Benjamin Tan Wei Hao <benjamintanweihao@gmail.com> Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com> Co-authored-by: Jonathan Johnson <jonathan.johnson@dijure.com> Co-authored-by: Matthias Wessendorf <mwessend@redhat.com> Co-authored-by: Evan Anderson <evana@vmware.com> Co-authored-by: RichieEscarez <rescarez@google.com> Co-authored-by: NovaHe <heqianfly@gmail.com>

* change name for menu item for preview (knative#3533) Signed-off-by: Carlos Santana <csantana23@gmail.com> * Added detail per issue knative#3425 (knative#3514) * Update knative/community files (knative#3553) Signed-off-by: Knative Automation <automation@knative.team> * tracing cm fix (knative#3506) * remove unnecessary requrirements to do a release (knative#3563) Signed-off-by: Carlos Santana <csantana23@gmail.com> * knative#3543 fix link (knative#3567) * Replace xip.io with sslip.io (knative#3574) * Update actions (knative#3535) Signed-off-by: Knative Automation <automation@knative.team> * Update common github actions (knative#3552) Signed-off-by: Knative Automation <automation@knative.team> * upgrade to latest dependencies (knative#3505) bumping knative.dev/hack 88c69cd...93ad912: > 93ad912 Print java and mvn version (# 65) > 86f9adc Fix default codegen pkg dir (# 67) Signed-off-by: Knative Automation <automation@knative.team> * Remove responsive-revision-gc config (knative#3545) Since knative/serving#10084 deleted old GC and started using responsive GC by default, `responsive-revision-gc` in `config-feature` is not used at all. This patch removes the configuration `responsive-revision-gc` in `config-feature` configmap. * Fixes knative#3117 and broken links (knative#3569) * Fix knative#3117 and broken links * Fix knative#3117 and broken links * remove spec folder and redirect page and update links * remove conflicts * Update shortcodes.md (knative#3550) minor grammar. * 💄 slight change to ordered delivery guarantees (knative#3536) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Add knative-release-leads to OWNERS (knative#3586) * add approvers ux (knative#3587) * Update the default value (knative#3530) * Adding notes on KafkaSource usage (knative#3596) * Adding some Kafka note for use-cases Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * changing the description Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Update actions (knative#3581) Signed-off-by: Knative Automation <automation@knative.team> * Remove python pycache (knative#3594) * Use correct setting in ClusterIssue setting (knative#3595) The doc uses ClusterIssuer `letsencrypt-http01-issuer` but the configuration uses `letsencrypt-issuer` so it is confusable. Actual report is knative#3560. So this patch changes the ClusterIssuer name to `letsencrypt-http01-issuer` which is used in this doc section. Fix knative#3560 * fix broken link knative#3568 knative#3577 (knative#3579) * fix Netlify build * Added Snippets folder and hidden Beta Contributor guide * Update docs/eventing/event-registry.md Co-authored-by: Carlos Santana <csantana23@gmail.com> * whitespace * more whitespace * removing this bit because linting is killing me * ok really the last one * Updating to latest API version of Strimzi. v1beta1 is now gone 🔥 (knative#3603) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * 📓 adding a note to not consume records of the kafkachannel's topic... (knative#3615) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * fix broken link in kogito example (knative#3602) * docs about usage of internal services in an "api-gateway" access model (knative#3597) Co-authored-by: Brüder, Lena <lena.brueder@maxxeed.com> * api specs for v0.23 (knative#3619) Signed-off-by: Carlos Santana <csantana23@gmail.com> * Update serving/_index.md with network layer option (knative#3585) * Update _index.md [knative#3117] Add ref for contour * Update docs/serving/_index.md Co-authored-by: Ashleigh Brennan <abrennan@redhat.com> Co-authored-by: Omer B <obensaadon@vmware.com> Co-authored-by: Ashleigh Brennan <abrennan@redhat.com> * Fix typos in the sample yaml file (knative#3616) * EventType is not yet part of the v1 eventing API (knative#3576) * Remaining changes from now closed PRs Co-authored-by: Carlos Santana <csantana23@gmail.com> Co-authored-by: RichardJJG <rijohnson@vmware.com> Co-authored-by: knative-automation <automation@knative.team> Co-authored-by: Shashankft9 <48708039+Shashankft9@users.noreply.github.com> Co-authored-by: Ashleigh Brennan <abrennan@redhat.com> Co-authored-by: Benjamin Tan Wei Hao <benjamintanweihao@gmail.com> Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com> Co-authored-by: Jonathan Johnson <jonathan.johnson@dijure.com> Co-authored-by: Matthias Wessendorf <mwessend@redhat.com> Co-authored-by: Evan Anderson <evana@vmware.com> Co-authored-by: RichieEscarez <rescarez@google.com> Co-authored-by: NovaHe <heqianfly@gmail.com> Co-authored-by: Kevin Marquardsen <mr.kmarq@gmail.com> Co-authored-by: Lena Brüder <oss@lena-brueder.de> Co-authored-by: Brüder, Lena <lena.brueder@maxxeed.com> Co-authored-by: Sameer Vohra <vsameer@vmware.com> Co-authored-by: Mahdi K. Fard <xclud@users.noreply.github.com>

Delete old GC

2119f4a

knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 11, 2020

google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 11, 2020

knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/API API objects and controllers labels Nov 11, 2020

knative-prow-robot requested review from ZhiminXiang, markusthoemmes and vagababov November 11, 2020 06:20

knative-prow-robot added the area/networking label Nov 11, 2020

whaught added 3 commits November 10, 2020 22:39

remove old settings

0e4d8aa

hash

dfadb6e

remove unreffed tests

9178489

knative-prow-robot added the area/test-and-release It flags unit/e2e/conformance/perf test issues for product features label Nov 11, 2020

whaught added 3 commits November 10, 2020 23:19

add in routingstate

881b57d

lastpinned

7c5595d

routingstate

ec5256e

whaught changed the title ~~[WIP] Delete old GC~~ Delete old GC Nov 11, 2020

knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 11, 2020

simpler

7e654d7

knative-prow-robot assigned dprotaso, mattmoor and vagababov Nov 11, 2020

vagababov reviewed Nov 11, 2020

View reviewed changes

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2020

knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2020

whaught added 2 commits November 16, 2020 22:58

Merge branch 'upstream/master' into delete-old-gc

14ecc86

merge

6961c1a

knative-prow-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 17, 2020

knative-prow-robot added lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 17, 2020

Merge remote-tracking branch 'upstream/master' into delete-old-gc

452d94e

knative-prow-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 17, 2020

dprotaso approved these changes Nov 17, 2020

View reviewed changes

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2020

knative-prow-robot merged commit b3e5c61 into knative:master Nov 17, 2020

yangyunfeng007 pushed a commit to yangyunfeng007/serving that referenced this pull request Nov 19, 2020

Delete old GC (knative#10084)

75b1b4a

* Delete old GC * remove old settings * hash * remove unreffed tests * add in routingstate * lastpinned * routingstate * simpler * merge

whaught deleted the delete-old-gc branch January 13, 2021 02:33

julz mentioned this pull request Jan 27, 2021

Remove unused constants and make some other small tidy-ups #10637

Merged

This was referenced May 6, 2021

Remove responsive-revision-gc config from config-features #11309

Merged

Remove responsive-revision-gc config knative/docs#3545

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Delete old GC#10084

Delete old GC#10084
knative-prow-robot merged 11 commits into
knative:masterfrom
whaught:delete-old-gc

whaught commented Nov 11, 2020 •

edited

Loading

Uh oh!

codecov Bot commented Nov 11, 2020 •

edited

Loading

Uh oh!

whaught commented Nov 11, 2020

Uh oh!

vagababov left a comment

Uh oh!

whaught commented Nov 11, 2020

Uh oh!

dprotaso commented Nov 17, 2020

Uh oh!

dprotaso left a comment

Uh oh!

knative-prow-robot commented Nov 17, 2020

Uh oh!

vagababov commented Nov 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

whaught commented Nov 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

Uh oh!

codecov Bot commented Nov 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

whaught commented Nov 11, 2020

Uh oh!

vagababov left a comment

Choose a reason for hiding this comment

Uh oh!

whaught commented Nov 11, 2020

Uh oh!

dprotaso commented Nov 17, 2020

Uh oh!

dprotaso left a comment

Choose a reason for hiding this comment

Uh oh!

knative-prow-robot commented Nov 17, 2020

Uh oh!

vagababov commented Nov 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

whaught commented Nov 11, 2020 •

edited

Loading

codecov Bot commented Nov 11, 2020 •

edited

Loading