Fix broken links by novahe · Pull Request #3579 · knative/docs

novahe · 2021-05-15T14:56:00Z

I use the following command to scan in multiple threads

find . -type f -print0  | xargs -0 -P 6 grep -rni "/README.md)"|grep -v https

./docs/serving/samples/rest-api-go/index.md:15:1. A Kubernetes cluster with [Knative Serving](../../../install/README.md) installed
./docs/serving/samples/rest-api-go/index.md:205:The [traffic splitting example](../traffic-splitting/README.md) continues from
./docs/serving/samples/knative-routing-go/index.md:23:1. A Kubernetes cluster with [Knative Serving](../../../install/README.md)
./docs/serving/samples/multi-container/index.md:13:  [installation instructions](../../../install/README.md) if you need to
./docs/serving/samples/hello-world/helloworld-java-spring/README.md:17:  [installation instructions](../../../../install/README.md) if you need to
./docs/serving/samples/grpc-ping-go/index.md:19:- [Install the latest version of Knative Serving](../../../install/README.md).
./docs/serving/samples/blue-green-deployment.md:17:- A Kubernetes cluster with [Knative installed](../../install/README.md).
./docs/serving/samples/secrets-go/index.md:25:  [installation instructions](../../../install/README.md) if you need to create
./docs/serving/samples/gitwebhook-go/index.md:19:    cluster, see the [installation guides](../../../install/README.md).
./docs/eventing/accessing-traces.md:14:You must have a Knative cluster running with the Eventing component installed. [Learn more](../install/README.md)
./docs/eventing/debugging/index.md:14:[Knative Eventing](../README.md). You don't need to be an expert, but do need to
./docs/eventing/debugging/index.md:19:1. Setup [Knative Eventing and an Eventing-contrib resource](../README.md).
./docs/eventing/samples/helloworld/helloworld-python/_index.md:11:However, you can also deploy the app as a [Knative Serving Service](../../../../serving/README.md).
./docs/eventing/samples/helloworld/helloworld-go/_index.md:19:[Knative Serving Service](../../../../serving/README.md).
./docs/eventing/samples/helloworld/helloworld-go/_index.md:283:We can send an http request directly to the [Broker](../../../broker/README.md)
./docs/eventing/samples/helloworld/_index.md:16:However, you can also deploy the app as a [Knative Serving Service](../../../serving/README.md)
./docs/eventing/samples/helloworld/_index.md:23:    [Knative Serving](../../../install/README.md).
./docs/eventing/samples/parallel/multiple-branches/_index.md:17:Please refer to the sample overview for the [prerequisites](../README.md).
./docs/eventing/samples/parallel/mutual-exclusivity/_index.md:12:[multiple branches example](../multiple-branches/README.md) except that we are
./docs/eventing/samples/parallel/mutual-exclusivity/_index.md:21:Please refer to the sample overview for the [prerequisites](../README.md).
./docs/eventing/samples/parallel/_index.md:25:[`PingSource`](../ping-source/README.md) as the source of events.
./docs/eventing/samples/parallel/_index.md:33:- [Parallel with multiple branches and global reply](./multiple-branches/README.md)
./docs/eventing/samples/parallel/_index.md:34:- [Parallel with mutually exclusive cases](./mutual-exclusivity/README.md)
./docs/eventing/samples/kafka/source/index.md:8:Tutorial on how to build and deploy a `KafkaSource` [Eventing source](../../../sources/README.md) using a Knative Serving `Service`.
./docs/eventing/samples/kafka/source/index.md:12:- Ensure that you meet the [prerequisites listed in the Apache Kafka overview](../README.md).
./docs/eventing/samples/kafka/source/index.md:13:- A Kubernetes cluster with [Knative Kafka Source installed](../../../../install/README.md).
./docs/eventing/samples/kafka/binding/index.md:21:   [prerequisites listed in the Apache Kafka overview](../README.md).
./docs/eventing/samples/kafka/channel/index.md:14:  [prerequisites listed in the Apache Kafka overview](../README.md).
./docs/eventing/samples/kafka/channel/index.md:16:  [Knative Kafka Channel installed](../../../../install/README.md).
./docs/eventing/samples/kafka/_index.md:100:- [`KafkaSource` to `Service`](./source/README.md)
./docs/eventing/samples/kafka/_index.md:101:- [`KafkaChannel` and Broker](./channel/README.md)
./docs/eventing/samples/kafka/_index.md:102:- [`KafkaBinding`](./binding/README.md)
./docs/eventing/samples/gitlab-source/index.md:18:   Follow the [installation instructions](../../../install/README.md) if you
./docs/eventing/samples/_index.md:11:[Learn more about Knative Eventing and Eventing Sources](../README.md).
./docs/eventing/flows/parallel.md:47:Learn how to use Parallel by following the [examples](../samples/parallel/README.md)
./vendor/knative.dev/hack/README.md:114:   [here](../kntest/pkg/kubetest2/gke/README.md) to the `initialize` function

Proposed Changes

Fix broken links

knative-prow-robot · 2021-05-15T14:56:12Z

Welcome @novahe! It looks like this is your first PR to knative/docs 🎉

knative-prow-robot · 2021-05-15T14:56:12Z

Hi @novahe. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

novahe · 2021-05-15T15:15:43Z

/cc @abrennan89 PTAL, thanks

abrennan89 · 2021-05-17T14:33:20Z

/ok-to-test

novahe · 2021-05-17T15:18:13Z

/test pull-knative-docs-integration-tests

abrennan89 · 2021-05-17T17:32:21Z

@novahe have you tested the links using a local build of the docs?

novahe · 2021-05-18T14:46:58Z

I just started to get familiar with the project’s contribution process, which caused you trouble, I am so sorry. I have re-read the contribution document in detail, and I also know that you can preview the web page here in netlify , I will contribute higher quality PR in the future.

abrennan89 · 2021-05-18T15:51:55Z

No problem at all @novahe - thanks so much for the preview link!
/lgtm
/approve

knative-prow-robot · 2021-05-18T15:52:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~docs/eventing/OWNERS~~ [abrennan89]
~~docs/serving/OWNERS~~ [abrennan89]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…e website, create `/snippets` directory (#3610) * change name for menu item for preview (#3533) Signed-off-by: Carlos Santana <csantana23@gmail.com> * Added detail per issue #3425 (#3514) * Update knative/community files (#3553) Signed-off-by: Knative Automation <automation@knative.team> * tracing cm fix (#3506) * remove unnecessary requrirements to do a release (#3563) Signed-off-by: Carlos Santana <csantana23@gmail.com> * #3543 fix link (#3567) * Replace xip.io with sslip.io (#3574) * Update actions (#3535) Signed-off-by: Knative Automation <automation@knative.team> * Update common github actions (#3552) Signed-off-by: Knative Automation <automation@knative.team> * upgrade to latest dependencies (#3505) bumping knative.dev/hack 88c69cd...93ad912: > 93ad912 Print java and mvn version (# 65) > 86f9adc Fix default codegen pkg dir (# 67) Signed-off-by: Knative Automation <automation@knative.team> * Remove responsive-revision-gc config (#3545) Since knative/serving#10084 deleted old GC and started using responsive GC by default, `responsive-revision-gc` in `config-feature` is not used at all. This patch removes the configuration `responsive-revision-gc` in `config-feature` configmap. * Fixes #3117 and broken links (#3569) * Fix #3117 and broken links * Fix #3117 and broken links * remove spec folder and redirect page and update links * remove conflicts * Update shortcodes.md (#3550) minor grammar. * 💄 slight change to ordered delivery guarantees (#3536) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Add knative-release-leads to OWNERS (#3586) * add approvers ux (#3587) * Update the default value (#3530) * Adding notes on KafkaSource usage (#3596) * Adding some Kafka note for use-cases Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * changing the description Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Update actions (#3581) Signed-off-by: Knative Automation <automation@knative.team> * Remove python pycache (#3594) * Use correct setting in ClusterIssue setting (#3595) The doc uses ClusterIssuer `letsencrypt-http01-issuer` but the configuration uses `letsencrypt-issuer` so it is confusable. Actual report is #3560. So this patch changes the ClusterIssuer name to `letsencrypt-http01-issuer` which is used in this doc section. Fix #3560 * fix broken link #3568 #3577 (#3579) * fix Netlify build * Added Snippets folder and hidden Beta Contributor guide * Update docs/eventing/event-registry.md Co-authored-by: Carlos Santana <csantana23@gmail.com> * whitespace * more whitespace * removing this bit because linting is killing me * ok really the last one Co-authored-by: Carlos Santana <csantana23@gmail.com> Co-authored-by: RichardJJG <rijohnson@vmware.com> Co-authored-by: knative-automation <automation@knative.team> Co-authored-by: Shashankft9 <48708039+Shashankft9@users.noreply.github.com> Co-authored-by: Ashleigh Brennan <abrennan@redhat.com> Co-authored-by: Benjamin Tan Wei Hao <benjamintanweihao@gmail.com> Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com> Co-authored-by: Jonathan Johnson <jonathan.johnson@dijure.com> Co-authored-by: Matthias Wessendorf <mwessend@redhat.com> Co-authored-by: Evan Anderson <evana@vmware.com> Co-authored-by: RichieEscarez <rescarez@google.com> Co-authored-by: NovaHe <heqianfly@gmail.com>

* change name for menu item for preview (#3533) Signed-off-by: Carlos Santana <csantana23@gmail.com> * Added detail per issue #3425 (#3514) * Update knative/community files (#3553) Signed-off-by: Knative Automation <automation@knative.team> * tracing cm fix (#3506) * remove unnecessary requrirements to do a release (#3563) Signed-off-by: Carlos Santana <csantana23@gmail.com> * #3543 fix link (#3567) * Replace xip.io with sslip.io (#3574) * Update actions (#3535) Signed-off-by: Knative Automation <automation@knative.team> * Update common github actions (#3552) Signed-off-by: Knative Automation <automation@knative.team> * upgrade to latest dependencies (#3505) bumping knative.dev/hack 88c69cd...93ad912: > 93ad912 Print java and mvn version (# 65) > 86f9adc Fix default codegen pkg dir (# 67) Signed-off-by: Knative Automation <automation@knative.team> * Remove responsive-revision-gc config (#3545) Since knative/serving#10084 deleted old GC and started using responsive GC by default, `responsive-revision-gc` in `config-feature` is not used at all. This patch removes the configuration `responsive-revision-gc` in `config-feature` configmap. * Fixes #3117 and broken links (#3569) * Fix #3117 and broken links * Fix #3117 and broken links * remove spec folder and redirect page and update links * remove conflicts * Update shortcodes.md (#3550) minor grammar. * 💄 slight change to ordered delivery guarantees (#3536) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Add knative-release-leads to OWNERS (#3586) * add approvers ux (#3587) * Update the default value (#3530) * Adding notes on KafkaSource usage (#3596) * Adding some Kafka note for use-cases Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * changing the description Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Update actions (#3581) Signed-off-by: Knative Automation <automation@knative.team> * Remove python pycache (#3594) * Use correct setting in ClusterIssue setting (#3595) The doc uses ClusterIssuer `letsencrypt-http01-issuer` but the configuration uses `letsencrypt-issuer` so it is confusable. Actual report is #3560. So this patch changes the ClusterIssuer name to `letsencrypt-http01-issuer` which is used in this doc section. Fix #3560 * fix broken link #3568 #3577 (#3579) * fix Netlify build * Added Snippets folder and hidden Beta Contributor guide * Update docs/eventing/event-registry.md Co-authored-by: Carlos Santana <csantana23@gmail.com> * whitespace * more whitespace * removing this bit because linting is killing me * ok really the last one * Updating to latest API version of Strimzi. v1beta1 is now gone 🔥 (#3603) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * 📓 adding a note to not consume records of the kafkachannel's topic... (#3615) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * fix broken link in kogito example (#3602) * docs about usage of internal services in an "api-gateway" access model (#3597) Co-authored-by: Brüder, Lena <lena.brueder@maxxeed.com> * api specs for v0.23 (#3619) Signed-off-by: Carlos Santana <csantana23@gmail.com> * Update serving/_index.md with network layer option (#3585) * Update _index.md [#3117] Add ref for contour * Update docs/serving/_index.md Co-authored-by: Ashleigh Brennan <abrennan@redhat.com> Co-authored-by: Omer B <obensaadon@vmware.com> Co-authored-by: Ashleigh Brennan <abrennan@redhat.com> * Fix typos in the sample yaml file (#3616) * EventType is not yet part of the v1 eventing API (#3576) * Remaining changes from now closed PRs Co-authored-by: Carlos Santana <csantana23@gmail.com> Co-authored-by: RichardJJG <rijohnson@vmware.com> Co-authored-by: knative-automation <automation@knative.team> Co-authored-by: Shashankft9 <48708039+Shashankft9@users.noreply.github.com> Co-authored-by: Ashleigh Brennan <abrennan@redhat.com> Co-authored-by: Benjamin Tan Wei Hao <benjamintanweihao@gmail.com> Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com> Co-authored-by: Jonathan Johnson <jonathan.johnson@dijure.com> Co-authored-by: Matthias Wessendorf <mwessend@redhat.com> Co-authored-by: Evan Anderson <evana@vmware.com> Co-authored-by: RichieEscarez <rescarez@google.com> Co-authored-by: NovaHe <heqianfly@gmail.com> Co-authored-by: Kevin Marquardsen <mr.kmarq@gmail.com> Co-authored-by: Lena Brüder <oss@lena-brueder.de> Co-authored-by: Brüder, Lena <lena.brueder@maxxeed.com> Co-authored-by: Sameer Vohra <vsameer@vmware.com> Co-authored-by: Mahdi K. Fard <xclud@users.noreply.github.com>

…e website, create `/snippets` directory (knative#3610) * change name for menu item for preview (knative#3533) Signed-off-by: Carlos Santana <csantana23@gmail.com> * Added detail per issue knative#3425 (knative#3514) * Update knative/community files (knative#3553) Signed-off-by: Knative Automation <automation@knative.team> * tracing cm fix (knative#3506) * remove unnecessary requrirements to do a release (knative#3563) Signed-off-by: Carlos Santana <csantana23@gmail.com> * knative#3543 fix link (knative#3567) * Replace xip.io with sslip.io (knative#3574) * Update actions (knative#3535) Signed-off-by: Knative Automation <automation@knative.team> * Update common github actions (knative#3552) Signed-off-by: Knative Automation <automation@knative.team> * upgrade to latest dependencies (knative#3505) bumping knative.dev/hack 88c69cd...93ad912: > 93ad912 Print java and mvn version (# 65) > 86f9adc Fix default codegen pkg dir (# 67) Signed-off-by: Knative Automation <automation@knative.team> * Remove responsive-revision-gc config (knative#3545) Since knative/serving#10084 deleted old GC and started using responsive GC by default, `responsive-revision-gc` in `config-feature` is not used at all. This patch removes the configuration `responsive-revision-gc` in `config-feature` configmap. * Fixes knative#3117 and broken links (knative#3569) * Fix knative#3117 and broken links * Fix knative#3117 and broken links * remove spec folder and redirect page and update links * remove conflicts * Update shortcodes.md (knative#3550) minor grammar. * 💄 slight change to ordered delivery guarantees (knative#3536) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Add knative-release-leads to OWNERS (knative#3586) * add approvers ux (knative#3587) * Update the default value (knative#3530) * Adding notes on KafkaSource usage (knative#3596) * Adding some Kafka note for use-cases Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * changing the description Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Update actions (knative#3581) Signed-off-by: Knative Automation <automation@knative.team> * Remove python pycache (knative#3594) * Use correct setting in ClusterIssue setting (knative#3595) The doc uses ClusterIssuer `letsencrypt-http01-issuer` but the configuration uses `letsencrypt-issuer` so it is confusable. Actual report is knative#3560. So this patch changes the ClusterIssuer name to `letsencrypt-http01-issuer` which is used in this doc section. Fix knative#3560 * fix broken link knative#3568 knative#3577 (knative#3579) * fix Netlify build * Added Snippets folder and hidden Beta Contributor guide * Update docs/eventing/event-registry.md Co-authored-by: Carlos Santana <csantana23@gmail.com> * whitespace * more whitespace * removing this bit because linting is killing me * ok really the last one Co-authored-by: Carlos Santana <csantana23@gmail.com> Co-authored-by: RichardJJG <rijohnson@vmware.com> Co-authored-by: knative-automation <automation@knative.team> Co-authored-by: Shashankft9 <48708039+Shashankft9@users.noreply.github.com> Co-authored-by: Ashleigh Brennan <abrennan@redhat.com> Co-authored-by: Benjamin Tan Wei Hao <benjamintanweihao@gmail.com> Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com> Co-authored-by: Jonathan Johnson <jonathan.johnson@dijure.com> Co-authored-by: Matthias Wessendorf <mwessend@redhat.com> Co-authored-by: Evan Anderson <evana@vmware.com> Co-authored-by: RichieEscarez <rescarez@google.com> Co-authored-by: NovaHe <heqianfly@gmail.com>

* change name for menu item for preview (knative#3533) Signed-off-by: Carlos Santana <csantana23@gmail.com> * Added detail per issue knative#3425 (knative#3514) * Update knative/community files (knative#3553) Signed-off-by: Knative Automation <automation@knative.team> * tracing cm fix (knative#3506) * remove unnecessary requrirements to do a release (knative#3563) Signed-off-by: Carlos Santana <csantana23@gmail.com> * knative#3543 fix link (knative#3567) * Replace xip.io with sslip.io (knative#3574) * Update actions (knative#3535) Signed-off-by: Knative Automation <automation@knative.team> * Update common github actions (knative#3552) Signed-off-by: Knative Automation <automation@knative.team> * upgrade to latest dependencies (knative#3505) bumping knative.dev/hack 88c69cd...93ad912: > 93ad912 Print java and mvn version (# 65) > 86f9adc Fix default codegen pkg dir (# 67) Signed-off-by: Knative Automation <automation@knative.team> * Remove responsive-revision-gc config (knative#3545) Since knative/serving#10084 deleted old GC and started using responsive GC by default, `responsive-revision-gc` in `config-feature` is not used at all. This patch removes the configuration `responsive-revision-gc` in `config-feature` configmap. * Fixes knative#3117 and broken links (knative#3569) * Fix knative#3117 and broken links * Fix knative#3117 and broken links * remove spec folder and redirect page and update links * remove conflicts * Update shortcodes.md (knative#3550) minor grammar. * 💄 slight change to ordered delivery guarantees (knative#3536) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Add knative-release-leads to OWNERS (knative#3586) * add approvers ux (knative#3587) * Update the default value (knative#3530) * Adding notes on KafkaSource usage (knative#3596) * Adding some Kafka note for use-cases Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * changing the description Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Update actions (knative#3581) Signed-off-by: Knative Automation <automation@knative.team> * Remove python pycache (knative#3594) * Use correct setting in ClusterIssue setting (knative#3595) The doc uses ClusterIssuer `letsencrypt-http01-issuer` but the configuration uses `letsencrypt-issuer` so it is confusable. Actual report is knative#3560. So this patch changes the ClusterIssuer name to `letsencrypt-http01-issuer` which is used in this doc section. Fix knative#3560 * fix broken link knative#3568 knative#3577 (knative#3579) * fix Netlify build * Added Snippets folder and hidden Beta Contributor guide * Update docs/eventing/event-registry.md Co-authored-by: Carlos Santana <csantana23@gmail.com> * whitespace * more whitespace * removing this bit because linting is killing me * ok really the last one * Updating to latest API version of Strimzi. v1beta1 is now gone 🔥 (knative#3603) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * 📓 adding a note to not consume records of the kafkachannel's topic... (knative#3615) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * fix broken link in kogito example (knative#3602) * docs about usage of internal services in an "api-gateway" access model (knative#3597) Co-authored-by: Brüder, Lena <lena.brueder@maxxeed.com> * api specs for v0.23 (knative#3619) Signed-off-by: Carlos Santana <csantana23@gmail.com> * Update serving/_index.md with network layer option (knative#3585) * Update _index.md [knative#3117] Add ref for contour * Update docs/serving/_index.md Co-authored-by: Ashleigh Brennan <abrennan@redhat.com> Co-authored-by: Omer B <obensaadon@vmware.com> Co-authored-by: Ashleigh Brennan <abrennan@redhat.com> * Fix typos in the sample yaml file (knative#3616) * EventType is not yet part of the v1 eventing API (knative#3576) * Remaining changes from now closed PRs Co-authored-by: Carlos Santana <csantana23@gmail.com> Co-authored-by: RichardJJG <rijohnson@vmware.com> Co-authored-by: knative-automation <automation@knative.team> Co-authored-by: Shashankft9 <48708039+Shashankft9@users.noreply.github.com> Co-authored-by: Ashleigh Brennan <abrennan@redhat.com> Co-authored-by: Benjamin Tan Wei Hao <benjamintanweihao@gmail.com> Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com> Co-authored-by: Jonathan Johnson <jonathan.johnson@dijure.com> Co-authored-by: Matthias Wessendorf <mwessend@redhat.com> Co-authored-by: Evan Anderson <evana@vmware.com> Co-authored-by: RichieEscarez <rescarez@google.com> Co-authored-by: NovaHe <heqianfly@gmail.com> Co-authored-by: Kevin Marquardsen <mr.kmarq@gmail.com> Co-authored-by: Lena Brüder <oss@lena-brueder.de> Co-authored-by: Brüder, Lena <lena.brueder@maxxeed.com> Co-authored-by: Sameer Vohra <vsameer@vmware.com> Co-authored-by: Mahdi K. Fard <xclud@users.noreply.github.com>

…e website, create `/snippets` directory (knative#3610) * change name for menu item for preview (knative#3533) Signed-off-by: Carlos Santana <csantana23@gmail.com> * Added detail per issue knative#3425 (knative#3514) * Update knative/community files (knative#3553) Signed-off-by: Knative Automation <automation@knative.team> * tracing cm fix (knative#3506) * remove unnecessary requrirements to do a release (knative#3563) Signed-off-by: Carlos Santana <csantana23@gmail.com> * knative#3543 fix link (knative#3567) * Replace xip.io with sslip.io (knative#3574) * Update actions (knative#3535) Signed-off-by: Knative Automation <automation@knative.team> * Update common github actions (knative#3552) Signed-off-by: Knative Automation <automation@knative.team> * upgrade to latest dependencies (knative#3505) bumping knative.dev/hack 88c69cd...93ad912: > 93ad912 Print java and mvn version (# 65) > 86f9adc Fix default codegen pkg dir (# 67) Signed-off-by: Knative Automation <automation@knative.team> * Remove responsive-revision-gc config (knative#3545) Since knative/serving#10084 deleted old GC and started using responsive GC by default, `responsive-revision-gc` in `config-feature` is not used at all. This patch removes the configuration `responsive-revision-gc` in `config-feature` configmap. * Fixes knative#3117 and broken links (knative#3569) * Fix knative#3117 and broken links * Fix knative#3117 and broken links * remove spec folder and redirect page and update links * remove conflicts * Update shortcodes.md (knative#3550) minor grammar. * 💄 slight change to ordered delivery guarantees (knative#3536) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Add knative-release-leads to OWNERS (knative#3586) * add approvers ux (knative#3587) * Update the default value (knative#3530) * Adding notes on KafkaSource usage (knative#3596) * Adding some Kafka note for use-cases Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * changing the description Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Update actions (knative#3581) Signed-off-by: Knative Automation <automation@knative.team> * Remove python pycache (knative#3594) * Use correct setting in ClusterIssue setting (knative#3595) The doc uses ClusterIssuer `letsencrypt-http01-issuer` but the configuration uses `letsencrypt-issuer` so it is confusable. Actual report is knative#3560. So this patch changes the ClusterIssuer name to `letsencrypt-http01-issuer` which is used in this doc section. Fix knative#3560 * fix broken link knative#3568 knative#3577 (knative#3579) * fix Netlify build * Added Snippets folder and hidden Beta Contributor guide * Update docs/eventing/event-registry.md Co-authored-by: Carlos Santana <csantana23@gmail.com> * whitespace * more whitespace * removing this bit because linting is killing me * ok really the last one Co-authored-by: Carlos Santana <csantana23@gmail.com> Co-authored-by: RichardJJG <rijohnson@vmware.com> Co-authored-by: knative-automation <automation@knative.team> Co-authored-by: Shashankft9 <48708039+Shashankft9@users.noreply.github.com> Co-authored-by: Ashleigh Brennan <abrennan@redhat.com> Co-authored-by: Benjamin Tan Wei Hao <benjamintanweihao@gmail.com> Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com> Co-authored-by: Jonathan Johnson <jonathan.johnson@dijure.com> Co-authored-by: Matthias Wessendorf <mwessend@redhat.com> Co-authored-by: Evan Anderson <evana@vmware.com> Co-authored-by: RichieEscarez <rescarez@google.com> Co-authored-by: NovaHe <heqianfly@gmail.com>

* change name for menu item for preview (knative#3533) Signed-off-by: Carlos Santana <csantana23@gmail.com> * Added detail per issue knative#3425 (knative#3514) * Update knative/community files (knative#3553) Signed-off-by: Knative Automation <automation@knative.team> * tracing cm fix (knative#3506) * remove unnecessary requrirements to do a release (knative#3563) Signed-off-by: Carlos Santana <csantana23@gmail.com> * knative#3543 fix link (knative#3567) * Replace xip.io with sslip.io (knative#3574) * Update actions (knative#3535) Signed-off-by: Knative Automation <automation@knative.team> * Update common github actions (knative#3552) Signed-off-by: Knative Automation <automation@knative.team> * upgrade to latest dependencies (knative#3505) bumping knative.dev/hack 88c69cd...93ad912: > 93ad912 Print java and mvn version (# 65) > 86f9adc Fix default codegen pkg dir (# 67) Signed-off-by: Knative Automation <automation@knative.team> * Remove responsive-revision-gc config (knative#3545) Since knative/serving#10084 deleted old GC and started using responsive GC by default, `responsive-revision-gc` in `config-feature` is not used at all. This patch removes the configuration `responsive-revision-gc` in `config-feature` configmap. * Fixes knative#3117 and broken links (knative#3569) * Fix knative#3117 and broken links * Fix knative#3117 and broken links * remove spec folder and redirect page and update links * remove conflicts * Update shortcodes.md (knative#3550) minor grammar. * 💄 slight change to ordered delivery guarantees (knative#3536) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Add knative-release-leads to OWNERS (knative#3586) * add approvers ux (knative#3587) * Update the default value (knative#3530) * Adding notes on KafkaSource usage (knative#3596) * Adding some Kafka note for use-cases Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * changing the description Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Update actions (knative#3581) Signed-off-by: Knative Automation <automation@knative.team> * Remove python pycache (knative#3594) * Use correct setting in ClusterIssue setting (knative#3595) The doc uses ClusterIssuer `letsencrypt-http01-issuer` but the configuration uses `letsencrypt-issuer` so it is confusable. Actual report is knative#3560. So this patch changes the ClusterIssuer name to `letsencrypt-http01-issuer` which is used in this doc section. Fix knative#3560 * fix broken link knative#3568 knative#3577 (knative#3579) * fix Netlify build * Added Snippets folder and hidden Beta Contributor guide * Update docs/eventing/event-registry.md Co-authored-by: Carlos Santana <csantana23@gmail.com> * whitespace * more whitespace * removing this bit because linting is killing me * ok really the last one * Updating to latest API version of Strimzi. v1beta1 is now gone 🔥 (knative#3603) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * 📓 adding a note to not consume records of the kafkachannel's topic... (knative#3615) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * fix broken link in kogito example (knative#3602) * docs about usage of internal services in an "api-gateway" access model (knative#3597) Co-authored-by: Brüder, Lena <lena.brueder@maxxeed.com> * api specs for v0.23 (knative#3619) Signed-off-by: Carlos Santana <csantana23@gmail.com> * Update serving/_index.md with network layer option (knative#3585) * Update _index.md [knative#3117] Add ref for contour * Update docs/serving/_index.md Co-authored-by: Ashleigh Brennan <abrennan@redhat.com> Co-authored-by: Omer B <obensaadon@vmware.com> Co-authored-by: Ashleigh Brennan <abrennan@redhat.com> * Fix typos in the sample yaml file (knative#3616) * EventType is not yet part of the v1 eventing API (knative#3576) * Remaining changes from now closed PRs Co-authored-by: Carlos Santana <csantana23@gmail.com> Co-authored-by: RichardJJG <rijohnson@vmware.com> Co-authored-by: knative-automation <automation@knative.team> Co-authored-by: Shashankft9 <48708039+Shashankft9@users.noreply.github.com> Co-authored-by: Ashleigh Brennan <abrennan@redhat.com> Co-authored-by: Benjamin Tan Wei Hao <benjamintanweihao@gmail.com> Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com> Co-authored-by: Jonathan Johnson <jonathan.johnson@dijure.com> Co-authored-by: Matthias Wessendorf <mwessend@redhat.com> Co-authored-by: Evan Anderson <evana@vmware.com> Co-authored-by: RichieEscarez <rescarez@google.com> Co-authored-by: NovaHe <heqianfly@gmail.com> Co-authored-by: Kevin Marquardsen <mr.kmarq@gmail.com> Co-authored-by: Lena Brüder <oss@lena-brueder.de> Co-authored-by: Brüder, Lena <lena.brueder@maxxeed.com> Co-authored-by: Sameer Vohra <vsameer@vmware.com> Co-authored-by: Mahdi K. Fard <xclud@users.noreply.github.com>

google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label May 15, 2021

knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 15, 2021

knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 15, 2021

abrennan89 reviewed May 17, 2021

View reviewed changes

Comment thread docs/eventing/accessing-traces.md Outdated

knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 17, 2021

novahe force-pushed the fix/links branch from 2e6e85d to 415d0a9 Compare May 17, 2021 15:15

abrennan89 reviewed May 17, 2021

View reviewed changes

Comment thread docs/eventing/channels/channel-types-defaults.md Outdated

fix broken link knative#3568 knative#3577

8668cad

novahe force-pushed the fix/links branch from 415d0a9 to 8668cad Compare May 18, 2021 14:21

knative-prow-robot assigned abrennan89 May 18, 2021

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2021

knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2021

knative-prow-robot merged commit f8e75be into knative:main May 18, 2021

novahe deleted the fix/links branch May 18, 2021 16:03

novahe mentioned this pull request May 27, 2021

Add novahe to the members list knative/community#637

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix broken links#3579

Fix broken links#3579
knative-prow-robot merged 1 commit into
knative:mainfrom
novahe:fix/links

novahe commented May 15, 2021 •

edited

Loading

Uh oh!

knative-prow-robot commented May 15, 2021

Uh oh!

knative-prow-robot commented May 15, 2021

Uh oh!

novahe commented May 15, 2021 •

edited

Loading

Uh oh!

Uh oh!

abrennan89 commented May 17, 2021

Uh oh!

novahe commented May 17, 2021

Uh oh!

Uh oh!

abrennan89 commented May 17, 2021

Uh oh!

novahe commented May 18, 2021 •

edited

Loading

Uh oh!

abrennan89 commented May 18, 2021

Uh oh!

knative-prow-robot commented May 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

novahe commented May 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

Uh oh!

knative-prow-robot commented May 15, 2021

Uh oh!

knative-prow-robot commented May 15, 2021

Uh oh!

novahe commented May 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

abrennan89 commented May 17, 2021

Uh oh!

novahe commented May 17, 2021

Uh oh!

Uh oh!

abrennan89 commented May 17, 2021

Uh oh!

novahe commented May 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abrennan89 commented May 18, 2021

Uh oh!

knative-prow-robot commented May 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

novahe commented May 15, 2021 •

edited

Loading

novahe commented May 15, 2021 •

edited

Loading

novahe commented May 18, 2021 •

edited

Loading