Skip to content

config-tracing configmap fix#3506

Merged
knative-prow-robot merged 1 commit into
knative:mainfrom
Shashankft9:tracing-cm-fix
May 12, 2021
Merged

config-tracing configmap fix#3506
knative-prow-robot merged 1 commit into
knative:mainfrom
Shashankft9:tracing-cm-fix

Conversation

@Shashankft9
Copy link
Copy Markdown
Contributor

@Shashankft9 Shashankft9 commented Apr 28, 2021

"Fixes #issue-number" or "Add description of the problem this PR solves"
Noticed that the key enable is not even in the structure of tracing config:

type Config struct {
    Backend              BackendType
    ZipkinEndpoint       string
    StackdriverProjectID string
    Debug                bool
    SampleRate           float64
}

also noticed here: knative/eventing#1889 (comment)
also its not mentioned in the configuration options in the doc, so I figured it might be something left over from previous versions. Let me know if it really is required?

Proposed Changes

  • just replaced enable key with backend

@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 28, 2021
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 28, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor

Hi @Shashankft9. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abrennan89 abrennan89 requested a review from nak3 May 1, 2021 00:18
@abrennan89 abrennan89 added triage/needs-eng-input Engineering input is requested kind/serving labels May 1, 2021
@abrennan89
Copy link
Copy Markdown
Contributor

/ok-to-test
/hold

@knative-prow-robot knative-prow-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 1, 2021
Copy link
Copy Markdown
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2021
Copy link
Copy Markdown
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2021
@abrennan89
Copy link
Copy Markdown
Contributor

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 12, 2021
@abrennan89 abrennan89 added this to the v0.23.0 milestone May 12, 2021
@knative-prow-robot knative-prow-robot merged commit 59494a1 into knative:main May 12, 2021
knative-prow-robot pushed a commit that referenced this pull request May 19, 2021
…e website, create `/snippets` directory (#3610)

* change name for menu item for preview (#3533)

Signed-off-by: Carlos Santana <csantana23@gmail.com>

* Added detail per issue #3425 (#3514)

* Update knative/community files (#3553)

Signed-off-by: Knative Automation <automation@knative.team>

* tracing cm fix (#3506)

* remove unnecessary requrirements to do a release (#3563)

Signed-off-by: Carlos Santana <csantana23@gmail.com>

* #3543 fix link (#3567)

* Replace xip.io with sslip.io (#3574)

* Update actions (#3535)

Signed-off-by: Knative Automation <automation@knative.team>

* Update common github actions (#3552)

Signed-off-by: Knative Automation <automation@knative.team>

* upgrade to latest dependencies (#3505)

bumping knative.dev/hack 88c69cd...93ad912:
  > 93ad912 Print java and mvn version (# 65)
  > 86f9adc Fix default codegen pkg dir (# 67)

Signed-off-by: Knative Automation <automation@knative.team>

* Remove responsive-revision-gc config (#3545)

Since knative/serving#10084 deleted old GC and
started using responsive GC by default, `responsive-revision-gc` in
`config-feature` is not used at all.

This patch removes the configuration `responsive-revision-gc` in
`config-feature` configmap.

* Fixes #3117 and broken links (#3569)

* Fix #3117 and broken links

* Fix #3117 and broken links

* remove spec folder and redirect page and update links

* remove conflicts

* Update shortcodes.md (#3550)

minor grammar.

* 💄 slight change to ordered delivery guarantees (#3536)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Add knative-release-leads to OWNERS (#3586)

* add approvers ux (#3587)

* Update the default value (#3530)

* Adding notes on KafkaSource usage (#3596)

* Adding some Kafka note for use-cases

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* changing the description

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Update actions (#3581)

Signed-off-by: Knative Automation <automation@knative.team>

* Remove python pycache (#3594)

* Use correct setting in ClusterIssue setting (#3595)

The doc uses ClusterIssuer `letsencrypt-http01-issuer` but the configuration uses
`letsencrypt-issuer` so it is confusable.
Actual report is #3560.

So this patch changes the ClusterIssuer name to
`letsencrypt-http01-issuer` which is used in this doc section.

Fix #3560

* fix broken link #3568 #3577 (#3579)

* fix Netlify build

* Added Snippets folder and hidden Beta Contributor guide

* Update docs/eventing/event-registry.md

Co-authored-by: Carlos Santana <csantana23@gmail.com>

* whitespace

* more whitespace

* removing this bit because linting is killing me

* ok really the last one

Co-authored-by: Carlos Santana <csantana23@gmail.com>
Co-authored-by: RichardJJG <rijohnson@vmware.com>
Co-authored-by: knative-automation <automation@knative.team>
Co-authored-by: Shashankft9 <48708039+Shashankft9@users.noreply.github.com>
Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>
Co-authored-by: Benjamin Tan Wei Hao <benjamintanweihao@gmail.com>
Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
Co-authored-by: Jonathan Johnson <jonathan.johnson@dijure.com>
Co-authored-by: Matthias Wessendorf <mwessend@redhat.com>
Co-authored-by: Evan Anderson <evana@vmware.com>
Co-authored-by: RichieEscarez <rescarez@google.com>
Co-authored-by: NovaHe <heqianfly@gmail.com>
knative-prow-robot pushed a commit that referenced this pull request May 19, 2021
* change name for menu item for preview (#3533)

Signed-off-by: Carlos Santana <csantana23@gmail.com>

* Added detail per issue #3425 (#3514)

* Update knative/community files (#3553)

Signed-off-by: Knative Automation <automation@knative.team>

* tracing cm fix (#3506)

* remove unnecessary requrirements to do a release (#3563)

Signed-off-by: Carlos Santana <csantana23@gmail.com>

* #3543 fix link (#3567)

* Replace xip.io with sslip.io (#3574)

* Update actions (#3535)

Signed-off-by: Knative Automation <automation@knative.team>

* Update common github actions (#3552)

Signed-off-by: Knative Automation <automation@knative.team>

* upgrade to latest dependencies (#3505)

bumping knative.dev/hack 88c69cd...93ad912:
  > 93ad912 Print java and mvn version (# 65)
  > 86f9adc Fix default codegen pkg dir (# 67)

Signed-off-by: Knative Automation <automation@knative.team>

* Remove responsive-revision-gc config (#3545)

Since knative/serving#10084 deleted old GC and
started using responsive GC by default, `responsive-revision-gc` in
`config-feature` is not used at all.

This patch removes the configuration `responsive-revision-gc` in
`config-feature` configmap.

* Fixes #3117 and broken links (#3569)

* Fix #3117 and broken links

* Fix #3117 and broken links

* remove spec folder and redirect page and update links

* remove conflicts

* Update shortcodes.md (#3550)

minor grammar.

* 💄 slight change to ordered delivery guarantees (#3536)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Add knative-release-leads to OWNERS (#3586)

* add approvers ux (#3587)

* Update the default value (#3530)

* Adding notes on KafkaSource usage (#3596)

* Adding some Kafka note for use-cases

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* changing the description

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Update actions (#3581)

Signed-off-by: Knative Automation <automation@knative.team>

* Remove python pycache (#3594)

* Use correct setting in ClusterIssue setting (#3595)

The doc uses ClusterIssuer `letsencrypt-http01-issuer` but the configuration uses
`letsencrypt-issuer` so it is confusable.
Actual report is #3560.

So this patch changes the ClusterIssuer name to
`letsencrypt-http01-issuer` which is used in this doc section.

Fix #3560

* fix broken link #3568 #3577 (#3579)

* fix Netlify build

* Added Snippets folder and hidden Beta Contributor guide

* Update docs/eventing/event-registry.md

Co-authored-by: Carlos Santana <csantana23@gmail.com>

* whitespace

* more whitespace

* removing this bit because linting is killing me

* ok really the last one

* Updating to latest API version of Strimzi. v1beta1 is now gone 🔥 (#3603)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* 📓 adding a note to not consume records of the kafkachannel's topic... (#3615)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* fix broken link in kogito example (#3602)

* docs about usage of internal services in an "api-gateway" access model (#3597)

Co-authored-by: Brüder, Lena <lena.brueder@maxxeed.com>

* api specs for v0.23 (#3619)

Signed-off-by: Carlos Santana <csantana23@gmail.com>

* Update serving/_index.md with network layer option (#3585)

* Update _index.md

[#3117] Add ref for contour

* Update docs/serving/_index.md

Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>

Co-authored-by: Omer B <obensaadon@vmware.com>
Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>

* Fix typos in the sample yaml file (#3616)

* EventType is not yet part of the v1 eventing API (#3576)

* Remaining changes from now closed PRs

Co-authored-by: Carlos Santana <csantana23@gmail.com>
Co-authored-by: RichardJJG <rijohnson@vmware.com>
Co-authored-by: knative-automation <automation@knative.team>
Co-authored-by: Shashankft9 <48708039+Shashankft9@users.noreply.github.com>
Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>
Co-authored-by: Benjamin Tan Wei Hao <benjamintanweihao@gmail.com>
Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
Co-authored-by: Jonathan Johnson <jonathan.johnson@dijure.com>
Co-authored-by: Matthias Wessendorf <mwessend@redhat.com>
Co-authored-by: Evan Anderson <evana@vmware.com>
Co-authored-by: RichieEscarez <rescarez@google.com>
Co-authored-by: NovaHe <heqianfly@gmail.com>
Co-authored-by: Kevin Marquardsen <mr.kmarq@gmail.com>
Co-authored-by: Lena Brüder <oss@lena-brueder.de>
Co-authored-by: Brüder, Lena <lena.brueder@maxxeed.com>
Co-authored-by: Sameer Vohra <vsameer@vmware.com>
Co-authored-by: Mahdi K. Fard <xclud@users.noreply.github.com>
RichardJJG added a commit to RichardJJG/docs that referenced this pull request Jun 30, 2021
…e website, create `/snippets` directory (knative#3610)

* change name for menu item for preview (knative#3533)

Signed-off-by: Carlos Santana <csantana23@gmail.com>

* Added detail per issue knative#3425 (knative#3514)

* Update knative/community files (knative#3553)

Signed-off-by: Knative Automation <automation@knative.team>

* tracing cm fix (knative#3506)

* remove unnecessary requrirements to do a release (knative#3563)

Signed-off-by: Carlos Santana <csantana23@gmail.com>

* knative#3543 fix link (knative#3567)

* Replace xip.io with sslip.io (knative#3574)

* Update actions (knative#3535)

Signed-off-by: Knative Automation <automation@knative.team>

* Update common github actions (knative#3552)

Signed-off-by: Knative Automation <automation@knative.team>

* upgrade to latest dependencies (knative#3505)

bumping knative.dev/hack 88c69cd...93ad912:
  > 93ad912 Print java and mvn version (# 65)
  > 86f9adc Fix default codegen pkg dir (# 67)

Signed-off-by: Knative Automation <automation@knative.team>

* Remove responsive-revision-gc config (knative#3545)

Since knative/serving#10084 deleted old GC and
started using responsive GC by default, `responsive-revision-gc` in
`config-feature` is not used at all.

This patch removes the configuration `responsive-revision-gc` in
`config-feature` configmap.

* Fixes knative#3117 and broken links (knative#3569)

* Fix knative#3117 and broken links

* Fix knative#3117 and broken links

* remove spec folder and redirect page and update links

* remove conflicts

* Update shortcodes.md (knative#3550)

minor grammar.

* 💄 slight change to ordered delivery guarantees (knative#3536)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Add knative-release-leads to OWNERS (knative#3586)

* add approvers ux (knative#3587)

* Update the default value (knative#3530)

* Adding notes on KafkaSource usage (knative#3596)

* Adding some Kafka note for use-cases

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* changing the description

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Update actions (knative#3581)

Signed-off-by: Knative Automation <automation@knative.team>

* Remove python pycache (knative#3594)

* Use correct setting in ClusterIssue setting (knative#3595)

The doc uses ClusterIssuer `letsencrypt-http01-issuer` but the configuration uses
`letsencrypt-issuer` so it is confusable.
Actual report is knative#3560.

So this patch changes the ClusterIssuer name to
`letsencrypt-http01-issuer` which is used in this doc section.

Fix knative#3560

* fix broken link knative#3568 knative#3577 (knative#3579)

* fix Netlify build

* Added Snippets folder and hidden Beta Contributor guide

* Update docs/eventing/event-registry.md

Co-authored-by: Carlos Santana <csantana23@gmail.com>

* whitespace

* more whitespace

* removing this bit because linting is killing me

* ok really the last one

Co-authored-by: Carlos Santana <csantana23@gmail.com>
Co-authored-by: RichardJJG <rijohnson@vmware.com>
Co-authored-by: knative-automation <automation@knative.team>
Co-authored-by: Shashankft9 <48708039+Shashankft9@users.noreply.github.com>
Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>
Co-authored-by: Benjamin Tan Wei Hao <benjamintanweihao@gmail.com>
Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
Co-authored-by: Jonathan Johnson <jonathan.johnson@dijure.com>
Co-authored-by: Matthias Wessendorf <mwessend@redhat.com>
Co-authored-by: Evan Anderson <evana@vmware.com>
Co-authored-by: RichieEscarez <rescarez@google.com>
Co-authored-by: NovaHe <heqianfly@gmail.com>
RichardJJG added a commit to RichardJJG/docs that referenced this pull request Jun 30, 2021
* change name for menu item for preview (knative#3533)

Signed-off-by: Carlos Santana <csantana23@gmail.com>

* Added detail per issue knative#3425 (knative#3514)

* Update knative/community files (knative#3553)

Signed-off-by: Knative Automation <automation@knative.team>

* tracing cm fix (knative#3506)

* remove unnecessary requrirements to do a release (knative#3563)

Signed-off-by: Carlos Santana <csantana23@gmail.com>

* knative#3543 fix link (knative#3567)

* Replace xip.io with sslip.io (knative#3574)

* Update actions (knative#3535)

Signed-off-by: Knative Automation <automation@knative.team>

* Update common github actions (knative#3552)

Signed-off-by: Knative Automation <automation@knative.team>

* upgrade to latest dependencies (knative#3505)

bumping knative.dev/hack 88c69cd...93ad912:
  > 93ad912 Print java and mvn version (# 65)
  > 86f9adc Fix default codegen pkg dir (# 67)

Signed-off-by: Knative Automation <automation@knative.team>

* Remove responsive-revision-gc config (knative#3545)

Since knative/serving#10084 deleted old GC and
started using responsive GC by default, `responsive-revision-gc` in
`config-feature` is not used at all.

This patch removes the configuration `responsive-revision-gc` in
`config-feature` configmap.

* Fixes knative#3117 and broken links (knative#3569)

* Fix knative#3117 and broken links

* Fix knative#3117 and broken links

* remove spec folder and redirect page and update links

* remove conflicts

* Update shortcodes.md (knative#3550)

minor grammar.

* 💄 slight change to ordered delivery guarantees (knative#3536)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Add knative-release-leads to OWNERS (knative#3586)

* add approvers ux (knative#3587)

* Update the default value (knative#3530)

* Adding notes on KafkaSource usage (knative#3596)

* Adding some Kafka note for use-cases

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* changing the description

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Update actions (knative#3581)

Signed-off-by: Knative Automation <automation@knative.team>

* Remove python pycache (knative#3594)

* Use correct setting in ClusterIssue setting (knative#3595)

The doc uses ClusterIssuer `letsencrypt-http01-issuer` but the configuration uses
`letsencrypt-issuer` so it is confusable.
Actual report is knative#3560.

So this patch changes the ClusterIssuer name to
`letsencrypt-http01-issuer` which is used in this doc section.

Fix knative#3560

* fix broken link knative#3568 knative#3577 (knative#3579)

* fix Netlify build

* Added Snippets folder and hidden Beta Contributor guide

* Update docs/eventing/event-registry.md

Co-authored-by: Carlos Santana <csantana23@gmail.com>

* whitespace

* more whitespace

* removing this bit because linting is killing me

* ok really the last one

* Updating to latest API version of Strimzi. v1beta1 is now gone 🔥 (knative#3603)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* 📓 adding a note to not consume records of the kafkachannel's topic... (knative#3615)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* fix broken link in kogito example (knative#3602)

* docs about usage of internal services in an "api-gateway" access model (knative#3597)

Co-authored-by: Brüder, Lena <lena.brueder@maxxeed.com>

* api specs for v0.23 (knative#3619)

Signed-off-by: Carlos Santana <csantana23@gmail.com>

* Update serving/_index.md with network layer option (knative#3585)

* Update _index.md

[knative#3117] Add ref for contour

* Update docs/serving/_index.md

Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>

Co-authored-by: Omer B <obensaadon@vmware.com>
Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>

* Fix typos in the sample yaml file (knative#3616)

* EventType is not yet part of the v1 eventing API (knative#3576)

* Remaining changes from now closed PRs

Co-authored-by: Carlos Santana <csantana23@gmail.com>
Co-authored-by: RichardJJG <rijohnson@vmware.com>
Co-authored-by: knative-automation <automation@knative.team>
Co-authored-by: Shashankft9 <48708039+Shashankft9@users.noreply.github.com>
Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>
Co-authored-by: Benjamin Tan Wei Hao <benjamintanweihao@gmail.com>
Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
Co-authored-by: Jonathan Johnson <jonathan.johnson@dijure.com>
Co-authored-by: Matthias Wessendorf <mwessend@redhat.com>
Co-authored-by: Evan Anderson <evana@vmware.com>
Co-authored-by: RichieEscarez <rescarez@google.com>
Co-authored-by: NovaHe <heqianfly@gmail.com>
Co-authored-by: Kevin Marquardsen <mr.kmarq@gmail.com>
Co-authored-by: Lena Brüder <oss@lena-brueder.de>
Co-authored-by: Brüder, Lena <lena.brueder@maxxeed.com>
Co-authored-by: Sameer Vohra <vsameer@vmware.com>
Co-authored-by: Mahdi K. Fard <xclud@users.noreply.github.com>
RichardJJG added a commit to RichardJJG/docs that referenced this pull request Jul 1, 2021
…e website, create `/snippets` directory (knative#3610)

* change name for menu item for preview (knative#3533)

Signed-off-by: Carlos Santana <csantana23@gmail.com>

* Added detail per issue knative#3425 (knative#3514)

* Update knative/community files (knative#3553)

Signed-off-by: Knative Automation <automation@knative.team>

* tracing cm fix (knative#3506)

* remove unnecessary requrirements to do a release (knative#3563)

Signed-off-by: Carlos Santana <csantana23@gmail.com>

* knative#3543 fix link (knative#3567)

* Replace xip.io with sslip.io (knative#3574)

* Update actions (knative#3535)

Signed-off-by: Knative Automation <automation@knative.team>

* Update common github actions (knative#3552)

Signed-off-by: Knative Automation <automation@knative.team>

* upgrade to latest dependencies (knative#3505)

bumping knative.dev/hack 88c69cd...93ad912:
  > 93ad912 Print java and mvn version (# 65)
  > 86f9adc Fix default codegen pkg dir (# 67)

Signed-off-by: Knative Automation <automation@knative.team>

* Remove responsive-revision-gc config (knative#3545)

Since knative/serving#10084 deleted old GC and
started using responsive GC by default, `responsive-revision-gc` in
`config-feature` is not used at all.

This patch removes the configuration `responsive-revision-gc` in
`config-feature` configmap.

* Fixes knative#3117 and broken links (knative#3569)

* Fix knative#3117 and broken links

* Fix knative#3117 and broken links

* remove spec folder and redirect page and update links

* remove conflicts

* Update shortcodes.md (knative#3550)

minor grammar.

* 💄 slight change to ordered delivery guarantees (knative#3536)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Add knative-release-leads to OWNERS (knative#3586)

* add approvers ux (knative#3587)

* Update the default value (knative#3530)

* Adding notes on KafkaSource usage (knative#3596)

* Adding some Kafka note for use-cases

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* changing the description

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Update actions (knative#3581)

Signed-off-by: Knative Automation <automation@knative.team>

* Remove python pycache (knative#3594)

* Use correct setting in ClusterIssue setting (knative#3595)

The doc uses ClusterIssuer `letsencrypt-http01-issuer` but the configuration uses
`letsencrypt-issuer` so it is confusable.
Actual report is knative#3560.

So this patch changes the ClusterIssuer name to
`letsencrypt-http01-issuer` which is used in this doc section.

Fix knative#3560

* fix broken link knative#3568 knative#3577 (knative#3579)

* fix Netlify build

* Added Snippets folder and hidden Beta Contributor guide

* Update docs/eventing/event-registry.md

Co-authored-by: Carlos Santana <csantana23@gmail.com>

* whitespace

* more whitespace

* removing this bit because linting is killing me

* ok really the last one

Co-authored-by: Carlos Santana <csantana23@gmail.com>
Co-authored-by: RichardJJG <rijohnson@vmware.com>
Co-authored-by: knative-automation <automation@knative.team>
Co-authored-by: Shashankft9 <48708039+Shashankft9@users.noreply.github.com>
Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>
Co-authored-by: Benjamin Tan Wei Hao <benjamintanweihao@gmail.com>
Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
Co-authored-by: Jonathan Johnson <jonathan.johnson@dijure.com>
Co-authored-by: Matthias Wessendorf <mwessend@redhat.com>
Co-authored-by: Evan Anderson <evana@vmware.com>
Co-authored-by: RichieEscarez <rescarez@google.com>
Co-authored-by: NovaHe <heqianfly@gmail.com>
RichardJJG added a commit to RichardJJG/docs that referenced this pull request Jul 1, 2021
* change name for menu item for preview (knative#3533)

Signed-off-by: Carlos Santana <csantana23@gmail.com>

* Added detail per issue knative#3425 (knative#3514)

* Update knative/community files (knative#3553)

Signed-off-by: Knative Automation <automation@knative.team>

* tracing cm fix (knative#3506)

* remove unnecessary requrirements to do a release (knative#3563)

Signed-off-by: Carlos Santana <csantana23@gmail.com>

* knative#3543 fix link (knative#3567)

* Replace xip.io with sslip.io (knative#3574)

* Update actions (knative#3535)

Signed-off-by: Knative Automation <automation@knative.team>

* Update common github actions (knative#3552)

Signed-off-by: Knative Automation <automation@knative.team>

* upgrade to latest dependencies (knative#3505)

bumping knative.dev/hack 88c69cd...93ad912:
  > 93ad912 Print java and mvn version (# 65)
  > 86f9adc Fix default codegen pkg dir (# 67)

Signed-off-by: Knative Automation <automation@knative.team>

* Remove responsive-revision-gc config (knative#3545)

Since knative/serving#10084 deleted old GC and
started using responsive GC by default, `responsive-revision-gc` in
`config-feature` is not used at all.

This patch removes the configuration `responsive-revision-gc` in
`config-feature` configmap.

* Fixes knative#3117 and broken links (knative#3569)

* Fix knative#3117 and broken links

* Fix knative#3117 and broken links

* remove spec folder and redirect page and update links

* remove conflicts

* Update shortcodes.md (knative#3550)

minor grammar.

* 💄 slight change to ordered delivery guarantees (knative#3536)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Add knative-release-leads to OWNERS (knative#3586)

* add approvers ux (knative#3587)

* Update the default value (knative#3530)

* Adding notes on KafkaSource usage (knative#3596)

* Adding some Kafka note for use-cases

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* changing the description

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Update actions (knative#3581)

Signed-off-by: Knative Automation <automation@knative.team>

* Remove python pycache (knative#3594)

* Use correct setting in ClusterIssue setting (knative#3595)

The doc uses ClusterIssuer `letsencrypt-http01-issuer` but the configuration uses
`letsencrypt-issuer` so it is confusable.
Actual report is knative#3560.

So this patch changes the ClusterIssuer name to
`letsencrypt-http01-issuer` which is used in this doc section.

Fix knative#3560

* fix broken link knative#3568 knative#3577 (knative#3579)

* fix Netlify build

* Added Snippets folder and hidden Beta Contributor guide

* Update docs/eventing/event-registry.md

Co-authored-by: Carlos Santana <csantana23@gmail.com>

* whitespace

* more whitespace

* removing this bit because linting is killing me

* ok really the last one

* Updating to latest API version of Strimzi. v1beta1 is now gone 🔥 (knative#3603)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* 📓 adding a note to not consume records of the kafkachannel's topic... (knative#3615)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* fix broken link in kogito example (knative#3602)

* docs about usage of internal services in an "api-gateway" access model (knative#3597)

Co-authored-by: Brüder, Lena <lena.brueder@maxxeed.com>

* api specs for v0.23 (knative#3619)

Signed-off-by: Carlos Santana <csantana23@gmail.com>

* Update serving/_index.md with network layer option (knative#3585)

* Update _index.md

[knative#3117] Add ref for contour

* Update docs/serving/_index.md

Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>

Co-authored-by: Omer B <obensaadon@vmware.com>
Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>

* Fix typos in the sample yaml file (knative#3616)

* EventType is not yet part of the v1 eventing API (knative#3576)

* Remaining changes from now closed PRs

Co-authored-by: Carlos Santana <csantana23@gmail.com>
Co-authored-by: RichardJJG <rijohnson@vmware.com>
Co-authored-by: knative-automation <automation@knative.team>
Co-authored-by: Shashankft9 <48708039+Shashankft9@users.noreply.github.com>
Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>
Co-authored-by: Benjamin Tan Wei Hao <benjamintanweihao@gmail.com>
Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
Co-authored-by: Jonathan Johnson <jonathan.johnson@dijure.com>
Co-authored-by: Matthias Wessendorf <mwessend@redhat.com>
Co-authored-by: Evan Anderson <evana@vmware.com>
Co-authored-by: RichieEscarez <rescarez@google.com>
Co-authored-by: NovaHe <heqianfly@gmail.com>
Co-authored-by: Kevin Marquardsen <mr.kmarq@gmail.com>
Co-authored-by: Lena Brüder <oss@lena-brueder.de>
Co-authored-by: Brüder, Lena <lena.brueder@maxxeed.com>
Co-authored-by: Sameer Vohra <vsameer@vmware.com>
Co-authored-by: Mahdi K. Fard <xclud@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. kind/serving lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/needs-eng-input Engineering input is requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants