Slight change to ordered delivery guarantees by matzew · Pull Request #3536 · knative/docs

matzew · 2021-05-06T06:23:19Z

Signed-off-by: Matthias Wessendorf mwessend@redhat.com

Proposed Changes

slightly changing the doc for ordered delivery guarantees

matzew · 2021-05-06T06:23:32Z

/assign @pierDipi
/assign @slinkydeveloper

pierDipi · 2021-05-06T06:33:22Z


 * `unordered`: Unordered consumer is a non-blocking consumer that potentially delivers messages unordered, while preserving proper offset management.
-* `ordered`: Ordered consumer is a per-partition blocking consumer that delivers messages in order.
+* `ordered`: Ordered consumer is a per-partition blocking consumer, waiting for the Could Event receiver response before it delivers next messages of the partion.


typo: partition

@pierDipi thanks, I updated

pierDipi

/lgtm

slinkydeveloper · 2021-05-06T10:34:50Z


 * `unordered`: Unordered consumer is a non-blocking consumer that potentially delivers messages unordered, while preserving proper offset management.
-* `ordered`: Ordered consumer is a per-partition blocking consumer that delivers messages in order.
+* `ordered`: Ordered consumer is a per-partition blocking consumer, waiting for the Could Event receiver response before it delivers next messages of the partition.


s/Could Event/CloudEvent

s/receiver/subscriber

slinkydeveloper · 2021-05-06T11:29:41Z


 * `unordered`: Unordered consumer is a non-blocking consumer that potentially delivers messages unordered, while preserving proper offset management.
-* `ordered`: Ordered consumer is a per-partition blocking consumer, waiting for the Could Event receiver response before it delivers next messages of the partition.
+* `ordered`: Ordered consumer is a per-partition blocking consumer, waiting for the CouldEvent subscriber response before it delivers next messages of the partition.


s/CouldEvent/CloudEvent

slinkydeveloper · 2021-05-06T15:02:51Z

/lgtm

matzew · 2021-05-07T10:57:34Z

/retest

vaikas · 2021-05-07T11:25:53Z


 * `unordered`: Unordered consumer is a non-blocking consumer that potentially delivers messages unordered, while preserving proper offset management.
-* `ordered`: Ordered consumer is a per-partition blocking consumer that delivers messages in order.
+* `ordered`: Ordered consumer is a per-partition blocking consumer, waiting for the CloudEvent subscriber response before it delivers next messages of the partition.


Does it have to be successful response?

Great question/suggestion.

pierDipi · 2021-05-11T07:43:24Z

/lgtm

vaikas · 2021-05-12T10:11:20Z


 * `unordered`: Unordered consumer is a non-blocking consumer that potentially delivers messages unordered, while preserving proper offset management.
-* `ordered`: Ordered consumer is a per-partition blocking consumer that delivers messages in order.
+* `ordered`: Ordered consumer is a per-partition blocking consumer, waiting for the CouldEvent subscriber's successful response before it delivers next messages of the partition.


CouldEvent=>CloudEvent?

abrennan89

Suggestions

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

matzew · 2021-05-17T13:12:59Z

updated/rebased

slinkydeveloper · 2021-05-17T13:49:40Z

/lgtm

knative-prow-robot · 2021-05-17T13:52:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, pierDipi, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~docs/eventing/OWNERS~~ [abrennan89]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…e website, create `/snippets` directory (#3610) * change name for menu item for preview (#3533) Signed-off-by: Carlos Santana <csantana23@gmail.com> * Added detail per issue #3425 (#3514) * Update knative/community files (#3553) Signed-off-by: Knative Automation <automation@knative.team> * tracing cm fix (#3506) * remove unnecessary requrirements to do a release (#3563) Signed-off-by: Carlos Santana <csantana23@gmail.com> * #3543 fix link (#3567) * Replace xip.io with sslip.io (#3574) * Update actions (#3535) Signed-off-by: Knative Automation <automation@knative.team> * Update common github actions (#3552) Signed-off-by: Knative Automation <automation@knative.team> * upgrade to latest dependencies (#3505) bumping knative.dev/hack 88c69cd...93ad912: > 93ad912 Print java and mvn version (# 65) > 86f9adc Fix default codegen pkg dir (# 67) Signed-off-by: Knative Automation <automation@knative.team> * Remove responsive-revision-gc config (#3545) Since knative/serving#10084 deleted old GC and started using responsive GC by default, `responsive-revision-gc` in `config-feature` is not used at all. This patch removes the configuration `responsive-revision-gc` in `config-feature` configmap. * Fixes #3117 and broken links (#3569) * Fix #3117 and broken links * Fix #3117 and broken links * remove spec folder and redirect page and update links * remove conflicts * Update shortcodes.md (#3550) minor grammar. * 💄 slight change to ordered delivery guarantees (#3536) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Add knative-release-leads to OWNERS (#3586) * add approvers ux (#3587) * Update the default value (#3530) * Adding notes on KafkaSource usage (#3596) * Adding some Kafka note for use-cases Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * changing the description Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Update actions (#3581) Signed-off-by: Knative Automation <automation@knative.team> * Remove python pycache (#3594) * Use correct setting in ClusterIssue setting (#3595) The doc uses ClusterIssuer `letsencrypt-http01-issuer` but the configuration uses `letsencrypt-issuer` so it is confusable. Actual report is #3560. So this patch changes the ClusterIssuer name to `letsencrypt-http01-issuer` which is used in this doc section. Fix #3560 * fix broken link #3568 #3577 (#3579) * fix Netlify build * Added Snippets folder and hidden Beta Contributor guide * Update docs/eventing/event-registry.md Co-authored-by: Carlos Santana <csantana23@gmail.com> * whitespace * more whitespace * removing this bit because linting is killing me * ok really the last one Co-authored-by: Carlos Santana <csantana23@gmail.com> Co-authored-by: RichardJJG <rijohnson@vmware.com> Co-authored-by: knative-automation <automation@knative.team> Co-authored-by: Shashankft9 <48708039+Shashankft9@users.noreply.github.com> Co-authored-by: Ashleigh Brennan <abrennan@redhat.com> Co-authored-by: Benjamin Tan Wei Hao <benjamintanweihao@gmail.com> Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com> Co-authored-by: Jonathan Johnson <jonathan.johnson@dijure.com> Co-authored-by: Matthias Wessendorf <mwessend@redhat.com> Co-authored-by: Evan Anderson <evana@vmware.com> Co-authored-by: RichieEscarez <rescarez@google.com> Co-authored-by: NovaHe <heqianfly@gmail.com>

* change name for menu item for preview (#3533) Signed-off-by: Carlos Santana <csantana23@gmail.com> * Added detail per issue #3425 (#3514) * Update knative/community files (#3553) Signed-off-by: Knative Automation <automation@knative.team> * tracing cm fix (#3506) * remove unnecessary requrirements to do a release (#3563) Signed-off-by: Carlos Santana <csantana23@gmail.com> * #3543 fix link (#3567) * Replace xip.io with sslip.io (#3574) * Update actions (#3535) Signed-off-by: Knative Automation <automation@knative.team> * Update common github actions (#3552) Signed-off-by: Knative Automation <automation@knative.team> * upgrade to latest dependencies (#3505) bumping knative.dev/hack 88c69cd...93ad912: > 93ad912 Print java and mvn version (# 65) > 86f9adc Fix default codegen pkg dir (# 67) Signed-off-by: Knative Automation <automation@knative.team> * Remove responsive-revision-gc config (#3545) Since knative/serving#10084 deleted old GC and started using responsive GC by default, `responsive-revision-gc` in `config-feature` is not used at all. This patch removes the configuration `responsive-revision-gc` in `config-feature` configmap. * Fixes #3117 and broken links (#3569) * Fix #3117 and broken links * Fix #3117 and broken links * remove spec folder and redirect page and update links * remove conflicts * Update shortcodes.md (#3550) minor grammar. * 💄 slight change to ordered delivery guarantees (#3536) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Add knative-release-leads to OWNERS (#3586) * add approvers ux (#3587) * Update the default value (#3530) * Adding notes on KafkaSource usage (#3596) * Adding some Kafka note for use-cases Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * changing the description Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Update actions (#3581) Signed-off-by: Knative Automation <automation@knative.team> * Remove python pycache (#3594) * Use correct setting in ClusterIssue setting (#3595) The doc uses ClusterIssuer `letsencrypt-http01-issuer` but the configuration uses `letsencrypt-issuer` so it is confusable. Actual report is #3560. So this patch changes the ClusterIssuer name to `letsencrypt-http01-issuer` which is used in this doc section. Fix #3560 * fix broken link #3568 #3577 (#3579) * fix Netlify build * Added Snippets folder and hidden Beta Contributor guide * Update docs/eventing/event-registry.md Co-authored-by: Carlos Santana <csantana23@gmail.com> * whitespace * more whitespace * removing this bit because linting is killing me * ok really the last one * Updating to latest API version of Strimzi. v1beta1 is now gone 🔥 (#3603) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * 📓 adding a note to not consume records of the kafkachannel's topic... (#3615) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * fix broken link in kogito example (#3602) * docs about usage of internal services in an "api-gateway" access model (#3597) Co-authored-by: Brüder, Lena <lena.brueder@maxxeed.com> * api specs for v0.23 (#3619) Signed-off-by: Carlos Santana <csantana23@gmail.com> * Update serving/_index.md with network layer option (#3585) * Update _index.md [#3117] Add ref for contour * Update docs/serving/_index.md Co-authored-by: Ashleigh Brennan <abrennan@redhat.com> Co-authored-by: Omer B <obensaadon@vmware.com> Co-authored-by: Ashleigh Brennan <abrennan@redhat.com> * Fix typos in the sample yaml file (#3616) * EventType is not yet part of the v1 eventing API (#3576) * Remaining changes from now closed PRs Co-authored-by: Carlos Santana <csantana23@gmail.com> Co-authored-by: RichardJJG <rijohnson@vmware.com> Co-authored-by: knative-automation <automation@knative.team> Co-authored-by: Shashankft9 <48708039+Shashankft9@users.noreply.github.com> Co-authored-by: Ashleigh Brennan <abrennan@redhat.com> Co-authored-by: Benjamin Tan Wei Hao <benjamintanweihao@gmail.com> Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com> Co-authored-by: Jonathan Johnson <jonathan.johnson@dijure.com> Co-authored-by: Matthias Wessendorf <mwessend@redhat.com> Co-authored-by: Evan Anderson <evana@vmware.com> Co-authored-by: RichieEscarez <rescarez@google.com> Co-authored-by: NovaHe <heqianfly@gmail.com> Co-authored-by: Kevin Marquardsen <mr.kmarq@gmail.com> Co-authored-by: Lena Brüder <oss@lena-brueder.de> Co-authored-by: Brüder, Lena <lena.brueder@maxxeed.com> Co-authored-by: Sameer Vohra <vsameer@vmware.com> Co-authored-by: Mahdi K. Fard <xclud@users.noreply.github.com>

…e website, create `/snippets` directory (knative#3610) * change name for menu item for preview (knative#3533) Signed-off-by: Carlos Santana <csantana23@gmail.com> * Added detail per issue knative#3425 (knative#3514) * Update knative/community files (knative#3553) Signed-off-by: Knative Automation <automation@knative.team> * tracing cm fix (knative#3506) * remove unnecessary requrirements to do a release (knative#3563) Signed-off-by: Carlos Santana <csantana23@gmail.com> * knative#3543 fix link (knative#3567) * Replace xip.io with sslip.io (knative#3574) * Update actions (knative#3535) Signed-off-by: Knative Automation <automation@knative.team> * Update common github actions (knative#3552) Signed-off-by: Knative Automation <automation@knative.team> * upgrade to latest dependencies (knative#3505) bumping knative.dev/hack 88c69cd...93ad912: > 93ad912 Print java and mvn version (# 65) > 86f9adc Fix default codegen pkg dir (# 67) Signed-off-by: Knative Automation <automation@knative.team> * Remove responsive-revision-gc config (knative#3545) Since knative/serving#10084 deleted old GC and started using responsive GC by default, `responsive-revision-gc` in `config-feature` is not used at all. This patch removes the configuration `responsive-revision-gc` in `config-feature` configmap. * Fixes knative#3117 and broken links (knative#3569) * Fix knative#3117 and broken links * Fix knative#3117 and broken links * remove spec folder and redirect page and update links * remove conflicts * Update shortcodes.md (knative#3550) minor grammar. * 💄 slight change to ordered delivery guarantees (knative#3536) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Add knative-release-leads to OWNERS (knative#3586) * add approvers ux (knative#3587) * Update the default value (knative#3530) * Adding notes on KafkaSource usage (knative#3596) * Adding some Kafka note for use-cases Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * changing the description Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Update actions (knative#3581) Signed-off-by: Knative Automation <automation@knative.team> * Remove python pycache (knative#3594) * Use correct setting in ClusterIssue setting (knative#3595) The doc uses ClusterIssuer `letsencrypt-http01-issuer` but the configuration uses `letsencrypt-issuer` so it is confusable. Actual report is knative#3560. So this patch changes the ClusterIssuer name to `letsencrypt-http01-issuer` which is used in this doc section. Fix knative#3560 * fix broken link knative#3568 knative#3577 (knative#3579) * fix Netlify build * Added Snippets folder and hidden Beta Contributor guide * Update docs/eventing/event-registry.md Co-authored-by: Carlos Santana <csantana23@gmail.com> * whitespace * more whitespace * removing this bit because linting is killing me * ok really the last one Co-authored-by: Carlos Santana <csantana23@gmail.com> Co-authored-by: RichardJJG <rijohnson@vmware.com> Co-authored-by: knative-automation <automation@knative.team> Co-authored-by: Shashankft9 <48708039+Shashankft9@users.noreply.github.com> Co-authored-by: Ashleigh Brennan <abrennan@redhat.com> Co-authored-by: Benjamin Tan Wei Hao <benjamintanweihao@gmail.com> Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com> Co-authored-by: Jonathan Johnson <jonathan.johnson@dijure.com> Co-authored-by: Matthias Wessendorf <mwessend@redhat.com> Co-authored-by: Evan Anderson <evana@vmware.com> Co-authored-by: RichieEscarez <rescarez@google.com> Co-authored-by: NovaHe <heqianfly@gmail.com>

* change name for menu item for preview (knative#3533) Signed-off-by: Carlos Santana <csantana23@gmail.com> * Added detail per issue knative#3425 (knative#3514) * Update knative/community files (knative#3553) Signed-off-by: Knative Automation <automation@knative.team> * tracing cm fix (knative#3506) * remove unnecessary requrirements to do a release (knative#3563) Signed-off-by: Carlos Santana <csantana23@gmail.com> * knative#3543 fix link (knative#3567) * Replace xip.io with sslip.io (knative#3574) * Update actions (knative#3535) Signed-off-by: Knative Automation <automation@knative.team> * Update common github actions (knative#3552) Signed-off-by: Knative Automation <automation@knative.team> * upgrade to latest dependencies (knative#3505) bumping knative.dev/hack 88c69cd...93ad912: > 93ad912 Print java and mvn version (# 65) > 86f9adc Fix default codegen pkg dir (# 67) Signed-off-by: Knative Automation <automation@knative.team> * Remove responsive-revision-gc config (knative#3545) Since knative/serving#10084 deleted old GC and started using responsive GC by default, `responsive-revision-gc` in `config-feature` is not used at all. This patch removes the configuration `responsive-revision-gc` in `config-feature` configmap. * Fixes knative#3117 and broken links (knative#3569) * Fix knative#3117 and broken links * Fix knative#3117 and broken links * remove spec folder and redirect page and update links * remove conflicts * Update shortcodes.md (knative#3550) minor grammar. * 💄 slight change to ordered delivery guarantees (knative#3536) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Add knative-release-leads to OWNERS (knative#3586) * add approvers ux (knative#3587) * Update the default value (knative#3530) * Adding notes on KafkaSource usage (knative#3596) * Adding some Kafka note for use-cases Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * changing the description Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Update actions (knative#3581) Signed-off-by: Knative Automation <automation@knative.team> * Remove python pycache (knative#3594) * Use correct setting in ClusterIssue setting (knative#3595) The doc uses ClusterIssuer `letsencrypt-http01-issuer` but the configuration uses `letsencrypt-issuer` so it is confusable. Actual report is knative#3560. So this patch changes the ClusterIssuer name to `letsencrypt-http01-issuer` which is used in this doc section. Fix knative#3560 * fix broken link knative#3568 knative#3577 (knative#3579) * fix Netlify build * Added Snippets folder and hidden Beta Contributor guide * Update docs/eventing/event-registry.md Co-authored-by: Carlos Santana <csantana23@gmail.com> * whitespace * more whitespace * removing this bit because linting is killing me * ok really the last one * Updating to latest API version of Strimzi. v1beta1 is now gone 🔥 (knative#3603) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * 📓 adding a note to not consume records of the kafkachannel's topic... (knative#3615) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * fix broken link in kogito example (knative#3602) * docs about usage of internal services in an "api-gateway" access model (knative#3597) Co-authored-by: Brüder, Lena <lena.brueder@maxxeed.com> * api specs for v0.23 (knative#3619) Signed-off-by: Carlos Santana <csantana23@gmail.com> * Update serving/_index.md with network layer option (knative#3585) * Update _index.md [knative#3117] Add ref for contour * Update docs/serving/_index.md Co-authored-by: Ashleigh Brennan <abrennan@redhat.com> Co-authored-by: Omer B <obensaadon@vmware.com> Co-authored-by: Ashleigh Brennan <abrennan@redhat.com> * Fix typos in the sample yaml file (knative#3616) * EventType is not yet part of the v1 eventing API (knative#3576) * Remaining changes from now closed PRs Co-authored-by: Carlos Santana <csantana23@gmail.com> Co-authored-by: RichardJJG <rijohnson@vmware.com> Co-authored-by: knative-automation <automation@knative.team> Co-authored-by: Shashankft9 <48708039+Shashankft9@users.noreply.github.com> Co-authored-by: Ashleigh Brennan <abrennan@redhat.com> Co-authored-by: Benjamin Tan Wei Hao <benjamintanweihao@gmail.com> Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com> Co-authored-by: Jonathan Johnson <jonathan.johnson@dijure.com> Co-authored-by: Matthias Wessendorf <mwessend@redhat.com> Co-authored-by: Evan Anderson <evana@vmware.com> Co-authored-by: RichieEscarez <rescarez@google.com> Co-authored-by: NovaHe <heqianfly@gmail.com> Co-authored-by: Kevin Marquardsen <mr.kmarq@gmail.com> Co-authored-by: Lena Brüder <oss@lena-brueder.de> Co-authored-by: Brüder, Lena <lena.brueder@maxxeed.com> Co-authored-by: Sameer Vohra <vsameer@vmware.com> Co-authored-by: Mahdi K. Fard <xclud@users.noreply.github.com>

…e website, create `/snippets` directory (knative#3610) * change name for menu item for preview (knative#3533) Signed-off-by: Carlos Santana <csantana23@gmail.com> * Added detail per issue knative#3425 (knative#3514) * Update knative/community files (knative#3553) Signed-off-by: Knative Automation <automation@knative.team> * tracing cm fix (knative#3506) * remove unnecessary requrirements to do a release (knative#3563) Signed-off-by: Carlos Santana <csantana23@gmail.com> * knative#3543 fix link (knative#3567) * Replace xip.io with sslip.io (knative#3574) * Update actions (knative#3535) Signed-off-by: Knative Automation <automation@knative.team> * Update common github actions (knative#3552) Signed-off-by: Knative Automation <automation@knative.team> * upgrade to latest dependencies (knative#3505) bumping knative.dev/hack 88c69cd...93ad912: > 93ad912 Print java and mvn version (# 65) > 86f9adc Fix default codegen pkg dir (# 67) Signed-off-by: Knative Automation <automation@knative.team> * Remove responsive-revision-gc config (knative#3545) Since knative/serving#10084 deleted old GC and started using responsive GC by default, `responsive-revision-gc` in `config-feature` is not used at all. This patch removes the configuration `responsive-revision-gc` in `config-feature` configmap. * Fixes knative#3117 and broken links (knative#3569) * Fix knative#3117 and broken links * Fix knative#3117 and broken links * remove spec folder and redirect page and update links * remove conflicts * Update shortcodes.md (knative#3550) minor grammar. * 💄 slight change to ordered delivery guarantees (knative#3536) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Add knative-release-leads to OWNERS (knative#3586) * add approvers ux (knative#3587) * Update the default value (knative#3530) * Adding notes on KafkaSource usage (knative#3596) * Adding some Kafka note for use-cases Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * changing the description Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Update actions (knative#3581) Signed-off-by: Knative Automation <automation@knative.team> * Remove python pycache (knative#3594) * Use correct setting in ClusterIssue setting (knative#3595) The doc uses ClusterIssuer `letsencrypt-http01-issuer` but the configuration uses `letsencrypt-issuer` so it is confusable. Actual report is knative#3560. So this patch changes the ClusterIssuer name to `letsencrypt-http01-issuer` which is used in this doc section. Fix knative#3560 * fix broken link knative#3568 knative#3577 (knative#3579) * fix Netlify build * Added Snippets folder and hidden Beta Contributor guide * Update docs/eventing/event-registry.md Co-authored-by: Carlos Santana <csantana23@gmail.com> * whitespace * more whitespace * removing this bit because linting is killing me * ok really the last one Co-authored-by: Carlos Santana <csantana23@gmail.com> Co-authored-by: RichardJJG <rijohnson@vmware.com> Co-authored-by: knative-automation <automation@knative.team> Co-authored-by: Shashankft9 <48708039+Shashankft9@users.noreply.github.com> Co-authored-by: Ashleigh Brennan <abrennan@redhat.com> Co-authored-by: Benjamin Tan Wei Hao <benjamintanweihao@gmail.com> Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com> Co-authored-by: Jonathan Johnson <jonathan.johnson@dijure.com> Co-authored-by: Matthias Wessendorf <mwessend@redhat.com> Co-authored-by: Evan Anderson <evana@vmware.com> Co-authored-by: RichieEscarez <rescarez@google.com> Co-authored-by: NovaHe <heqianfly@gmail.com>

* change name for menu item for preview (knative#3533) Signed-off-by: Carlos Santana <csantana23@gmail.com> * Added detail per issue knative#3425 (knative#3514) * Update knative/community files (knative#3553) Signed-off-by: Knative Automation <automation@knative.team> * tracing cm fix (knative#3506) * remove unnecessary requrirements to do a release (knative#3563) Signed-off-by: Carlos Santana <csantana23@gmail.com> * knative#3543 fix link (knative#3567) * Replace xip.io with sslip.io (knative#3574) * Update actions (knative#3535) Signed-off-by: Knative Automation <automation@knative.team> * Update common github actions (knative#3552) Signed-off-by: Knative Automation <automation@knative.team> * upgrade to latest dependencies (knative#3505) bumping knative.dev/hack 88c69cd...93ad912: > 93ad912 Print java and mvn version (# 65) > 86f9adc Fix default codegen pkg dir (# 67) Signed-off-by: Knative Automation <automation@knative.team> * Remove responsive-revision-gc config (knative#3545) Since knative/serving#10084 deleted old GC and started using responsive GC by default, `responsive-revision-gc` in `config-feature` is not used at all. This patch removes the configuration `responsive-revision-gc` in `config-feature` configmap. * Fixes knative#3117 and broken links (knative#3569) * Fix knative#3117 and broken links * Fix knative#3117 and broken links * remove spec folder and redirect page and update links * remove conflicts * Update shortcodes.md (knative#3550) minor grammar. * 💄 slight change to ordered delivery guarantees (knative#3536) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Add knative-release-leads to OWNERS (knative#3586) * add approvers ux (knative#3587) * Update the default value (knative#3530) * Adding notes on KafkaSource usage (knative#3596) * Adding some Kafka note for use-cases Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * changing the description Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Update actions (knative#3581) Signed-off-by: Knative Automation <automation@knative.team> * Remove python pycache (knative#3594) * Use correct setting in ClusterIssue setting (knative#3595) The doc uses ClusterIssuer `letsencrypt-http01-issuer` but the configuration uses `letsencrypt-issuer` so it is confusable. Actual report is knative#3560. So this patch changes the ClusterIssuer name to `letsencrypt-http01-issuer` which is used in this doc section. Fix knative#3560 * fix broken link knative#3568 knative#3577 (knative#3579) * fix Netlify build * Added Snippets folder and hidden Beta Contributor guide * Update docs/eventing/event-registry.md Co-authored-by: Carlos Santana <csantana23@gmail.com> * whitespace * more whitespace * removing this bit because linting is killing me * ok really the last one * Updating to latest API version of Strimzi. v1beta1 is now gone 🔥 (knative#3603) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * 📓 adding a note to not consume records of the kafkachannel's topic... (knative#3615) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * fix broken link in kogito example (knative#3602) * docs about usage of internal services in an "api-gateway" access model (knative#3597) Co-authored-by: Brüder, Lena <lena.brueder@maxxeed.com> * api specs for v0.23 (knative#3619) Signed-off-by: Carlos Santana <csantana23@gmail.com> * Update serving/_index.md with network layer option (knative#3585) * Update _index.md [knative#3117] Add ref for contour * Update docs/serving/_index.md Co-authored-by: Ashleigh Brennan <abrennan@redhat.com> Co-authored-by: Omer B <obensaadon@vmware.com> Co-authored-by: Ashleigh Brennan <abrennan@redhat.com> * Fix typos in the sample yaml file (knative#3616) * EventType is not yet part of the v1 eventing API (knative#3576) * Remaining changes from now closed PRs Co-authored-by: Carlos Santana <csantana23@gmail.com> Co-authored-by: RichardJJG <rijohnson@vmware.com> Co-authored-by: knative-automation <automation@knative.team> Co-authored-by: Shashankft9 <48708039+Shashankft9@users.noreply.github.com> Co-authored-by: Ashleigh Brennan <abrennan@redhat.com> Co-authored-by: Benjamin Tan Wei Hao <benjamintanweihao@gmail.com> Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com> Co-authored-by: Jonathan Johnson <jonathan.johnson@dijure.com> Co-authored-by: Matthias Wessendorf <mwessend@redhat.com> Co-authored-by: Evan Anderson <evana@vmware.com> Co-authored-by: RichieEscarez <rescarez@google.com> Co-authored-by: NovaHe <heqianfly@gmail.com> Co-authored-by: Kevin Marquardsen <mr.kmarq@gmail.com> Co-authored-by: Lena Brüder <oss@lena-brueder.de> Co-authored-by: Brüder, Lena <lena.brueder@maxxeed.com> Co-authored-by: Sameer Vohra <vsameer@vmware.com> Co-authored-by: Mahdi K. Fard <xclud@users.noreply.github.com>

google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label May 6, 2021

knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 6, 2021

knative-prow-robot assigned pierDipi and slinkydeveloper May 6, 2021

pierDipi reviewed May 6, 2021

View reviewed changes

matzew force-pushed the add_ordered_doc_enhancement branch from 6f59f3f to e148fc1 Compare May 6, 2021 06:34

pierDipi approved these changes May 6, 2021

View reviewed changes

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2021

slinkydeveloper suggested changes May 6, 2021

View reviewed changes

knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label May 6, 2021

slinkydeveloper suggested changes May 6, 2021

View reviewed changes

slinkydeveloper approved these changes May 6, 2021

View reviewed changes

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2021

vaikas reviewed May 7, 2021

View reviewed changes

matzew force-pushed the add_ordered_doc_enhancement branch from eb5f242 to 0c9f357 Compare May 11, 2021 07:31

knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label May 11, 2021

pierDipi approved these changes May 11, 2021

View reviewed changes

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2021

vaikas reviewed May 12, 2021

View reviewed changes

abrennan89 reviewed May 14, 2021

View reviewed changes

Comment thread docs/eventing/broker/kafka-broker/_index.md Outdated

abrennan89 reviewed May 14, 2021

View reviewed changes

Comment thread docs/eventing/broker/kafka-broker/_index.md Outdated

abrennan89 suggested changes May 14, 2021

View reviewed changes

knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label May 17, 2021

💄 slight change to ordered delivery guarantees

208ca6e

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

matzew force-pushed the add_ordered_doc_enhancement branch from bb2b9fe to 208ca6e Compare May 17, 2021 13:12

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2021

abrennan89 approved these changes May 17, 2021

View reviewed changes

knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2021

knative-prow-robot merged commit 3211289 into knative:main May 17, 2021

Conversation

matzew commented May 6, 2021

Proposed Changes

Uh oh!

matzew commented May 6, 2021

Uh oh!

pierDipi May 6, 2021

Choose a reason for hiding this comment

Uh oh!

matzew May 6, 2021

Choose a reason for hiding this comment

Uh oh!

pierDipi left a comment

Choose a reason for hiding this comment

Uh oh!

slinkydeveloper May 6, 2021

Choose a reason for hiding this comment

Uh oh!

slinkydeveloper May 6, 2021

Choose a reason for hiding this comment

Uh oh!

slinkydeveloper commented May 6, 2021

Uh oh!

matzew commented May 7, 2021

Uh oh!

vaikas May 7, 2021

Choose a reason for hiding this comment

Uh oh!

pierDipi May 10, 2021

Choose a reason for hiding this comment

Uh oh!

pierDipi commented May 11, 2021

Uh oh!

vaikas May 12, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

abrennan89 left a comment

Choose a reason for hiding this comment

Uh oh!

matzew commented May 17, 2021

Uh oh!

slinkydeveloper commented May 17, 2021

Uh oh!

knative-prow-robot commented May 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants