Merging main into mkdocs, add Beta contributor's guide (hidden) to the website, create `/snippets` directory by omerbensaadon · Pull Request #3610 · knative/docs

omerbensaadon · 2021-05-19T12:17:30Z

Someone who is a git ninja should review this, but from a content perspective everything makes sense here.

Fixes #3607
Fixes #3613
Fixes: #3614
Part of epic: #3546

NEW:

Contrib guide is in getting-started/contributing/contributing
Snippets folder is in /docs, includes a folder called "links" which contains a link to the current "main" docs branch

Signed-off-by: Carlos Santana <csantana23@gmail.com>

Signed-off-by: Knative Automation <automation@knative.team>

Signed-off-by: Carlos Santana <csantana23@gmail.com>

Signed-off-by: Knative Automation <automation@knative.team>

bumping knative.dev/hack 88c69cd...93ad912: > 93ad912 Print java and mvn version (# 65) > 86f9adc Fix default codegen pkg dir (# 67) Signed-off-by: Knative Automation <automation@knative.team>

Since knative/serving#10084 deleted old GC and started using responsive GC by default, `responsive-revision-gc` in `config-feature` is not used at all. This patch removes the configuration `responsive-revision-gc` in `config-feature` configmap.

* Fix #3117 and broken links * Fix #3117 and broken links * remove spec folder and redirect page and update links * remove conflicts

minor grammar.

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Adding some Kafka note for use-cases Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * changing the description Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

Signed-off-by: Knative Automation <automation@knative.team>

The doc uses ClusterIssuer `letsencrypt-http01-issuer` but the configuration uses `letsencrypt-issuer` so it is confusable. Actual report is #3560. So this patch changes the ClusterIssuer name to `letsencrypt-http01-issuer` which is used in this doc section. Fix #3560

netlify · 2021-05-19T12:46:19Z

Deploy Preview for beta-knative ready!

Built with commit 4ef9781

https://deploy-preview-3610--beta-knative.netlify.app

csantanapr · 2021-05-19T14:55:12Z

 ## Before you begin

-1. Read about the [broker](./broker/) and [trigger](./triggers/) objects.
+1. Read about the [broker](./broker/) and [trigger](./broker/triggers/) objects.


this links are broken, do we care to fix them in this PR or maybe later we do a pass over all broken links?

omerbensaadon · 2021-05-19T14:57:30Z

/hold

Finishing up Beta contrib guide

…kdocs

omerbensaadon · 2021-05-19T15:32:42Z

/unhold

Co-authored-by: Carlos Santana <csantana23@gmail.com>

…kdocs

csantanapr · 2021-05-19T16:08:32Z

/lgtm

csantanapr · 2021-05-19T16:09:13Z

/approve

knative-prow-robot · 2021-05-19T16:18:19Z

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: csantanapr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

julz · 2021-05-19T16:19:36Z

🎉

…e website, create `/snippets` directory (knative#3610) * change name for menu item for preview (knative#3533) Signed-off-by: Carlos Santana <csantana23@gmail.com> * Added detail per issue knative#3425 (knative#3514) * Update knative/community files (knative#3553) Signed-off-by: Knative Automation <automation@knative.team> * tracing cm fix (knative#3506) * remove unnecessary requrirements to do a release (knative#3563) Signed-off-by: Carlos Santana <csantana23@gmail.com> * knative#3543 fix link (knative#3567) * Replace xip.io with sslip.io (knative#3574) * Update actions (knative#3535) Signed-off-by: Knative Automation <automation@knative.team> * Update common github actions (knative#3552) Signed-off-by: Knative Automation <automation@knative.team> * upgrade to latest dependencies (knative#3505) bumping knative.dev/hack 88c69cd...93ad912: > 93ad912 Print java and mvn version (# 65) > 86f9adc Fix default codegen pkg dir (# 67) Signed-off-by: Knative Automation <automation@knative.team> * Remove responsive-revision-gc config (knative#3545) Since knative/serving#10084 deleted old GC and started using responsive GC by default, `responsive-revision-gc` in `config-feature` is not used at all. This patch removes the configuration `responsive-revision-gc` in `config-feature` configmap. * Fixes knative#3117 and broken links (knative#3569) * Fix knative#3117 and broken links * Fix knative#3117 and broken links * remove spec folder and redirect page and update links * remove conflicts * Update shortcodes.md (knative#3550) minor grammar. * 💄 slight change to ordered delivery guarantees (knative#3536) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Add knative-release-leads to OWNERS (knative#3586) * add approvers ux (knative#3587) * Update the default value (knative#3530) * Adding notes on KafkaSource usage (knative#3596) * Adding some Kafka note for use-cases Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * changing the description Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Update actions (knative#3581) Signed-off-by: Knative Automation <automation@knative.team> * Remove python pycache (knative#3594) * Use correct setting in ClusterIssue setting (knative#3595) The doc uses ClusterIssuer `letsencrypt-http01-issuer` but the configuration uses `letsencrypt-issuer` so it is confusable. Actual report is knative#3560. So this patch changes the ClusterIssuer name to `letsencrypt-http01-issuer` which is used in this doc section. Fix knative#3560 * fix broken link knative#3568 knative#3577 (knative#3579) * fix Netlify build * Added Snippets folder and hidden Beta Contributor guide * Update docs/eventing/event-registry.md Co-authored-by: Carlos Santana <csantana23@gmail.com> * whitespace * more whitespace * removing this bit because linting is killing me * ok really the last one Co-authored-by: Carlos Santana <csantana23@gmail.com> Co-authored-by: RichardJJG <rijohnson@vmware.com> Co-authored-by: knative-automation <automation@knative.team> Co-authored-by: Shashankft9 <48708039+Shashankft9@users.noreply.github.com> Co-authored-by: Ashleigh Brennan <abrennan@redhat.com> Co-authored-by: Benjamin Tan Wei Hao <benjamintanweihao@gmail.com> Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com> Co-authored-by: Jonathan Johnson <jonathan.johnson@dijure.com> Co-authored-by: Matthias Wessendorf <mwessend@redhat.com> Co-authored-by: Evan Anderson <evana@vmware.com> Co-authored-by: RichieEscarez <rescarez@google.com> Co-authored-by: NovaHe <heqianfly@gmail.com>

csantanapr and others added 23 commits May 5, 2021 13:46

change name for menu item for preview (#3533)

580dfc4

Signed-off-by: Carlos Santana <csantana23@gmail.com>

Added detail per issue #3425 (#3514)

56d5097

Update knative/community files (#3553)

08df9a4

Signed-off-by: Knative Automation <automation@knative.team>

tracing cm fix (#3506)

59494a1

remove unnecessary requrirements to do a release (#3563)

702b26b

Signed-off-by: Carlos Santana <csantana23@gmail.com>

#3543 fix link (#3567)

135e998

Replace xip.io with sslip.io (#3574)

401db7d

Update actions (#3535)

3728a93

Signed-off-by: Knative Automation <automation@knative.team>

Update common github actions (#3552)

b20e599

Signed-off-by: Knative Automation <automation@knative.team>

upgrade to latest dependencies (#3505)

9de8ab7

bumping knative.dev/hack 88c69cd...93ad912: > 93ad912 Print java and mvn version (# 65) > 86f9adc Fix default codegen pkg dir (# 67) Signed-off-by: Knative Automation <automation@knative.team>

Fixes #3117 and broken links (#3569)

f0264b1

* Fix #3117 and broken links * Fix #3117 and broken links * remove spec folder and redirect page and update links * remove conflicts

Update shortcodes.md (#3550)

3b42f9d

minor grammar.

💄 slight change to ordered delivery guarantees (#3536)

3211289

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

Add knative-release-leads to OWNERS (#3586)

f756f1a

add approvers ux (#3587)

c9ce88e

Update the default value (#3530)

22c1511

Adding notes on KafkaSource usage (#3596)

8751c19

* Adding some Kafka note for use-cases Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * changing the description Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

Update actions (#3581)

42fb8a1

Signed-off-by: Knative Automation <automation@knative.team>

Remove python pycache (#3594)

4ab8007

fix broken link #3568 #3577 (#3579)

f8e75be

merging main into mkdocs

1974a07

knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 19, 2021

google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label May 19, 2021

fix Netlify build

a9036c0

omerbensaadon requested review from csantanapr and julz May 19, 2021 14:01

Merge branch 'mkdocs' into mkdocs

f86d92a

csantanapr reviewed May 19, 2021

View reviewed changes

knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 19, 2021

csantanapr reviewed May 19, 2021

View reviewed changes

Comment thread docs/eventing/event-registry.md Outdated

Omer B added 2 commits May 19, 2021 11:32

Added Snippets folder and hidden Beta Contributor guide

612e0d3

Merge branch 'mkdocs' of https://github.com/omerbensaadon/docs into m…

fb2307a

…kdocs

knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 19, 2021

omerbensaadon changed the title ~~Merging main into mkdocs~~ Merging main into mkdocs add Beta contributor's guide (hidden) to the website May 19, 2021

Omer B and others added 3 commits May 19, 2021 11:35

Update docs/eventing/event-registry.md

73c45d9

Co-authored-by: Carlos Santana <csantana23@gmail.com>

whitespace

1b9e7f2

Merge branch 'mkdocs' of https://github.com/omerbensaadon/docs into m…

fa8921d

…kdocs

omerbensaadon added the kind/mkdocs label May 19, 2021

more whitespace

2e51f40

omerbensaadon changed the title ~~Merging main into mkdocs add Beta contributor's guide (hidden) to the website~~ Merging main into mkdocs, add Beta contributor's guide (hidden) to the website, create /snippets directory May 19, 2021

Omer B added 2 commits May 19, 2021 11:49

removing this bit because linting is killing me

b3e0280

ok really the last one

4ef9781

knative-prow-robot assigned csantanapr May 19, 2021

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2021

csantanapr added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2021

knative-prow-robot merged commit c458007 into knative:mkdocs May 19, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merging main into mkdocs, add Beta contributor's guide (hidden) to the website, create `/snippets` directory#3610

Merging main into mkdocs, add Beta contributor's guide (hidden) to the website, create `/snippets` directory#3610
knative-prow-robot merged 33 commits into
knative:mkdocsfrom
omerbensaadon:mkdocs

omerbensaadon commented May 19, 2021 •

edited

Loading

Uh oh!

netlify Bot commented May 19, 2021 •

edited

Loading

Uh oh!

csantanapr May 19, 2021

Uh oh!

omerbensaadon May 19, 2021

Uh oh!

omerbensaadon commented May 19, 2021 •

edited

Loading

Uh oh!

Uh oh!

omerbensaadon commented May 19, 2021

Uh oh!

csantanapr commented May 19, 2021

Uh oh!

csantanapr commented May 19, 2021

Uh oh!

knative-prow-robot commented May 19, 2021

Uh oh!

julz commented May 19, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

Conversation

omerbensaadon commented May 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented May 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

csantanapr May 19, 2021

Choose a reason for hiding this comment

Uh oh!

omerbensaadon May 19, 2021

Choose a reason for hiding this comment

Uh oh!

omerbensaadon commented May 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

omerbensaadon commented May 19, 2021

Uh oh!

csantanapr commented May 19, 2021

Uh oh!

csantanapr commented May 19, 2021

Uh oh!

knative-prow-robot commented May 19, 2021

Uh oh!

julz commented May 19, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

omerbensaadon commented May 19, 2021 •

edited

Loading

netlify Bot commented May 19, 2021 •

edited

Loading

omerbensaadon commented May 19, 2021 •

edited

Loading