Skip to content

#3543 fix link#3567

Merged
knative-prow-robot merged 1 commit into
knative:mainfrom
abrennan89:3543
May 13, 2021
Merged

#3543 fix link#3567
knative-prow-robot merged 1 commit into
knative:mainfrom
abrennan89:3543

Conversation

@abrennan89
Copy link
Copy Markdown
Contributor

Fixes #3543
Fixes some additional broken links also.

@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label May 12, 2021
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 12, 2021
Copy link
Copy Markdown
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

I'm okay with putting this in as-is (/hold cancel, since this is better than the status quo), or fixing up the links I pointed out.

/hold
/approve
/lgtm

Comment thread docs/serving/_index.md
serverless workload behaves on the cluster:

- [Service](https://github.com/knative/docs/blob/main/docs/serving/spec/knative-api-specification-1.0.md#service):
- [Service](https://github.com/knative/docs/blob/main/docs/serving/spec/knative-api-specification-1.0#service):
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this PR, but I wonder whether linking to the spec is the best link here.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, but for this PR, it turns out that these links are probably dead and also not relative (relative links allow the version to be preserved).

Comment thread docs/serving/_index.md
- [Using subroutes](./using-subroutes.md)
- [Configuring cluster local routes](./cluster-local-route)
- [Using a custom domain](./using-a-custom-domain)
- [Assigning a static IP address for Knative on Google Kubernetes Engine](./gke-assigning-static-ip-address)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, this is a weird one (since it looks to be provider-specific).

In any case, I'd move this over to the admin guide one of these years. 😁

NOT FOR THIS PR!


Alternatively, to deploy an app using Knative, you can also create the configuration in a YAML file that defines a service. For more information about the Service object, see the
[Resource Types documentation](https://github.com/knative/serving/blob/main/docs/spec/overview.md#service).
[Resource Types documentation](https://github.com/knative/serving/blob/main/docs/spec/overview#service).
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be moved to knative/specs.

hosted image of the app for deployment, and allows the deployment to be
configured. For more information about what configuration options are available,
see the [Serving spec documentation](https://github.com/knative/serving/blob/main/docs/spec/spec.md).
see the [Serving spec documentation](https://github.com/knative/serving/blob/main/docs/spec/spec).
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

- Have a Kubernetes cluster running with the Knative Serving component
installed. For more information, see the
[Knative instruction guides](https://github.com/knative/docs/blob/main/docs/install/README.md).
[Knative instruction guides](https://github.com/knative/docs/blob/main/docs/install/).
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be an absolute link? Other links are not.

@@ -14,7 +14,7 @@ something isn't working, lend a helping hand and fix it in a PR.

[Learn more about the lifespan of samples](https://github.com/knative/docs/tree/main/CONTRIBUTING.md#user-focused-content)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a relative link?

@evankanderson
Copy link
Copy Markdown
Member

Oops, I forgot to do this on the comment originally, and it appears "edit" didn't work.

/hold
/approve
/lgtm

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2021
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2021
@evankanderson
Copy link
Copy Markdown
Member

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2021
@knative-prow-robot knative-prow-robot merged commit 135e998 into knative:main May 13, 2021
@abrennan89
Copy link
Copy Markdown
Contributor Author

/cherrypick release-0.22

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@abrennan89: #3567 failed to apply on top of branch "release-0.22":

Applying: #3543 fix link
Using index info to reconstruct a base tree...
M	community/samples/_index.md
M	community/samples/serving/helloworld-clojure/index.md
M	community/samples/serving/helloworld-dart/index.md
M	community/samples/serving/helloworld-deno/index.md
M	community/samples/serving/helloworld-haskell/index.md
M	community/samples/serving/helloworld-java-micronaut/index.md
M	community/samples/serving/helloworld-java-quarkus/index.md
M	community/samples/serving/helloworld-r/index.md
M	community/samples/serving/helloworld-rserver/index.md
M	community/samples/serving/helloworld-rust/index.md
M	community/samples/serving/helloworld-swift/index.md
M	community/samples/serving/helloworld-vertx/index.md
M	community/samples/serving/machinelearning-python-bentoml/index.md
M	docs/eventing/getting-started.md
M	docs/install/install-eventing-with-yaml.md
M	docs/install/install-extensions.md
M	docs/install/installing-istio.md
M	docs/serving/_index.md
M	docs/serving/autoscaling/_index.md
M	docs/serving/autoscaling/autoscale-go/index.md
M	docs/serving/samples/_index.md
M	docs/serving/samples/cloudevents/cloudevents-dotnet/index.md
M	docs/serving/samples/cloudevents/cloudevents-nodejs/index.md
M	docs/serving/samples/hello-world/helloworld-csharp/index.md
M	docs/serving/samples/hello-world/helloworld-kotlin/index.md
M	docs/serving/samples/hello-world/helloworld-nodejs/index.md
M	template-docs-page.md
Falling back to patching base and 3-way merge...
Auto-merging template-docs-page.md
Auto-merging docs/serving/samples/hello-world/helloworld-nodejs/index.md
CONFLICT (content): Merge conflict in docs/serving/samples/hello-world/helloworld-nodejs/index.md
Auto-merging docs/serving/samples/hello-world/helloworld-kotlin/index.md
CONFLICT (content): Merge conflict in docs/serving/samples/hello-world/helloworld-kotlin/index.md
Auto-merging docs/serving/samples/hello-world/helloworld-csharp/index.md
CONFLICT (content): Merge conflict in docs/serving/samples/hello-world/helloworld-csharp/index.md
Auto-merging docs/serving/samples/cloudevents/cloudevents-nodejs/index.md
CONFLICT (content): Merge conflict in docs/serving/samples/cloudevents/cloudevents-nodejs/index.md
Auto-merging docs/serving/samples/cloudevents/cloudevents-dotnet/index.md
CONFLICT (content): Merge conflict in docs/serving/samples/cloudevents/cloudevents-dotnet/index.md
Auto-merging docs/serving/samples/_index.md
CONFLICT (content): Merge conflict in docs/serving/samples/_index.md
Auto-merging docs/serving/autoscaling/autoscale-go/index.md
CONFLICT (content): Merge conflict in docs/serving/autoscaling/autoscale-go/index.md
Auto-merging docs/serving/autoscaling/_index.md
CONFLICT (content): Merge conflict in docs/serving/autoscaling/_index.md
Auto-merging docs/serving/_index.md
CONFLICT (content): Merge conflict in docs/serving/_index.md
Auto-merging docs/install/installing-istio.md
Auto-merging docs/install/install-extensions.md
Auto-merging docs/install/install-eventing-with-yaml.md
Auto-merging docs/eventing/getting-started.md
Auto-merging community/samples/serving/machinelearning-python-bentoml/index.md
CONFLICT (content): Merge conflict in community/samples/serving/machinelearning-python-bentoml/index.md
Auto-merging community/samples/serving/helloworld-vertx/index.md
CONFLICT (content): Merge conflict in community/samples/serving/helloworld-vertx/index.md
Auto-merging community/samples/serving/helloworld-swift/index.md
CONFLICT (content): Merge conflict in community/samples/serving/helloworld-swift/index.md
Auto-merging community/samples/serving/helloworld-rust/index.md
CONFLICT (content): Merge conflict in community/samples/serving/helloworld-rust/index.md
Auto-merging community/samples/serving/helloworld-rserver/index.md
CONFLICT (content): Merge conflict in community/samples/serving/helloworld-rserver/index.md
Auto-merging community/samples/serving/helloworld-r/index.md
CONFLICT (content): Merge conflict in community/samples/serving/helloworld-r/index.md
Auto-merging community/samples/serving/helloworld-java-quarkus/index.md
CONFLICT (content): Merge conflict in community/samples/serving/helloworld-java-quarkus/index.md
Auto-merging community/samples/serving/helloworld-java-micronaut/index.md
CONFLICT (content): Merge conflict in community/samples/serving/helloworld-java-micronaut/index.md
Auto-merging community/samples/serving/helloworld-haskell/index.md
CONFLICT (content): Merge conflict in community/samples/serving/helloworld-haskell/index.md
Auto-merging community/samples/serving/helloworld-deno/index.md
CONFLICT (content): Merge conflict in community/samples/serving/helloworld-deno/index.md
Auto-merging community/samples/serving/helloworld-dart/index.md
CONFLICT (content): Merge conflict in community/samples/serving/helloworld-dart/index.md
Auto-merging community/samples/serving/helloworld-clojure/index.md
CONFLICT (content): Merge conflict in community/samples/serving/helloworld-clojure/index.md
Auto-merging community/samples/_index.md
CONFLICT (content): Merge conflict in community/samples/_index.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 #3543 fix link
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick release-0.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abrennan89
Copy link
Copy Markdown
Contributor Author

LMAO never mind...

knative-prow-robot pushed a commit that referenced this pull request May 19, 2021
…e website, create `/snippets` directory (#3610)

* change name for menu item for preview (#3533)

Signed-off-by: Carlos Santana <csantana23@gmail.com>

* Added detail per issue #3425 (#3514)

* Update knative/community files (#3553)

Signed-off-by: Knative Automation <automation@knative.team>

* tracing cm fix (#3506)

* remove unnecessary requrirements to do a release (#3563)

Signed-off-by: Carlos Santana <csantana23@gmail.com>

* #3543 fix link (#3567)

* Replace xip.io with sslip.io (#3574)

* Update actions (#3535)

Signed-off-by: Knative Automation <automation@knative.team>

* Update common github actions (#3552)

Signed-off-by: Knative Automation <automation@knative.team>

* upgrade to latest dependencies (#3505)

bumping knative.dev/hack 88c69cd...93ad912:
  > 93ad912 Print java and mvn version (# 65)
  > 86f9adc Fix default codegen pkg dir (# 67)

Signed-off-by: Knative Automation <automation@knative.team>

* Remove responsive-revision-gc config (#3545)

Since knative/serving#10084 deleted old GC and
started using responsive GC by default, `responsive-revision-gc` in
`config-feature` is not used at all.

This patch removes the configuration `responsive-revision-gc` in
`config-feature` configmap.

* Fixes #3117 and broken links (#3569)

* Fix #3117 and broken links

* Fix #3117 and broken links

* remove spec folder and redirect page and update links

* remove conflicts

* Update shortcodes.md (#3550)

minor grammar.

* 💄 slight change to ordered delivery guarantees (#3536)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Add knative-release-leads to OWNERS (#3586)

* add approvers ux (#3587)

* Update the default value (#3530)

* Adding notes on KafkaSource usage (#3596)

* Adding some Kafka note for use-cases

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* changing the description

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Update actions (#3581)

Signed-off-by: Knative Automation <automation@knative.team>

* Remove python pycache (#3594)

* Use correct setting in ClusterIssue setting (#3595)

The doc uses ClusterIssuer `letsencrypt-http01-issuer` but the configuration uses
`letsencrypt-issuer` so it is confusable.
Actual report is #3560.

So this patch changes the ClusterIssuer name to
`letsencrypt-http01-issuer` which is used in this doc section.

Fix #3560

* fix broken link #3568 #3577 (#3579)

* fix Netlify build

* Added Snippets folder and hidden Beta Contributor guide

* Update docs/eventing/event-registry.md

Co-authored-by: Carlos Santana <csantana23@gmail.com>

* whitespace

* more whitespace

* removing this bit because linting is killing me

* ok really the last one

Co-authored-by: Carlos Santana <csantana23@gmail.com>
Co-authored-by: RichardJJG <rijohnson@vmware.com>
Co-authored-by: knative-automation <automation@knative.team>
Co-authored-by: Shashankft9 <48708039+Shashankft9@users.noreply.github.com>
Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>
Co-authored-by: Benjamin Tan Wei Hao <benjamintanweihao@gmail.com>
Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
Co-authored-by: Jonathan Johnson <jonathan.johnson@dijure.com>
Co-authored-by: Matthias Wessendorf <mwessend@redhat.com>
Co-authored-by: Evan Anderson <evana@vmware.com>
Co-authored-by: RichieEscarez <rescarez@google.com>
Co-authored-by: NovaHe <heqianfly@gmail.com>
knative-prow-robot pushed a commit that referenced this pull request May 19, 2021
* change name for menu item for preview (#3533)

Signed-off-by: Carlos Santana <csantana23@gmail.com>

* Added detail per issue #3425 (#3514)

* Update knative/community files (#3553)

Signed-off-by: Knative Automation <automation@knative.team>

* tracing cm fix (#3506)

* remove unnecessary requrirements to do a release (#3563)

Signed-off-by: Carlos Santana <csantana23@gmail.com>

* #3543 fix link (#3567)

* Replace xip.io with sslip.io (#3574)

* Update actions (#3535)

Signed-off-by: Knative Automation <automation@knative.team>

* Update common github actions (#3552)

Signed-off-by: Knative Automation <automation@knative.team>

* upgrade to latest dependencies (#3505)

bumping knative.dev/hack 88c69cd...93ad912:
  > 93ad912 Print java and mvn version (# 65)
  > 86f9adc Fix default codegen pkg dir (# 67)

Signed-off-by: Knative Automation <automation@knative.team>

* Remove responsive-revision-gc config (#3545)

Since knative/serving#10084 deleted old GC and
started using responsive GC by default, `responsive-revision-gc` in
`config-feature` is not used at all.

This patch removes the configuration `responsive-revision-gc` in
`config-feature` configmap.

* Fixes #3117 and broken links (#3569)

* Fix #3117 and broken links

* Fix #3117 and broken links

* remove spec folder and redirect page and update links

* remove conflicts

* Update shortcodes.md (#3550)

minor grammar.

* 💄 slight change to ordered delivery guarantees (#3536)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Add knative-release-leads to OWNERS (#3586)

* add approvers ux (#3587)

* Update the default value (#3530)

* Adding notes on KafkaSource usage (#3596)

* Adding some Kafka note for use-cases

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* changing the description

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Update actions (#3581)

Signed-off-by: Knative Automation <automation@knative.team>

* Remove python pycache (#3594)

* Use correct setting in ClusterIssue setting (#3595)

The doc uses ClusterIssuer `letsencrypt-http01-issuer` but the configuration uses
`letsencrypt-issuer` so it is confusable.
Actual report is #3560.

So this patch changes the ClusterIssuer name to
`letsencrypt-http01-issuer` which is used in this doc section.

Fix #3560

* fix broken link #3568 #3577 (#3579)

* fix Netlify build

* Added Snippets folder and hidden Beta Contributor guide

* Update docs/eventing/event-registry.md

Co-authored-by: Carlos Santana <csantana23@gmail.com>

* whitespace

* more whitespace

* removing this bit because linting is killing me

* ok really the last one

* Updating to latest API version of Strimzi. v1beta1 is now gone 🔥 (#3603)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* 📓 adding a note to not consume records of the kafkachannel's topic... (#3615)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* fix broken link in kogito example (#3602)

* docs about usage of internal services in an "api-gateway" access model (#3597)

Co-authored-by: Brüder, Lena <lena.brueder@maxxeed.com>

* api specs for v0.23 (#3619)

Signed-off-by: Carlos Santana <csantana23@gmail.com>

* Update serving/_index.md with network layer option (#3585)

* Update _index.md

[#3117] Add ref for contour

* Update docs/serving/_index.md

Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>

Co-authored-by: Omer B <obensaadon@vmware.com>
Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>

* Fix typos in the sample yaml file (#3616)

* EventType is not yet part of the v1 eventing API (#3576)

* Remaining changes from now closed PRs

Co-authored-by: Carlos Santana <csantana23@gmail.com>
Co-authored-by: RichardJJG <rijohnson@vmware.com>
Co-authored-by: knative-automation <automation@knative.team>
Co-authored-by: Shashankft9 <48708039+Shashankft9@users.noreply.github.com>
Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>
Co-authored-by: Benjamin Tan Wei Hao <benjamintanweihao@gmail.com>
Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
Co-authored-by: Jonathan Johnson <jonathan.johnson@dijure.com>
Co-authored-by: Matthias Wessendorf <mwessend@redhat.com>
Co-authored-by: Evan Anderson <evana@vmware.com>
Co-authored-by: RichieEscarez <rescarez@google.com>
Co-authored-by: NovaHe <heqianfly@gmail.com>
Co-authored-by: Kevin Marquardsen <mr.kmarq@gmail.com>
Co-authored-by: Lena Brüder <oss@lena-brueder.de>
Co-authored-by: Brüder, Lena <lena.brueder@maxxeed.com>
Co-authored-by: Sameer Vohra <vsameer@vmware.com>
Co-authored-by: Mahdi K. Fard <xclud@users.noreply.github.com>
RichardJJG added a commit to RichardJJG/docs that referenced this pull request Jun 30, 2021
…e website, create `/snippets` directory (knative#3610)

* change name for menu item for preview (knative#3533)

Signed-off-by: Carlos Santana <csantana23@gmail.com>

* Added detail per issue knative#3425 (knative#3514)

* Update knative/community files (knative#3553)

Signed-off-by: Knative Automation <automation@knative.team>

* tracing cm fix (knative#3506)

* remove unnecessary requrirements to do a release (knative#3563)

Signed-off-by: Carlos Santana <csantana23@gmail.com>

* knative#3543 fix link (knative#3567)

* Replace xip.io with sslip.io (knative#3574)

* Update actions (knative#3535)

Signed-off-by: Knative Automation <automation@knative.team>

* Update common github actions (knative#3552)

Signed-off-by: Knative Automation <automation@knative.team>

* upgrade to latest dependencies (knative#3505)

bumping knative.dev/hack 88c69cd...93ad912:
  > 93ad912 Print java and mvn version (# 65)
  > 86f9adc Fix default codegen pkg dir (# 67)

Signed-off-by: Knative Automation <automation@knative.team>

* Remove responsive-revision-gc config (knative#3545)

Since knative/serving#10084 deleted old GC and
started using responsive GC by default, `responsive-revision-gc` in
`config-feature` is not used at all.

This patch removes the configuration `responsive-revision-gc` in
`config-feature` configmap.

* Fixes knative#3117 and broken links (knative#3569)

* Fix knative#3117 and broken links

* Fix knative#3117 and broken links

* remove spec folder and redirect page and update links

* remove conflicts

* Update shortcodes.md (knative#3550)

minor grammar.

* 💄 slight change to ordered delivery guarantees (knative#3536)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Add knative-release-leads to OWNERS (knative#3586)

* add approvers ux (knative#3587)

* Update the default value (knative#3530)

* Adding notes on KafkaSource usage (knative#3596)

* Adding some Kafka note for use-cases

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* changing the description

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Update actions (knative#3581)

Signed-off-by: Knative Automation <automation@knative.team>

* Remove python pycache (knative#3594)

* Use correct setting in ClusterIssue setting (knative#3595)

The doc uses ClusterIssuer `letsencrypt-http01-issuer` but the configuration uses
`letsencrypt-issuer` so it is confusable.
Actual report is knative#3560.

So this patch changes the ClusterIssuer name to
`letsencrypt-http01-issuer` which is used in this doc section.

Fix knative#3560

* fix broken link knative#3568 knative#3577 (knative#3579)

* fix Netlify build

* Added Snippets folder and hidden Beta Contributor guide

* Update docs/eventing/event-registry.md

Co-authored-by: Carlos Santana <csantana23@gmail.com>

* whitespace

* more whitespace

* removing this bit because linting is killing me

* ok really the last one

Co-authored-by: Carlos Santana <csantana23@gmail.com>
Co-authored-by: RichardJJG <rijohnson@vmware.com>
Co-authored-by: knative-automation <automation@knative.team>
Co-authored-by: Shashankft9 <48708039+Shashankft9@users.noreply.github.com>
Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>
Co-authored-by: Benjamin Tan Wei Hao <benjamintanweihao@gmail.com>
Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
Co-authored-by: Jonathan Johnson <jonathan.johnson@dijure.com>
Co-authored-by: Matthias Wessendorf <mwessend@redhat.com>
Co-authored-by: Evan Anderson <evana@vmware.com>
Co-authored-by: RichieEscarez <rescarez@google.com>
Co-authored-by: NovaHe <heqianfly@gmail.com>
RichardJJG added a commit to RichardJJG/docs that referenced this pull request Jun 30, 2021
* change name for menu item for preview (knative#3533)

Signed-off-by: Carlos Santana <csantana23@gmail.com>

* Added detail per issue knative#3425 (knative#3514)

* Update knative/community files (knative#3553)

Signed-off-by: Knative Automation <automation@knative.team>

* tracing cm fix (knative#3506)

* remove unnecessary requrirements to do a release (knative#3563)

Signed-off-by: Carlos Santana <csantana23@gmail.com>

* knative#3543 fix link (knative#3567)

* Replace xip.io with sslip.io (knative#3574)

* Update actions (knative#3535)

Signed-off-by: Knative Automation <automation@knative.team>

* Update common github actions (knative#3552)

Signed-off-by: Knative Automation <automation@knative.team>

* upgrade to latest dependencies (knative#3505)

bumping knative.dev/hack 88c69cd...93ad912:
  > 93ad912 Print java and mvn version (# 65)
  > 86f9adc Fix default codegen pkg dir (# 67)

Signed-off-by: Knative Automation <automation@knative.team>

* Remove responsive-revision-gc config (knative#3545)

Since knative/serving#10084 deleted old GC and
started using responsive GC by default, `responsive-revision-gc` in
`config-feature` is not used at all.

This patch removes the configuration `responsive-revision-gc` in
`config-feature` configmap.

* Fixes knative#3117 and broken links (knative#3569)

* Fix knative#3117 and broken links

* Fix knative#3117 and broken links

* remove spec folder and redirect page and update links

* remove conflicts

* Update shortcodes.md (knative#3550)

minor grammar.

* 💄 slight change to ordered delivery guarantees (knative#3536)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Add knative-release-leads to OWNERS (knative#3586)

* add approvers ux (knative#3587)

* Update the default value (knative#3530)

* Adding notes on KafkaSource usage (knative#3596)

* Adding some Kafka note for use-cases

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* changing the description

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Update actions (knative#3581)

Signed-off-by: Knative Automation <automation@knative.team>

* Remove python pycache (knative#3594)

* Use correct setting in ClusterIssue setting (knative#3595)

The doc uses ClusterIssuer `letsencrypt-http01-issuer` but the configuration uses
`letsencrypt-issuer` so it is confusable.
Actual report is knative#3560.

So this patch changes the ClusterIssuer name to
`letsencrypt-http01-issuer` which is used in this doc section.

Fix knative#3560

* fix broken link knative#3568 knative#3577 (knative#3579)

* fix Netlify build

* Added Snippets folder and hidden Beta Contributor guide

* Update docs/eventing/event-registry.md

Co-authored-by: Carlos Santana <csantana23@gmail.com>

* whitespace

* more whitespace

* removing this bit because linting is killing me

* ok really the last one

* Updating to latest API version of Strimzi. v1beta1 is now gone 🔥 (knative#3603)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* 📓 adding a note to not consume records of the kafkachannel's topic... (knative#3615)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* fix broken link in kogito example (knative#3602)

* docs about usage of internal services in an "api-gateway" access model (knative#3597)

Co-authored-by: Brüder, Lena <lena.brueder@maxxeed.com>

* api specs for v0.23 (knative#3619)

Signed-off-by: Carlos Santana <csantana23@gmail.com>

* Update serving/_index.md with network layer option (knative#3585)

* Update _index.md

[knative#3117] Add ref for contour

* Update docs/serving/_index.md

Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>

Co-authored-by: Omer B <obensaadon@vmware.com>
Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>

* Fix typos in the sample yaml file (knative#3616)

* EventType is not yet part of the v1 eventing API (knative#3576)

* Remaining changes from now closed PRs

Co-authored-by: Carlos Santana <csantana23@gmail.com>
Co-authored-by: RichardJJG <rijohnson@vmware.com>
Co-authored-by: knative-automation <automation@knative.team>
Co-authored-by: Shashankft9 <48708039+Shashankft9@users.noreply.github.com>
Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>
Co-authored-by: Benjamin Tan Wei Hao <benjamintanweihao@gmail.com>
Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
Co-authored-by: Jonathan Johnson <jonathan.johnson@dijure.com>
Co-authored-by: Matthias Wessendorf <mwessend@redhat.com>
Co-authored-by: Evan Anderson <evana@vmware.com>
Co-authored-by: RichieEscarez <rescarez@google.com>
Co-authored-by: NovaHe <heqianfly@gmail.com>
Co-authored-by: Kevin Marquardsen <mr.kmarq@gmail.com>
Co-authored-by: Lena Brüder <oss@lena-brueder.de>
Co-authored-by: Brüder, Lena <lena.brueder@maxxeed.com>
Co-authored-by: Sameer Vohra <vsameer@vmware.com>
Co-authored-by: Mahdi K. Fard <xclud@users.noreply.github.com>
RichardJJG added a commit to RichardJJG/docs that referenced this pull request Jul 1, 2021
…e website, create `/snippets` directory (knative#3610)

* change name for menu item for preview (knative#3533)

Signed-off-by: Carlos Santana <csantana23@gmail.com>

* Added detail per issue knative#3425 (knative#3514)

* Update knative/community files (knative#3553)

Signed-off-by: Knative Automation <automation@knative.team>

* tracing cm fix (knative#3506)

* remove unnecessary requrirements to do a release (knative#3563)

Signed-off-by: Carlos Santana <csantana23@gmail.com>

* knative#3543 fix link (knative#3567)

* Replace xip.io with sslip.io (knative#3574)

* Update actions (knative#3535)

Signed-off-by: Knative Automation <automation@knative.team>

* Update common github actions (knative#3552)

Signed-off-by: Knative Automation <automation@knative.team>

* upgrade to latest dependencies (knative#3505)

bumping knative.dev/hack 88c69cd...93ad912:
  > 93ad912 Print java and mvn version (# 65)
  > 86f9adc Fix default codegen pkg dir (# 67)

Signed-off-by: Knative Automation <automation@knative.team>

* Remove responsive-revision-gc config (knative#3545)

Since knative/serving#10084 deleted old GC and
started using responsive GC by default, `responsive-revision-gc` in
`config-feature` is not used at all.

This patch removes the configuration `responsive-revision-gc` in
`config-feature` configmap.

* Fixes knative#3117 and broken links (knative#3569)

* Fix knative#3117 and broken links

* Fix knative#3117 and broken links

* remove spec folder and redirect page and update links

* remove conflicts

* Update shortcodes.md (knative#3550)

minor grammar.

* 💄 slight change to ordered delivery guarantees (knative#3536)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Add knative-release-leads to OWNERS (knative#3586)

* add approvers ux (knative#3587)

* Update the default value (knative#3530)

* Adding notes on KafkaSource usage (knative#3596)

* Adding some Kafka note for use-cases

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* changing the description

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Update actions (knative#3581)

Signed-off-by: Knative Automation <automation@knative.team>

* Remove python pycache (knative#3594)

* Use correct setting in ClusterIssue setting (knative#3595)

The doc uses ClusterIssuer `letsencrypt-http01-issuer` but the configuration uses
`letsencrypt-issuer` so it is confusable.
Actual report is knative#3560.

So this patch changes the ClusterIssuer name to
`letsencrypt-http01-issuer` which is used in this doc section.

Fix knative#3560

* fix broken link knative#3568 knative#3577 (knative#3579)

* fix Netlify build

* Added Snippets folder and hidden Beta Contributor guide

* Update docs/eventing/event-registry.md

Co-authored-by: Carlos Santana <csantana23@gmail.com>

* whitespace

* more whitespace

* removing this bit because linting is killing me

* ok really the last one

Co-authored-by: Carlos Santana <csantana23@gmail.com>
Co-authored-by: RichardJJG <rijohnson@vmware.com>
Co-authored-by: knative-automation <automation@knative.team>
Co-authored-by: Shashankft9 <48708039+Shashankft9@users.noreply.github.com>
Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>
Co-authored-by: Benjamin Tan Wei Hao <benjamintanweihao@gmail.com>
Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
Co-authored-by: Jonathan Johnson <jonathan.johnson@dijure.com>
Co-authored-by: Matthias Wessendorf <mwessend@redhat.com>
Co-authored-by: Evan Anderson <evana@vmware.com>
Co-authored-by: RichieEscarez <rescarez@google.com>
Co-authored-by: NovaHe <heqianfly@gmail.com>
RichardJJG added a commit to RichardJJG/docs that referenced this pull request Jul 1, 2021
* change name for menu item for preview (knative#3533)

Signed-off-by: Carlos Santana <csantana23@gmail.com>

* Added detail per issue knative#3425 (knative#3514)

* Update knative/community files (knative#3553)

Signed-off-by: Knative Automation <automation@knative.team>

* tracing cm fix (knative#3506)

* remove unnecessary requrirements to do a release (knative#3563)

Signed-off-by: Carlos Santana <csantana23@gmail.com>

* knative#3543 fix link (knative#3567)

* Replace xip.io with sslip.io (knative#3574)

* Update actions (knative#3535)

Signed-off-by: Knative Automation <automation@knative.team>

* Update common github actions (knative#3552)

Signed-off-by: Knative Automation <automation@knative.team>

* upgrade to latest dependencies (knative#3505)

bumping knative.dev/hack 88c69cd...93ad912:
  > 93ad912 Print java and mvn version (# 65)
  > 86f9adc Fix default codegen pkg dir (# 67)

Signed-off-by: Knative Automation <automation@knative.team>

* Remove responsive-revision-gc config (knative#3545)

Since knative/serving#10084 deleted old GC and
started using responsive GC by default, `responsive-revision-gc` in
`config-feature` is not used at all.

This patch removes the configuration `responsive-revision-gc` in
`config-feature` configmap.

* Fixes knative#3117 and broken links (knative#3569)

* Fix knative#3117 and broken links

* Fix knative#3117 and broken links

* remove spec folder and redirect page and update links

* remove conflicts

* Update shortcodes.md (knative#3550)

minor grammar.

* 💄 slight change to ordered delivery guarantees (knative#3536)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Add knative-release-leads to OWNERS (knative#3586)

* add approvers ux (knative#3587)

* Update the default value (knative#3530)

* Adding notes on KafkaSource usage (knative#3596)

* Adding some Kafka note for use-cases

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* changing the description

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Update actions (knative#3581)

Signed-off-by: Knative Automation <automation@knative.team>

* Remove python pycache (knative#3594)

* Use correct setting in ClusterIssue setting (knative#3595)

The doc uses ClusterIssuer `letsencrypt-http01-issuer` but the configuration uses
`letsencrypt-issuer` so it is confusable.
Actual report is knative#3560.

So this patch changes the ClusterIssuer name to
`letsencrypt-http01-issuer` which is used in this doc section.

Fix knative#3560

* fix broken link knative#3568 knative#3577 (knative#3579)

* fix Netlify build

* Added Snippets folder and hidden Beta Contributor guide

* Update docs/eventing/event-registry.md

Co-authored-by: Carlos Santana <csantana23@gmail.com>

* whitespace

* more whitespace

* removing this bit because linting is killing me

* ok really the last one

* Updating to latest API version of Strimzi. v1beta1 is now gone 🔥 (knative#3603)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* 📓 adding a note to not consume records of the kafkachannel's topic... (knative#3615)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* fix broken link in kogito example (knative#3602)

* docs about usage of internal services in an "api-gateway" access model (knative#3597)

Co-authored-by: Brüder, Lena <lena.brueder@maxxeed.com>

* api specs for v0.23 (knative#3619)

Signed-off-by: Carlos Santana <csantana23@gmail.com>

* Update serving/_index.md with network layer option (knative#3585)

* Update _index.md

[knative#3117] Add ref for contour

* Update docs/serving/_index.md

Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>

Co-authored-by: Omer B <obensaadon@vmware.com>
Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>

* Fix typos in the sample yaml file (knative#3616)

* EventType is not yet part of the v1 eventing API (knative#3576)

* Remaining changes from now closed PRs

Co-authored-by: Carlos Santana <csantana23@gmail.com>
Co-authored-by: RichardJJG <rijohnson@vmware.com>
Co-authored-by: knative-automation <automation@knative.team>
Co-authored-by: Shashankft9 <48708039+Shashankft9@users.noreply.github.com>
Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>
Co-authored-by: Benjamin Tan Wei Hao <benjamintanweihao@gmail.com>
Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
Co-authored-by: Jonathan Johnson <jonathan.johnson@dijure.com>
Co-authored-by: Matthias Wessendorf <mwessend@redhat.com>
Co-authored-by: Evan Anderson <evana@vmware.com>
Co-authored-by: RichieEscarez <rescarez@google.com>
Co-authored-by: NovaHe <heqianfly@gmail.com>
Co-authored-by: Kevin Marquardsen <mr.kmarq@gmail.com>
Co-authored-by: Lena Brüder <oss@lena-brueder.de>
Co-authored-by: Brüder, Lena <lena.brueder@maxxeed.com>
Co-authored-by: Sameer Vohra <vsameer@vmware.com>
Co-authored-by: Mahdi K. Fard <xclud@users.noreply.github.com>
@abrennan89 abrennan89 deleted the 3543 branch August 26, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Knative Serving(docs/serving/_index.md)

3 participants