Skip to content

Remove dead code. #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
google-prow-robot merged 1 commit into from
Jun 12, 2018
Merged

Remove dead code. #1173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions pkg/controller/revision/revision.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -832,27 +832,6 @@ func (c *Controller) reconcileAutoscalerDeployment(ctx context.Context, rev *v1a
return err
}

func (c *Controller) removeFinalizers(ctx context.Context, rev *v1alpha1.Revision, ns string) error {
logger := logging.FromContext(ctx)
logger.Infof("Removing finalizers for %q\n", rev.Name)
accessor, err := meta.Accessor(rev)
if err != nil {
logger.Panic("Failed to get metadata", zap.Error(err))
}
finalizers := accessor.GetFinalizers()
for i, v := range finalizers {
if v == "controller" {
finalizers = append(finalizers[:i], finalizers[i+1:]...)
}
}
accessor.SetFinalizers(finalizers)
prClient := c.ElaClientSet.ServingV1alpha1().Revisions(rev.Namespace)
prClient.Update(rev)
logger.Infof("The finalizer 'controller' is removed.")

return nil
}

func (c *Controller) updateStatus(rev *v1alpha1.Revision) (*v1alpha1.Revision, error) {
prClient := c.ElaClientSet.ServingV1alpha1().Revisions(rev.Namespace)
newRev, err := prClient.Get(rev.Name, metav1.GetOptions{})
Expand Down