Remove dead code.#1173
Merged
Merged
Conversation
google-prow-robot
added
approved
|
The following is the coverage report on pkg/. Say
*TestCoverage feature is being tested, do not rely on any info here yet |
Member
Author
|
/test pull-knative-serving-integration-tests |
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, vaikas-google The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The following is the coverage report on pkg/. Say
*TestCoverage feature is being tested, do not rely on any info here yet |
skonto
added a commit
to skonto/serving
that referenced
this pull request
Jul 22, 2022
skonto
added a commit
to skonto/serving
that referenced
this pull request
Jul 27, 2022
skonto
added a commit
to skonto/serving
that referenced
this pull request
Jul 27, 2022
skonto
added a commit
to skonto/serving
that referenced
this pull request
Jul 27, 2022
skonto
added a commit
to skonto/serving
that referenced
this pull request
Jul 29, 2022
* [RELEASE-1.4] Inject images, generate manifests (knative#1169) * inject images, generate manifests (knative#1150) * Revert temoprary branch for image injection (knative#1159) Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com> * fixes for 1.5 * Kourier image injection (knative#1173) * Revert temoprary branch for image injection (knative#1186) Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
nak3
added a commit
to nak3/serving
that referenced
this pull request
Aug 3, 2022
* [RELEASE-1.4] Inject images, generate manifests (knative#1169) * inject images, generate manifests (knative#1150) * Revert temoprary branch for image injection (knative#1159) Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com> * fixes for main * Kourier image injection (knative#1173) * Revert temoprary branch for image injection (knative#1186) * add pdb fix * Revert "add pdb fix" This reverts commit 1790632. Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
mgencur
pushed a commit
to mgencur/serving-1
that referenced
this pull request
Sep 6, 2022
* [RELEASE-1.4] Inject images, generate manifests (knative#1169) * inject images, generate manifests (knative#1150) * Revert temoprary branch for image injection (knative#1159) Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com> * fixes for 1.6 * Kourier image injection (knative#1173) * Revert temoprary branch for image injection (knative#1186) Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to be completely unused.