Skip to content

Changing Minikube instructions to use kubeadm as the bootstrapper#1191

Closed
trisberg wants to merge 2 commits into
knative:masterfrom
trisberg:minikube-kubeadm
Closed

Changing Minikube instructions to use kubeadm as the bootstrapper#1191
trisberg wants to merge 2 commits into
knative:masterfrom
trisberg:minikube-kubeadm

Conversation

@trisberg
Copy link
Copy Markdown
Contributor

@trisberg trisberg commented Jun 13, 2018 •
edited
Loading

Fixes #1190

Proposed Changes

  • changing to k8s v1.10.4
  • changing extra-config options to use kubeadm style keys

Release Note

NONE

trisberg added 2 commits June 7, 2018 10:18
@trisberg
Changing to use kubeadm as the bootstrapper
63e8e6f
@trisberg
Update Minikube configuration
4816cb4 
- removing extra-config for RBAC since that is the default

- changing to k8s v1.10.4

- adding back extra-config for cert and key files
@google-prow-robot
Copy link
Copy Markdown

google-prow-robot commented Jun 13, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: trisberg
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mattmoor

Assign the PR to them by writing /assign @mattmoor in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-prow-robot google-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 13, 2018
@trisberg trisberg changed the title Minikube kubeadm Minikube kubeadm config Jun 13, 2018
@google-prow-robot
Copy link
Copy Markdown

google-prow-robot commented Jun 13, 2018 •
edited
Loading

@trisberg: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-knative-serving-go-coverage 4816cb4 link /test pull-knative-serving-go-coverage

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@trisberg trisberg closed this Jun 13, 2018
@trisberg trisberg changed the title Minikube kubeadm config Changing Minikube instructions to use kubeadm as the bootstrapper Jun 13, 2018
nak3 added a commit to nak3/serving that referenced this pull request Aug 3, 2022
@skonto @nak3
[MAIN] Image injection (knative#1191)
a02c5ae 
* [RELEASE-1.4] Inject images, generate manifests (knative#1169)

* inject images, generate manifests (knative#1150)

* Revert temoprary branch for image injection (knative#1159)

Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>

* fixes for main

* Kourier image injection (knative#1173)

* Revert temoprary branch for image injection (knative#1186)

* add pdb fix

* Revert "add pdb fix"

This reverts commit 1790632.

Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@trisberg @google-prow-robot