Make stackdriver agent work for detecting Json log#1169
Merged
google-prow-robot merged 4 commits intoJun 13, 2018
Conversation
rootfs
reviewed
Jun 12, 2018
|
|
||
| data := map[string]string{ | ||
| "log": "A log in json format to STDOUT", | ||
| "foo": "bar", |
Contributor
Author
There was a problem hiding this comment.
To indicate any random key-value pair in json log emitted by the app can be collected/processed.
Contributor
|
/lgtm |
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mdemirhan, vaikas-google, yanweiguo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
markusthoemmes
referenced
this pull request
in openshift/knative-serving
Apr 3, 2019
* change fluentd config * rename * change kubernetes_metadata version requirement
skonto
added a commit
to skonto/serving
that referenced
this pull request
Jul 14, 2022
* inject images, generate manifests (knative#1150) * Revert temoprary branch for image injection (knative#1159) Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
skonto
added a commit
to skonto/serving
that referenced
this pull request
Jul 27, 2022
* inject images, generate manifests (knative#1150) * Revert temoprary branch for image injection (knative#1159) Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
skonto
added a commit
to skonto/serving
that referenced
this pull request
Jul 27, 2022
* inject images, generate manifests (knative#1150) * Revert temoprary branch for image injection (knative#1159) Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
skonto
added a commit
to skonto/serving
that referenced
this pull request
Jul 27, 2022
* inject images, generate manifests (knative#1150) * Revert temoprary branch for image injection (knative#1159) Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
skonto
added a commit
to skonto/serving
that referenced
this pull request
Jul 29, 2022
* [RELEASE-1.4] Inject images, generate manifests (knative#1169) * inject images, generate manifests (knative#1150) * Revert temoprary branch for image injection (knative#1159) Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com> * fixes for 1.5 * Kourier image injection (knative#1173) * Revert temoprary branch for image injection (knative#1186) Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
nak3
added a commit
to nak3/serving
that referenced
this pull request
Aug 3, 2022
* [RELEASE-1.4] Inject images, generate manifests (knative#1169) * inject images, generate manifests (knative#1150) * Revert temoprary branch for image injection (knative#1159) Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com> * fixes for main * Kourier image injection (knative#1173) * Revert temoprary branch for image injection (knative#1186) * add pdb fix * Revert "add pdb fix" This reverts commit 1790632. Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
mgencur
pushed a commit
to mgencur/serving-1
that referenced
this pull request
Sep 6, 2022
* [RELEASE-1.4] Inject images, generate manifests (knative#1169) * inject images, generate manifests (knative#1150) * Revert temoprary branch for image injection (knative#1159) Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com> * fixes for 1.6 * Kourier image injection (knative#1173) * Revert temoprary branch for image injection (knative#1186) Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
skonto
added a commit
to skonto/serving
that referenced
this pull request
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a json log emitted by user, for example,
{ "log": "hello", "foo": "bar" }In fluentd event flows, before operator output configuration, we convert it to
For
stderr/stdout,kubernetes_metadataplugin does the json parsing, which is a responsibility shouldn't belong tokubernetes_metadata. (This feature was removed since versionkubernetes_metadata2.1.0). For varlog, we parse the json intail.Then operator configure the destination backend and other extra process. This works fine for Elasticsearch, but it doesn't work for Stackdriver. Stackdriver will only try to parse
logfield as json if there're only the following fields: log(or message), time, severity, docker, kubernetes.Proposed Changes
logfield, which can be a json payload:parserto parse the json.detect_jsonparameter ingoogle_cloudplugin.