Skip to content

[WIP] Use cert-manager to deploy internal certificates#12998

Closed
nak3 wants to merge 2 commits into
knative:mainfrom
nak3:use-cert-manager
Closed

[WIP] Use cert-manager to deploy internal certificates#12998
nak3 wants to merge 2 commits into
knative:mainfrom
nak3:use-cert-manager

Conversation

@nak3
Copy link
Copy Markdown
Contributor

@nak3 nak3 commented Jun 6, 2022

This patch allows to use cert-manager to deploy internal certificates.

The implementation does not have any change actually but it changes to:

TODO:

  • Allow to specify the namespace for CA secret. (cert-manager needs to deploy CA in cert-manager ns.)
  • Allow to specify the CA cert key. (cert-manager uses tls.crt instead of ca.crt).

@knative-prow knative-prow Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/API API objects and controllers area/autoscale area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Jun 6, 2022
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Jun 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 6, 2022

Codecov Report

Merging #12998 (5b0beb3) into main (bb5bdbb) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main   #12998      +/-   ##
==========================================
- Coverage   87.01%   86.99%   -0.02%     
==========================================
  Files         197      197              
  Lines       14439    14440       +1     
==========================================
- Hits        12564    12562       -2     
- Misses       1580     1583       +3     
  Partials      295      295              
Impacted Files Coverage Δ
cmd/activator/main.go 0.00% <0.00%> (ø)
pkg/reconciler/autoscaling/kpa/kpa.go 95.21% <ø> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb5bdbb...5b0beb3. Read the comment docs.

@nak3
Copy link
Copy Markdown
Contributor Author

nak3 commented Jun 8, 2022

Closing as I think we should start narrow support like #13005 instead of cert-manager support.

@nak3 nak3 closed this Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/autoscale area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support encrypted traffic between ingress and queue-proxy

1 participant