[WIP] Use cert-manager to deploy internal certificates#12998
Closed
nak3 wants to merge 2 commits into
Closed
Conversation
Drop unit test added by 21c05dc
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nak3 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## main #12998 +/- ##
==========================================
- Coverage 87.01% 86.99% -0.02%
==========================================
Files 197 197
Lines 14439 14440 +1
==========================================
- Hits 12564 12562 -2
- Misses 1580 1583 +3
Partials 295 295
Continue to review full report at Codecov.
|
Contributor
Author
|
Closing as I think we should start narrow support like #13005 instead of cert-manager support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch allows to use cert-manager to deploy internal certificates.
The implementation does not have any change actually but it changes to:
test/generate-cert.sh) as cert-manager does everything.TODO:
cert-managerns.)tls.crtinstead ofca.crt).