Skip to content

[WIP] Add certificate reconciler for internal certs#13000

Closed
nak3 wants to merge 2 commits into
knative:mainfrom
nak3:add-cert-controller
Closed

[WIP] Add certificate reconciler for internal certs#13000
nak3 wants to merge 2 commits into
knative:mainfrom
nak3:add-cert-controller

Conversation

@nak3
Copy link
Copy Markdown
Contributor

@nak3 nak3 commented Jun 7, 2022

This patch changes to add certificate reconciler for internal certs

This is an alternative idea of #12998.
Feature track mentioned about both this and using cert-manager.

@knative-prow knative-prow Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 7, 2022
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Jun 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added area/API API objects and controllers area/autoscale area/networking approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Jun 7, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 7, 2022

Codecov Report

Merging #13000 (0466d26) into main (bb5bdbb) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main   #13000   +/-   ##
=======================================
  Coverage   87.01%   87.01%           
=======================================
  Files         197      197           
  Lines       14439    14439           
=======================================
  Hits        12564    12564           
  Misses       1580     1580           
  Partials      295      295           
Impacted Files Coverage Δ
cmd/activator/main.go 0.00% <0.00%> (ø)
cmd/controller/main.go 0.00% <ø> (ø)
cmd/queue/main.go 0.64% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb5bdbb...0466d26. Read the comment docs.

@nak3 nak3 force-pushed the add-cert-controller branch from 63c95ac to f01d2f8 Compare June 7, 2022 13:36
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 11, 2022
@knative-prow-robot
Copy link
Copy Markdown
Contributor

@nak3: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nak3 nak3 closed this Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/autoscale area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants