Skip to content

[release-1.6] Tests for encryption with Kourier local gateway#13277

Closed
knative-prow-robot wants to merge 6 commits into
knative:release-1.6from
knative-prow-robot:cherry-pick-13263-to-release-1.6
Closed

[release-1.6] Tests for encryption with Kourier local gateway#13277
knative-prow-robot wants to merge 6 commits into
knative:release-1.6from
knative-prow-robot:cherry-pick-13263-to-release-1.6

Conversation

@knative-prow-robot
Copy link
Copy Markdown
Contributor

This is an automated cherry-pick of #13263


@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Sep 5, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: knative-prow-robot
Once this PR has been reviewed and has the lgtm label, please assign dsimansk for approval by writing /assign @dsimansk in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added area/test-and-release It flags unit/e2e/conformance/perf test issues for product features size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 5, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 5, 2022

Codecov Report

Merging #13277 (196bff9) into release-1.6 (3666ce7) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           release-1.6   #13277   +/-   ##
============================================
  Coverage        86.80%   86.80%           
============================================
  Files              196      196           
  Lines            14410    14410           
============================================
  Hits             12509    12509           
  Misses            1607     1607           
  Partials           294      294           
Impacted Files Coverage Δ
pkg/reconciler/revision/background.go 89.09% <0.00%> (-1.82%) ⬇️
pkg/autoscaler/statforwarder/leases.go 73.95% <0.00%> (+1.56%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mgencur
Copy link
Copy Markdown
Contributor

mgencur commented Sep 6, 2022

/lgtm
/assign @nak3

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2022
@nak3
Copy link
Copy Markdown
Contributor

nak3 commented Sep 6, 2022

This PR adds the "new test" code/script. I wonder that we should not backport it as it will cut a new 1.6.x branch and make confusion for users.

@mgencur It is not OK to backport it on downstream only?

@mgencur
Copy link
Copy Markdown
Contributor

mgencur commented Sep 6, 2022

OK. It's probably fine to backport downstream only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/test-and-release It flags unit/e2e/conformance/perf test issues for product features lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants