Skip to content

[release-1.7] Tests for encryption with Kourier local gateway#13278

Closed
knative-prow-robot wants to merge 6 commits into
knative:release-1.7from
knative-prow-robot:cherry-pick-13263-to-release-1.7
Closed

[release-1.7] Tests for encryption with Kourier local gateway#13278
knative-prow-robot wants to merge 6 commits into
knative:release-1.7from
knative-prow-robot:cherry-pick-13263-to-release-1.7

Conversation

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@knative-prow-robot knative-prow-robot commented Sep 5, 2022

This is an automated cherry-pick of #13263

@knative-prow-robot knative-prow-robot mentioned this pull request Sep 5, 2022
Merged
@knative-prow knative-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Sep 5, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 5, 2022 •
edited
Loading

Codecov Report

Merging #13278 (f39fd78) into release-1.7 (9402a71) will increase coverage by 0.03%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           release-1.7   #13278      +/-   ##
===============================================
+ Coverage        86.55%   86.58%   +0.03%     
===============================================
  Files              196      196              
  Lines            14511    14511              
===============================================
+ Hits             12560    12565       +5     
+ Misses            1652     1648       -4     
+ Partials           299      298       -1
Impacted Files Coverage Δ
pkg/autoscaler/scaling/multiscaler.go 88.59% <0.00%> (+1.34%) ⬆️
pkg/reconciler/configuration/configuration.go 85.20% <0.00%> (+1.53%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mgencur
Copy link
Copy Markdown
Contributor

mgencur commented Sep 6, 2022

/retest
/lgtm
/assign @nak3

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2022
psschwei
psschwei reviewed Sep 6, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2022
@psschwei
Copy link
Copy Markdown
Member

psschwei commented Sep 6, 2022

/hold

@knative-prow knative-prow Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2022
@psschwei
Copy link
Copy Markdown
Member

psschwei commented Sep 6, 2022 •
edited
Loading

Looks like based on the comment here we're only going to merge this downstream...

#13277 (comment)

@psschwei
Copy link
Copy Markdown
Member

psschwei commented Sep 6, 2022

/remove-approve

@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Sep 6, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: knative-prow-robot
Once this PR has been reviewed and has the lgtm label, please ask for approval from nak3 by writing /assign @nak3 in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2022
@psschwei
Copy link
Copy Markdown
Member

psschwei commented Sep 6, 2022

/hold cancel

@knative-prow knative-prow Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2022
@mgencur
Copy link
Copy Markdown
Contributor

mgencur commented Sep 6, 2022

Yeah. It's alright to only have this downstream. The main branch has the tests for the future.

@psschwei psschwei closed this Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@psschwei psschwei psschwei left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mgencur mgencur

@nak3 nak3

Labels

area/test-and-release It flags unit/e2e/conformance/perf test issues for product features lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@knative-prow-robot @mgencur @psschwei @nak3