Skip to content

Add --namespace flag to e2e & conformance test#1329

Merged
google-prow-robot merged 7 commits intoknative:masterfrom
pivotal-cf-experimental:e2e-configurable-namespace
Jul 3, 2018
Merged

Add --namespace flag to e2e & conformance test#1329
google-prow-robot merged 7 commits intoknative:masterfrom
pivotal-cf-experimental:e2e-configurable-namespace

Conversation

@tanzeeb
Copy link
Copy Markdown
Contributor

@tanzeeb tanzeeb commented Jun 22, 2018

Fixes #935

Proposed Changes

  • Add a --namespace flag, will be used if specified
  • Otherwise, the current defaults (noodleburg and pizzaplanet) will be used.

Release Note

NONE

@google-prow-robot google-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 22, 2018
@tanzeeb
Copy link
Copy Markdown
Contributor Author

tanzeeb commented Jun 25, 2018

/assign @bobcatfish

bobcatfish
bobcatfish approved these changes Jun 25, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@bobcatfish bobcatfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on @tanzeeb !

/meow space

/lgtm
/approve

Adding a hold for small changes:
/hold

Comment thread test/README.md Outdated
Copy link
Copy Markdown
Contributor

@bobcatfish bobcatfish Jun 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing the level of these headers too!

Comment thread test/conformance/route_test.go Outdated
Copy link
Copy Markdown
Contributor

@bobcatfish bobcatfish Jun 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call!

Comment thread test/e2e/e2e.go Outdated
Copy link
Copy Markdown
Contributor

@bobcatfish bobcatfish Jun 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wish there was a way to do this without using a global variable - @tanzeeb would you be interested in updating the functions used by the e2e tests to take namespace as a parameter vs. importing from e2e.go?

no worries if you feel that's outside the scope of this change or disagree!

Comment thread test/e2e_flags.go Outdated
Copy link
Copy Markdown
Contributor

@bobcatfish bobcatfish Jun 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment could be updated to mention the namespace arg - or we could simplify the comment such that we don't need to update it every time we add a new flag

@google-prow-robot
Copy link
Copy Markdown

google-prow-robot commented Jun 25, 2018

@bobcatfish: cat image

Details

In response to this:

Thanks for taking this on @tanzeeb !

/meow space

/lgtm
/approve

Adding a hold for small changes:
/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-prow-robot google-prow-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 25, 2018
@bobcatfish bobcatfish mentioned this pull request Jun 26, 2018
Closed
@tanzeeb
Small changes for PR #1329
2959851 
* Use test.Flags.Namespace instead of global variables
* Updated comments for test.Flags and test.EnvironmentFlags
@google-prow-robot google-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2018
@tanzeeb
Copy link
Copy Markdown
Contributor Author

tanzeeb commented Jun 27, 2018

Thanks for the feedback @bobcatfish. I pushed a few updates:

  • The field descriptions are now on the respective EnvironmentFlag fields. I think this sets a more maintainable precedent (ie. when someone adds a new flag, they'll see the convention to add a descriptive comment as well).

  • Instead of a global variable (previously global constant) for NamespaceName, just use test.Flags.Namespace directly. This is similar to how the tests reference test.Flags.ResolvableDomain, test.flags.KubeConfig, etc.

@google-prow-robot google-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 28, 2018
@tanzeeb
Copy link
Copy Markdown
Contributor Author

tanzeeb commented Jun 28, 2018

/test pull-knative-serving-integration-tests

@google-prow-robot google-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 28, 2018
bobcatfish
bobcatfish approved these changes Jun 28, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@bobcatfish bobcatfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great @tanzeeb ! :D thanks for refactoring the noodleburg usage too!

/lgtm

Comment thread test/e2e/e2e.go Outdated
Copy link
Copy Markdown
Contributor

@bobcatfish bobcatfish Jun 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one!!

@google-prow-robot google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2018
@google-prow-robot google-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2018
@google-prow-robot
Copy link
Copy Markdown

google-prow-robot commented Jul 3, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobcatfish, tanzeeb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tanzeeb
Copy link
Copy Markdown
Contributor Author

tanzeeb commented Jul 3, 2018

/hold cancel

@google-prow-robot google-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2018
@bobcatfish
Copy link
Copy Markdown
Contributor

bobcatfish commented Jul 3, 2018

/lgtm

@google-prow-robot google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2018
@google-prow-robot google-prow-robot merged commit c4f559a into knative:master Jul 3, 2018
@tanzeeb tanzeeb deleted the e2e-configurable-namespace branch July 3, 2018 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bobcatfish bobcatfish bobcatfish approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bobcatfish bobcatfish

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tanzeeb @google-prow-robot @bobcatfish