Skip to content

Conversation

@knative-automation
Copy link
Contributor

Cron -knative-prow-robot

/cc knative/serving-writers
/assign knative/serving-writers

Produced by: knative-sandbox/knobots/actions/update-deps

@knative-automation knative-automation force-pushed the auto-updates/update-deps-main branch from 0d62bf7 to cf704f8 Compare November 3, 2022 01:39
@knative-prow knative-prow bot requested a review from a team November 3, 2022 01:39
@knative-prow
Copy link

knative-prow bot commented Nov 3, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: knative-automation
Once this PR has been reviewed and has the lgtm label, please assign dsimansk for approval by writing /assign @dsimansk in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 3, 2022
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 86.42% // Head: 86.44% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (c428cf4) compared to base (f9fd5c8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13435      +/-   ##
==========================================
+ Coverage   86.42%   86.44%   +0.02%     
==========================================
  Files         196      196              
  Lines       14560    14560              
==========================================
+ Hits        12584    12587       +3     
+ Misses       1676     1674       -2     
+ Partials      300      299       -1     
Impacted Files Coverage Δ
pkg/reconciler/revision/background.go 90.90% <0.00%> (ø)
pkg/reconciler/configuration/configuration.go 84.36% <0.00%> (+1.42%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nader-ziada
Copy link
Member

/retest

@knative-automation knative-automation force-pushed the auto-updates/update-deps-main branch from cf704f8 to 868447c Compare November 3, 2022 13:26
@psschwei psschwei closed this Nov 3, 2022
@psschwei
Copy link
Member

psschwei commented Nov 3, 2022

close/reopen to rerun the tests

@psschwei psschwei reopened this Nov 3, 2022
@knative-automation knative-automation force-pushed the auto-updates/update-deps-main branch from 868447c to 9d9fd81 Compare November 4, 2022 01:39
@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 4, 2022
@knative-automation knative-automation force-pushed the auto-updates/update-deps-main branch from 9d9fd81 to a4aeace Compare November 4, 2022 13:27
@psschwei psschwei closed this Nov 4, 2022
@psschwei psschwei reopened this Nov 4, 2022
@dprotaso
Copy link
Member

dprotaso commented Nov 4, 2022

there's a legit failure

% ktl logs -n knative-serving controller-f9cb5f7cc-6ggcl
2022/11/04 15:06:40 Registering 5 clients
2022/11/04 15:06:40 Registering 6 informer factories
2022/11/04 15:06:40 Registering 14 informers
2022/11/04 15:06:40 Registering 9 controllers
{"level":"panic","ts":1667574400.5777206,"logger":"fallback","caller":"filtered/filtered_factory.go:51","msg":"Unable to fetch labelkey from context.","stacktrace":"knative.dev/pkg/client/injection/kube/informers/factory/filtered.withInformerFactory\n\tknative.dev/pkg@v0.0.0-20221104013805-918fd9396a31/client/injection/kube/informers/factory/filtered/filtered_factory.go:51\nknative.dev/pkg/injection.(*impl).SetupInformers\n\tknative.dev/pkg@v0.0.0-20221104013805-918fd9396a31/injection/informers.go:110\nknative.dev/pkg/injection.EnableInjectionOrDie\n\tknative.dev/pkg@v0.0.0-20221104013805-918fd9396a31/injection/injection.go:60\nknative.dev/pkg/injection/sharedmain.MainWithConfig\n\tknative.dev/pkg@v0.0.0-20221104013805-918fd9396a31/injection/sharedmain/main.go:244\nknative.dev/pkg/injection/sharedmain.MainWithContext\n\tknative.dev/pkg@v0.0.0-20221104013805-918fd9396a31/injection/sharedmain/main.go:210\nknative.dev/pkg/injection/sharedmain.Main\n\tknative.dev/pkg@v0.0.0-20221104013805-918fd9396a31/injection/sharedmain/main.go:140\nmain.main\n\tknative.dev/serving/cmd/controller/main.go:57\nruntime.main\n\truntime/proc.go:250"}
panic: Unable to fetch labelkey from context.

goroutine 1 [running]:
go.uber.org/zap/zapcore.(*CheckedEntry).Write(0xc0001e0cc0, {0x0, 0x0, 0x0})
	go.uber.org/zap@v1.19.1/zapcore/entry.go:232 +0x44c
go.uber.org/zap.(*SugaredLogger).log(0xc000317520, 0x4, {0x0?, 0x0?}, {0xc00079f968?, 0xc00079f8c8?, 0x40dc07?}, {0x0, 0x0, 0x0})
	go.uber.org/zap@v1.19.1/sugar.go:227 +0xee
go.uber.org/zap.(*SugaredLogger).Panic(...)
	go.uber.org/zap@v1.19.1/sugar.go:123
knative.dev/pkg/client/injection/kube/informers/factory/filtered.withInformerFactory({0x22c8618, 0xc00014f230})
	knative.dev/pkg@v0.0.0-20221104013805-918fd9396a31/client/injection/kube/informers/factory/filtered/filtered_factory.go:51 +0x116
knative.dev/pkg/injection.(*impl).SetupInformers(0x22c91b0?, {0x22c8618, 0xc00013ff80}, 0x325f3e8?)
	knative.dev/pkg@v0.0.0-20221104013805-918fd9396a31/injection/informers.go:110 +0xfc
knative.dev/pkg/injection.EnableInjectionOrDie({0x22c91b0?, 0xc0006369a8?}, 0xc00079fc48?)
	knative.dev/pkg@v0.0.0-20221104013805-918fd9396a31/injection/injection.go:60 +0x11c
knative.dev/pkg/injection/sharedmain.MainWithConfig({0x22c91b0, 0xc0006369a8}, {0x1fafc1b, 0xa}, 0xc000148240, {0x320f700, 0x9, 0x9})
	knative.dev/pkg@v0.0.0-20221104013805-918fd9396a31/injection/sharedmain/main.go:244 +0x27a
knative.dev/pkg/injection/sharedmain.MainWithContext({0x22c91b0, 0xc0006369a8}, {0x1fafc1b, 0xa}, {0x320f700, 0x9, 0x9})
	knative.dev/pkg@v0.0.0-20221104013805-918fd9396a31/injection/sharedmain/main.go:210 +0x1d7
knative.dev/pkg/injection/sharedmain.Main({0x1fafc1b, 0xa}, {0x320f700, 0x9, 0x9})
	knative.dev/pkg@v0.0.0-20221104013805-918fd9396a31/injection/sharedmain/main.go:140 +0x8f
main.main()
	knative.dev/serving/cmd/controller/main.go:57 +0x6d

@dprotaso
Copy link
Member

dprotaso commented Nov 4, 2022

cc @nader-ziada this is probably related to the control protocol changes

@nader-ziada
Copy link
Member

cc @nader-ziada this is probably related to the control protocol changes

yes, looking at it

@knative-automation knative-automation force-pushed the auto-updates/update-deps-main branch 3 times, most recently from eb2d296 to 643416c Compare November 8, 2022 01:40
@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 8, 2022
bumping knative.dev/hack 4b6bd86...8f3c705:
  > 8f3c705 Update community files (# 247)
  > 62b15bd drop support for the istio add on flag (# 243)
  > f5be74f Update community files (# 245)
  > 80fd6da KO_DATA_PATH doesn't need to be set anymore (# 244)
bumping knative.dev/networking e051f4e...0d4e937:
  > 0d4e937 upgrade to latest dependencies (# 731)
  > ed86031 Update community files (# 730)
  > dd3d3d7 Updates style/lint checks for go1.19 (# 733)
  > 7d97614 upgrade to latest dependencies (# 729)
bumping knative.dev/control-protocol 0fde03f...1b58faf:
  > 1b58faf upgrade to latest dependencies (# 230)
  > b12acb3 Use the correct certificte reconciler (# 231)
  > b8842c8 Update community files (# 229)
  > f14c6da bump k8s versions used by e2e (# 227)
  > 1aca08d Update community files (# 228)
  > f232ced upgrade to latest dependencies (# 226)
  > ed5e550 Certificate controller to only watch secrets with a label (# 225)
bumping knative.dev/caching 0bce38a...30a02f9:
  > 30a02f9 upgrade to latest dependencies (# 700)
  > 9c80f15 Update community files (# 699)
  > 4bdea94 Update linting/style for go1.19 (# 701)
  > dc4417e upgrade to latest dependencies (# 698)
bumping knative.dev/pkg 8fa1a3f...0243d64:
  > 0243d64 Function AllowRestrictedPodSecurityStandard for modifying test pods (# 2625)
  > 389f811 upgrade to latest dependencies (# 2629)
  > 918fd93 Update community files (# 2633)
  > 44d1d7d Go1.19 changes (# 2631)
  > 6718478 Update community files (# 2628)
  > dc1fae1 changeset: allow override the revision through ldflags (# 2601)
  > 92ed919 Fix: Mute the linter on error return values. (# 2627)

Signed-off-by: Knative Automation <automation@knative.team>
@knative-automation knative-automation force-pushed the auto-updates/update-deps-main branch from 643416c to c428cf4 Compare November 8, 2022 13:24
@knative-prow
Copy link

knative-prow bot commented Nov 8, 2022

@knative-automation: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
istio-latest-no-mesh_serving_main c428cf4 link true /test istio-latest-no-mesh
istio-latest-no-mesh-tls_serving_main c428cf4 link true /test istio-latest-no-mesh-tls
upgrade-tests_serving_main c428cf4 link true /test upgrade-tests

Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nader-ziada
Copy link
Member

/close

replaced by #13442

@knative-prow knative-prow bot closed this Nov 8, 2022
@knative-prow
Copy link

knative-prow bot commented Nov 8, 2022

@nader-ziada: Closed this PR.

Details

In response to this:

/close

replaced by #13442

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants