-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Set filtered factory label in controller main + Upgrade to latest dependencies #13442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 86.44% // Head: 86.39% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #13442 +/- ##
==========================================
- Coverage 86.44% 86.39% -0.06%
==========================================
Files 196 196
Lines 14560 14562 +2
==========================================
- Hits 12587 12581 -6
- Misses 1674 1679 +5
- Partials 299 302 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@dprotaso fixed the controller by adding the labelkey there, but still not sure why the |
|
This is the error in activator |
|
/retest |
| namespace: knative-serving | ||
| labels: | ||
| serving-certs-ctrl: "data-plane" | ||
| networking.internal.knative.dev/certificate-uid: "serving-certs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, for future reference two things need patching due to filtering, this secret since internal encryption relies on control-protocol and test/e2e/domainmapping/domain_mapping_test.go if we enable filtering on net-{kourier, istio}.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skonto just to confirm, domain mapping doesn't need to be updated for this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it does not for now, it only appeared to fail if net-kourier filtering was enabled.
|
updated with latest dependencies from #13435 so we can close the other one and use this PR instead |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, nader-ziada The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Proposed Changes