Skip to content

Conversation

@nader-ziada
Copy link
Member

Proposed Changes

  • set filtered factory label in controller main

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/API API objects and controllers size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 4, 2022
@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Base: 86.44% // Head: 86.39% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (e6c326a) compared to base (09f44f5).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13442      +/-   ##
==========================================
- Coverage   86.44%   86.39%   -0.06%     
==========================================
  Files         196      196              
  Lines       14560    14562       +2     
==========================================
- Hits        12587    12581       -6     
- Misses       1674     1679       +5     
- Partials      299      302       +3     
Impacted Files Coverage Δ
cmd/controller/main.go 0.00% <0.00%> (ø)
pkg/autoscaler/statserver/server.go 73.72% <0.00%> (-2.19%) ⬇️
pkg/autoscaler/statforwarder/leases.go 72.39% <0.00%> (-1.57%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 4, 2022
@nader-ziada
Copy link
Member Author

@dprotaso fixed the controller by adding the labelkey there, but still not sure why the tls case is not working

@nader-ziada
Copy link
Member Author

This is the error in activator

{"severity":"EMERGENCY","timestamp":"2022-11-04T21:14:11.973699812Z","logger":"activator","caller":"activator/main.go:183","message":"Failed to append ca cert to the RootCAs","commit":"58421b6-dirty","knative.dev/controller":"activator","knative.dev/pod":"activator-7c97846c85-zgmqc","stacktrace":"main.main\n\tknative.dev/serving/cmd/activator/main.go:183\nruntime.main\n\truntime/proc.go:250"}

@nader-ziada
Copy link
Member Author

/retest

@nader-ziada
Copy link
Member Author

This PR fixes the issues caused by the changes in control-protocol , instead of #13435

@dprotaso @psschwei

@nader-ziada nader-ziada changed the title [WIP] Set filtered factory label in controller main Set filtered factory label in controller main Nov 6, 2022
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 6, 2022
namespace: knative-serving
labels:
serving-certs-ctrl: "data-plane"
networking.internal.knative.dev/certificate-uid: "serving-certs"
Copy link
Contributor

@skonto skonto Nov 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, for future reference two things need patching due to filtering, this secret since internal encryption relies on control-protocol and test/e2e/domainmapping/domain_mapping_test.go if we enable filtering on net-{kourier, istio}.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skonto just to confirm, domain mapping doesn't need to be updated for this PR?

Copy link
Contributor

@skonto skonto Nov 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it does not for now, it only appeared to fail if net-kourier filtering was enabled.

@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 8, 2022
@nader-ziada nader-ziada changed the title Set filtered factory label in controller main Set filtered factory label in controller main + Upgrade to latest dependencies Nov 8, 2022
@nader-ziada
Copy link
Member Author

updated with latest dependencies from #13435 so we can close the other one and use this PR instead

@dprotaso
Copy link
Member

dprotaso commented Nov 8, 2022

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2022
@knative-prow
Copy link

knative-prow bot commented Nov 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, nader-ziada

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants