[release-1.5] Scaling to zero now works when target-burst-capacity is zero. #13506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The autoscaler sends a probe to detect the activator is in the data path. This probe was inadvertently passed to the user container which was preventing scale to 0.
knative-prow
bot
added
area/API
Codecov ReportBase: 87.05% // Head: 86.98% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## release-1.5 #13506 +/- ##
===============================================
- Coverage 87.05% 86.98% -0.07%
===============================================
Files 197 197
Lines 14441 14441
===============================================
- Hits 12571 12562 -9
- Misses 1577 1584 +7
- Partials 293 295 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, knative-prow-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
nak3
pushed a commit
to nak3/serving
that referenced
this pull request
Nov 29, 2022
knative#13506) The autoscaler sends a probe to detect the activator is in the data path. This probe was inadvertently passed to the user container which was preventing scale to 0. Co-authored-by: dprotaso <dprotaso@gmail.com>
openshift-merge-robot
pushed a commit
to openshift-knative/serving
that referenced
this pull request
Nov 30, 2022
…e user-container (knative#13506) (#46) * Ensure probes from the autoscaler are not passed to the user-container (knative#13506) The autoscaler sends a probe to detect the activator is in the data path. This probe was inadvertently passed to the user container which was preventing scale to 0. Co-authored-by: dprotaso <dprotaso@gmail.com> * Pin to 1.26 branch Co-authored-by: Knative Prow Robot <knative-prow-robot@google.com> Co-authored-by: dprotaso <dprotaso@gmail.com>
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/knative-serving
that referenced
this pull request
Nov 30, 2022
knative#13506) The autoscaler sends a probe to detect the activator is in the data path. This probe was inadvertently passed to the user container which was preventing scale to 0. Co-authored-by: dprotaso <dprotaso@gmail.com>
openshift-merge-robot
pushed a commit
to openshift-knative/serving
that referenced
this pull request
Nov 30, 2022
…ot passed to the user-container (knative#13506) (#48) * Ensure probes from the autoscaler are not passed to the user-container (knative#13506) The autoscaler sends a probe to detect the activator is in the data path. This probe was inadvertently passed to the user container which was preventing scale to 0. Co-authored-by: dprotaso <dprotaso@gmail.com> * Pin to 1.26 branch Co-authored-by: Knative Prow Robot <knative-prow-robot@google.com> Co-authored-by: dprotaso <dprotaso@gmail.com> Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #13501