-
Notifications
You must be signed in to change notification settings - Fork 8
[RELEASE-v1.5] Ensure probes from the autoscaler are not passed to the user-container (#13506) #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RELEASE-v1.5] Ensure probes from the autoscaler are not passed to the user-container (#13506) #46
Conversation
knative#13506) The autoscaler sends a probe to detect the activator is in the data path. This probe was inadvertently passed to the user container which was preventing scale to 0. Co-authored-by: dprotaso <dprotaso@gmail.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nak3, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thank you! Let's cherry-pick on the other branches too. |
|
/hold cancel |
|
/cherry-pick release-v1.7 |
|
@nak3: once the present PR merges, I will cherry-pick it on top of release-v1.7 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-v1.6 |
|
@nak3: once the present PR merges, I will cherry-pick it on top of release-v1.6 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-v1.8 |
|
@nak3: once the present PR merges, I will cherry-pick it on top of release-v1.8 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@nak3: #46 failed to apply on top of branch "release-v1.7": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@nak3: new pull request created: #48 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@nak3: #46 failed to apply on top of branch "release-v1.8": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Cherry-pick of knative@92f942c
/cc @skonto