Allow in-cluster connections to a route's service#1423
Allow in-cluster connections to a route's service#1423scothis wants to merge 1 commit intoknative:masterfrom scothis:incluster-service
Conversation
- remove the `ClusterIP: "None"` from the route's service so that the
service will be resolvable.
- add service shortnames `{name}` and `{name}.{namespace}` to the
route's virtual service.
In testing, accessing the service via the fqdn
(`{name}.{ns}.svc.cluster.local`) works, but the short names do not.
Adding them here since it shouldn't cause issues and may be an Istio
issue we can resolve.
Refs #1415
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: scothis Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
google-prow-robot
added
the
size/M
|
/test pull-knative-serving-integration-tests |
|
@scothis: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| Name: "http", | ||
| Port: 80, | ||
| }}, | ||
| ClusterIP: "None", |
| }, { | ||
| Authority: &v1alpha3.StringMatch{Exact: "test-route-service.test-ns.svc.cluster.local"}, | ||
| }, { | ||
| Authority: &v1alpha3.StringMatch{Exact: "test-route-service.test-ns"}, |
There was a problem hiding this comment.
I filed #1429 to track the short names.
For now I think it may be best that we leave them out to avoid confusions.
|
I submitted #1431 as discussed. Closing this. |
3 participants
ClusterIP: "None"from the route's service so that the service will be resolvable.{name}and{name}.{namespace}to the route's virtual service.In testing, accessing the service via the fqdn (
{name}.{ns}.svc.cluster.local) works, but the short names do not. Adding them here since it shouldn't cause issues and may be an Istio issue we can resolve.Refs #1415
Release Note
/assign @tcnghia