Remove ClusterIP=None specification in Route's service#1431
Merged
google-prow-robot merged 1 commit intoknative:masterfrom Jun 30, 2018
Merged
Remove ClusterIP=None specification in Route's service#1431google-prow-robot merged 1 commit intoknative:masterfrom
google-prow-robot merged 1 commit intoknative:masterfrom
Conversation
google-prow-robot
added
size/XS
tcnghia
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, tcnghia The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cardil
pushed a commit
to cardil/knative-serving
that referenced
this pull request
Oct 16, 2025
…nces/release-v1.15 Update Konflux references
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1228 we allowed the usage of cluster local domain name, but we incorrectly specified "ClusterIP: None" for the route's placeholder service. Thanks @scothis for noticing. @scothis opened PR #1423, but he's on vacation so I talked to him to replace it with this PR instead.