Skip to content

[PoC] Use builders to make table tests more readable #1762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dprotaso wants to merge 2 commits into from
Closed

[PoC] Use builders to make table tests more readable #1762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b784ac
wip
dprotaso Jul 30, 2018
3f95d25
Further abstraction
dprotaso Jul 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions pkg/controller/configuration/configuration.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,6 @@ func (c *Controller) reconcile(ctx context.Context, config *v1alpha1.Configurati
func (c *Controller) createRevision(config *v1alpha1.Configuration, revName string) (*v1alpha1.Revision, error) {
logger := loggerWithConfigInfo(c.Logger, config.Namespace, config.Name)

buildName := ""
if config.Spec.Build != nil {
// TODO(mattmoor): Determine whether we reuse the previous build.
build := resources.MakeBuild(config)
Expand All @@ -212,10 +211,9 @@ func (c *Controller) createRevision(config *v1alpha1.Configuration, revName stri
}
logger.Infof("Created Build:\n%+v", created.Name)
c.Recorder.Eventf(config, corev1.EventTypeNormal, "Created", "Created Build %q", created.Name)
buildName = created.Name
}

rev := resources.MakeRevision(config, buildName)
rev := resources.MakeRevision(config)
Copy link
Copy Markdown
Member

@mattmoor mattmoor Aug 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this part of the change is a separable distraction from the test change. Want to send a separate PR?

Copy link
Copy Markdown
Member Author

@dprotaso dprotaso Aug 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

Copy link
Copy Markdown
Member Author

@dprotaso dprotaso Aug 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1793

created, err := c.ServingClientSet.ServingV1alpha1().Revisions(config.Namespace).Create(rev)
if err != nil {
return nil, err
Expand Down
Loading