fix log format in activator#2083
Merged
knative-prow-robot merged 1 commit intoknative:masterfrom Sep 27, 2018
Merged
Conversation
knative-prow-robot
added
size/XS
Member
|
/ok-to-test |
knative-prow-robot
removed
the
needs-ok-to-test
mdemirhan
suggested changes
Sep 27, 2018
| servingClient, err := clientset.NewForConfig(clusterConfig) | ||
| if err != nil { | ||
| logger.Fatal("Error building serving clientset: %v", zap.Error(err)) | ||
| logger.Fatalf("Error building serving clientset: %v", zap.Error(err)) |
Contributor
There was a problem hiding this comment.
Thanks for catching this. I believe the right fix should be:
logger.Fatal("Error building serving clientset", zap.Error(err))
(removal of %v)
| promExporter, err := prometheus.NewExporter(prometheus.Options{Namespace: "activator"}) | ||
| if err != nil { | ||
| logger.Fatal("Failed to create the Prometheus exporter: %v", zap.Error(err)) | ||
| logger.Fatalf("Failed to create the Prometheus exporter: %v", zap.Error(err)) |
| reporter, err := activator.NewStatsReporter() | ||
| if err != nil { | ||
| logger.Fatal("Failed to create stats reporter: %v", zap.Error(err)) | ||
| logger.Fatalf("Failed to create stats reporter: %v", zap.Error(err)) |
lichuqiang
force-pushed
the
cleanup1
branch
from
a6f7735 to
763970d
Compare
mdemirhan
approved these changes
Sep 27, 2018
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lichuqiang, mdemirhan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
nit: When walking through the code, I noticed some of the log in activator are not correctly formatted.
/assign @mattmoor
Release Note