Add mdemirhan to /OWNERS#2264
Conversation
|
/lgtm |
|
@tcnghia nit: can you break the unrelated |
My interpretation of this process is that the lead nomination is pertinent to adding a person to that WG's area of ownership (e.g. via OWNERS_ALIASES), and generally the justification PRs should be scoped to that area. This PR touches on a bit of a gray area since this repo straddles a half dozen WGs, and so we've historically left a couple directories very restricted (to basically the TOC). The two that come to mind are the "public API" ( Given that @mdemirhan is already in a majority of the approver groups (and I'd consider him for at least one more), I'd be receptive to expanding this group and lightening our review load (I'm looking at you I'll put this on the agenda for the TOC meeting Thursday. |
|
/lgtm You can see some commentary on the decision here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, tcnghia The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
From https://github.com/knative/docs/blob/master/community/ROLES.md#approver
Reviewer of the codebase for at least 3 months or 50% of project lifetime, whichever is shorter
Primary reviewer for at least 10 substantial PRs to the codebase
Reviewed or merged at least 30 PRs to the codebase: Authored 56 PRs in serving.
Nominated by an area lead: Nominated by Networking WG Lead.