Skip to content

Add mdemirhan to /OWNERS#2264

Merged
knative-prow-robot merged 1 commit intoknative:masterfrom
tcnghia:random
Oct 25, 2018
Merged

Add mdemirhan to /OWNERS#2264
knative-prow-robot merged 1 commit intoknative:masterfrom
tcnghia:random

Conversation

@tcnghia
Copy link
Copy Markdown
Contributor

@tcnghia tcnghia commented Oct 19, 2018

@tcnghia tcnghia requested a review from vaikas October 19, 2018 14:49
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 19, 2018
@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Oct 19, 2018

/lgtm

@evankanderson

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2018
@mattmoor
Copy link
Copy Markdown
Member

@tcnghia nit: can you break the unrelated ./cmd/webhook file into its own PR?

@tcnghia tcnghia changed the title Add mdemirhan to /OWNERS. Copy cmd/controller/OWNERS to cmd/webhook. Add mdemirhan to /OWNERS Oct 22, 2018
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2018
@mattmoor
Copy link
Copy Markdown
Member

Nominated by an area lead: Nominated by Networking WG Lead.

My interpretation of this process is that the lead nomination is pertinent to adding a person to that WG's area of ownership (e.g. via OWNERS_ALIASES), and generally the justification PRs should be scoped to that area.

This PR touches on a bit of a gray area since this repo straddles a half dozen WGs, and so we've historically left a couple directories very restricted (to basically the TOC). The two that come to mind are the "public API" (pkg/apis/serving) and the root directory.

Given that @mdemirhan is already in a majority of the approver groups (and I'd consider him for at least one more), I'd be receptive to expanding this group and lightening our review load (I'm looking at you Gopkg.toml!).

I'll put this on the agenda for the TOC meeting Thursday.

@mattmoor
Copy link
Copy Markdown
Member

/lgtm
/approve

You can see some commentary on the decision here.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2018
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, tcnghia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2018
@knative-prow-robot knative-prow-robot merged commit 8d875c6 into knative:master Oct 25, 2018
markusthoemmes pushed a commit to openshift/knative-serving that referenced this pull request Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants