Autoscaler metrics and performance investigation guide#789
Autoscaler metrics and performance investigation guide#789mdemirhan merged 7 commits intoknative:masterfrom mdemirhan:perfdash
Conversation
mdemirhan
requested review from
evankanderson,
grantr and
vaikas
as code owners
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mdemirhan Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
google-prow-robot
added
the
size/XL
mdemirhan
changed the title
|
|
||
| elaRevision = os.Getenv("ELA_REVISION") | ||
| if elaDeployment == "" { | ||
| if elaRevision == "" { |
|
|
||
| This dashboard gives visibility into: | ||
| * Request volume per revision | ||
| * Request volume per HTTP response code |
There was a problem hiding this comment.
What about "Request volume per revision and HTTP response code"? I would expect all the dashboards to be scoped to a single revision. Or at least be able to.
There was a problem hiding this comment.
Yes, that is correct. I will reword that part to clarify.
| * Request and response sizes per revision | ||
|
|
||
| This dashboard can show traffic volume or latency discrepancies between different revisions. | ||
| If, for example, a revision's latency is higher than others', |
There was a problem hiding this comment.
Nit: "...is higher than other revisions, then focus..."
| ## Auto scaler metrics | ||
| If request metrics or traces do not show any obvious hot spots, or if they show | ||
| that most of the time is spent in your own code, auto scaler metrics should be | ||
| looked next. To open auto scaler dashboard, open Grafana UI and select |
There was a problem hiding this comment.
Nit: "autoscaler" (no space)
There was a problem hiding this comment.
Will fix all. Thanks!
| Grafana URL is taking the most time and investigation should focus on why | ||
| that URL is taking that long. | ||
|
|
||
| ## Auto scaler metrics |
There was a problem hiding this comment.
You should mention the panic metric I think.
|
/lgtm |
|
/retest |
5 participants
Fixes #578 and #493
Proposed Changes