Pull in support for non-terminal conditions#2436
Pull in support for non-terminal conditions#2436knative-prow-robot merged 1 commit intoknative:masterfrom
Conversation
knative-prow-robot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
knative-prow-robot
requested review from
dprotaso,
imjasonh,
lichuqiang and
tcnghia
knative-prow-robot
added
the
size/XXL
knative-prow-robot
left a comment
knative-prow-robot
left a comment
There was a problem hiding this comment.
@mattmoor: 0 warnings.
Details
In response to this:
This pulls in the support for non-terminal conditions, which includes a new
Severityfield (as discussed in the API WG meeting).This is WIP until it actually pulls in a merged version of the
knative/pkgcommit (vs. my PR)
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
/retest |
mattmoor
force-pushed
the
pkg-with-severity
branch
from
454b22b to
09d61c4
Compare
mattmoor
changed the title
knative-prow-robot
removed
the
do-not-merge/work-in-progress
lichuqiang
left a comment
lichuqiang
left a comment
There was a problem hiding this comment.
Thanks! Have been longing for the change.
| Status: corev1.ConditionTrue, | ||
| Type: v1alpha1.ClusterIngressConditionLoadBalancerReady, | ||
| Status: corev1.ConditionTrue, | ||
| Severity: "Error", |
There was a problem hiding this comment.
To avoid modifying things everywhere, can we have a Conditions wrapper in test, that default the Severity to "Error" if not specified?
There was a problem hiding this comment.
I debated adding Severity to the set of things ignored in the base table test (currently: LastTransitionTime), but we still need to provide this to our inputs or we'll get hard to decode "unexpected update" errors that seemingly match what we passed in.
It is clear that we need to refactor these table tests so there is less churn, but I don't want to block knative/pkg updates waiting on that. I'll play with this tomorrow.
There was a problem hiding this comment.
but I don't want to block knative/pkg updates waiting on that. I'll play with this tomorrow.
I'm fine with this
mattmoor
force-pushed
the
pkg-with-severity
branch
from
09d61c4 to
42a4fd3
Compare
|
/lgtm |
|
/test pull-knative-serving-integration-tests |
2 similar comments
|
/test pull-knative-serving-integration-tests |
|
/test pull-knative-serving-integration-tests |
|
/test pull-knative-serving-integration-tests |
4 participants
This pulls in the support for non-terminal conditions, which includes a new
Severityfield (as discussed in the API WG meeting).This is WIP until it actually pulls in a merged version of the
knative/pkgcommit (vs. my PR)