Simplify some of the object construction in Revision controller.#2446
Merged
knative-prow-robot merged 1 commit intoknative:masterfrom Nov 9, 2018
Merged
Conversation
knative-prow-robot
added
the
do-not-merge/work-in-progress
knative-prow-robot
added
size/XXL
Member
Author
|
/test pull-knative-serving-integration-tests |
An initial cleanup while looking into: knative#2442
mattmoor
force-pushed
the
cleanup-resource-ctors
branch
from
d4590ca to
897aa44
Compare
knative-prow-robot
added
size/L
mattmoor
changed the title
knative-prow-robot
removed
the
do-not-merge/work-in-progress
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonjohnsonjr, mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mattmoor
added a commit
to mattmoor/serving
that referenced
this pull request
Nov 14, 2018
…tive#2446) An initial cleanup while looking into: knative#2442
mattmoor
added a commit
to mattmoor/serving
that referenced
this pull request
Nov 14, 2018
…tive#2446) An initial cleanup while looking into: knative#2442
mattmoor
added a commit
to mattmoor/serving
that referenced
this pull request
Nov 14, 2018
…tive#2446) An initial cleanup while looking into: knative#2442
mattmoor
added a commit
to mattmoor/serving
that referenced
this pull request
Nov 15, 2018
…tive#2446) An initial cleanup while looking into: knative#2442
mattmoor
added a commit
to mattmoor/serving
that referenced
this pull request
Nov 15, 2018
…tive#2446) An initial cleanup while looking into: knative#2442
mattmoor
added a commit
to mattmoor/serving
that referenced
this pull request
Nov 15, 2018
…tive#2446) An initial cleanup while looking into: knative#2442
mattmoor
added a commit
to mattmoor/serving
that referenced
this pull request
Nov 15, 2018
…tive#2446) An initial cleanup while looking into: knative#2442
mattmoor
added a commit
to mattmoor/serving
that referenced
this pull request
Nov 15, 2018
…tive#2446) An initial cleanup while looking into: knative#2442
mattmoor
added a commit
to mattmoor/serving
that referenced
this pull request
Nov 15, 2018
…tive#2446) An initial cleanup while looking into: knative#2442
mattmoor
added a commit
to mattmoor/serving
that referenced
this pull request
Nov 16, 2018
…tive#2446) An initial cleanup while looking into: knative#2442
mattmoor
added a commit
to mattmoor/serving
that referenced
this pull request
Nov 16, 2018
…tive#2446) An initial cleanup while looking into: knative#2442
knative-prow-robot
pushed a commit
that referenced
this pull request
Nov 16, 2018
…oilerplate. (#2447) * Refactor the Service following #2447 This starts to factor out functional options for setting up our table tests, which reduces the verbosity a fair amount. I've broken off Service from a broader set of changes in #2447 to make things a bit more manageable to review. * Simplify some of the object construction in Revision controller. (#2446) An initial cleanup while looking into: #2442
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An initial cleanup while looking into: #2442
WIP until: #2436 merges (for my own sanity)