Skip to content

compile-time assert numControllers == len(controllersArray)#3923

Closed
syedriko wants to merge 2 commits into
knative:masterfrom
syedriko:compile-time-assert
Closed

compile-time assert numControllers == len(controllersArray)#3923
syedriko wants to merge 2 commits into
knative:masterfrom
syedriko:compile-time-assert

Conversation

@syedriko
Copy link
Copy Markdown
Contributor

Replace a runtime check with a compile-time assert in controller mainline
Sister PR in eventing knative/eventing#1112

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 27, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: syedriko
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: vagababov

If they are not already assigned, you can assign the PR to them by writing /assign @vagababov in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 27, 2019
@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 27, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

Hi @syedriko. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@syedriko
Copy link
Copy Markdown
Contributor Author

/cc @vagababov

@syedriko syedriko closed this Apr 27, 2019
@syedriko syedriko deleted the compile-time-assert branch April 27, 2019 17:09
@syedriko syedriko restored the compile-time-assert branch April 27, 2019 17:10
@syedriko syedriko deleted the compile-time-assert branch April 27, 2019 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/API API objects and controllers cla: yes Indicates the PR's author has signed the CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants