Skip to content

compile-time assert numControllers == len(controllersArray) #3923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
syedriko wants to merge 2 commits into from
Closed

compile-time assert numControllers == len(controllersArray) #3923

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09134c8
compile-time assert numControllers == len(controllersArray)
syedriko Apr 27, 2019
8b5cb66
Merge branch 'master' into compile-time-assert
syedriko Apr 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cmd/controller/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ func main() {

// Build all of our controllers, with the clients constructed above.
// Add new controllers to this array.
controllers := []*controller.Impl{
controllersArray := [...]*controller.Impl{
configuration.NewController(
opt,
configurationInformer,
Expand Down Expand Up @@ -147,9 +147,9 @@ func main() {
endpointsInformer,
),
}
if len(controllers) != numControllers {
logger.Fatalf("Number of controllers and QPS settings mismatch: %d != %d", len(controllers), numControllers)
}
controllers := controllersArray[:]
// compile-time assert numControllers == len(controllersArray)
var _ [numControllers - len(controllersArray)][len(controllersArray) - numControllers]int

// Watch the logging config map and dynamically update logging levels.
opt.ConfigMapWatcher.Watch(logging.ConfigMapName(), logging.UpdateLevelFromConfigMap(logger, atomicLevel, component))
Expand Down