Propagate ImagePullBackoff#4195
Merged
knative-prow-robot merged 2 commits intoknative:masterfrom Jun 12, 2019
Merged
Conversation
knative-prow-robot
added
the
do-not-merge/work-in-progress
knative-prow-robot
added
the
size/M
jonjohnsonjr
force-pushed
the
errimagepull
branch
2 times, most recently
from
e4303c1 to
707e151
Compare
knative-prow-robot
added
size/L
jonjohnsonjr
force-pushed
the
errimagepull
branch
6 times, most recently
from
c682039 to
5dd3030
Compare
jonjohnsonjr
force-pushed
the
errimagepull
branch
from
5dd3030 to
91b6ac4
Compare
knative-prow-robot
removed
the
do-not-merge/work-in-progress
Contributor
Author
|
/assign @mattmoor |
mattmoor
reviewed
Jun 11, 2019
|
The following is the coverage report on pkg/.
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonjohnsonjr, mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4192
If a revision's user container is stuck in state "waiting", and the deployment has timed out progressing, this will surface the Reason and Message via the
ResourcesAvailablecondition. This ensures that stuck containers (e.g. for image pull issues) eventually surface an error, such that it gets propagated up to configuration and ksvc.