Add LatestRevisionReady condition in Configuration#568
Add LatestRevisionReady condition in Configuration#568google-prow-robot merged 1 commit intoknative:masterfrom johnugeorge:master
Conversation
johnugeorge
requested review from
evankanderson,
mattmoor and
vaikas
as code owners
google-prow-robot
added
the
size/L
|
/assign evankanderson |
evankanderson
left a comment
evankanderson
left a comment
There was a problem hiding this comment.
Looks good. Thanks for adding this!
| } | ||
| c.recorder.Eventf(config, corev1.EventTypeNormal, "LatestReadyUpdate", | ||
| "LatestReadyRevisionName updated to %q", revision.Name) | ||
| } else { |
There was a problem hiding this comment.
At some point, we'll need to change line 390 above to allow a revision between the current LatestReady and the LatestCreated to become the new LatestReady.
I don't think you have to solve that in this PR, though.
| func getLatestRevisionStatusCondition(revision *v1alpha1.Revision) *v1alpha1.RevisionCondition { | ||
| for _, cond := range revision.Status.Conditions { | ||
| if !(cond.Type == v1alpha1.RevisionConditionReady && cond.Status == corev1.ConditionTrue) { | ||
|
|
| Conditions: []v1alpha1.RevisionCondition{{ | ||
| Type: v1alpha1.RevisionConditionReady, | ||
| Status: corev1.ConditionFalse, | ||
| Reason: "Build Failed", |
There was a problem hiding this comment.
"BuildFailed" (reason is supposed to be a single CamelCase word).
| v1alpha1.ConfigurationCondition{ | ||
| Type: v1alpha1.ConfigurationConditionLatestRevisionReady, | ||
| Status: corev1.ConditionFalse, | ||
| Reason: "Build Failed", |
There was a problem hiding this comment.
"BuildFailed" here as well.
|
(Ping this when updated, since Prow will start merging once there's an lgtm + approve) |
Fixes #494 Adds LatestRevisionReady type in Configuration that provides the status of the latest created revision when it is not ready.
|
@evankanderson updated. Please have a look |
|
/approved |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evankanderson, johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-prow-robot
added
the
approved
* Add multi-container image directories * Fix makefile * Fix makefile to build multicontainer images * Use maxdepth 2 * Do not use maxdepth
3 participants
Adds LatestRevisionReady type in Configuration that provides the
status of the latest created revision when it is not ready.