Update spec to move configurationGeneration to annotations#580
Merged
grantr merged 1 commit intoknative:masterfrom Apr 4, 2018
Merged
Update spec to move configurationGeneration to annotations#580grantr merged 1 commit intoknative:masterfrom
grantr merged 1 commit intoknative:masterfrom
Conversation
…s an annotation. Thanks to @johnugeorge for the catch on #458
google-prow-robot
added
approved
grantr
approved these changes
Apr 3, 2018
Contributor
grantr
left a comment
grantr
left a comment
There was a problem hiding this comment.
LGTM.
I'm not aware of all the implications of making this an annotation versus a label. I presume annotations can't be used to filter results like labels can. Anything else?
Contributor
|
LGTM |
Member
Author
|
That's the entire difference:
https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/
Labels can be used to select objects and to find collections of objects
that satisfy certain conditions. In contrast, annotations are not used to
identify and select objects.
Here are some examples of information that could be recorded in
annotations:
* Build, release, or image information like timestamps, release IDs, git
branch, PR numbers, image hashes, and registry address
… * Lightweight rollout tool metadata: for example, config or checkpoints
On Tue, Apr 3, 2018 at 4:42 PM Grant Rodgers ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM.
I'm not aware of all the implications of making this an annotation versus
a label. I presume annotations can't be used to filter results like labels
can. Anything else?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#580 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHlyN2S28U49AEBCq4mTeXgi7HmqkqCjks5tlAj5gaJpZM4TF8fb>
.
--
Evan Anderson <argent@google.com>
|
Contributor
|
Oops, forgot to use the command /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evankanderson, grantr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nak3
added a commit
to nak3/serving
that referenced
this pull request
Nov 12, 2020
* Add feature tests * Fix tag-header-based routing
ReToCode
added a commit
to ReToCode/serving
that referenced
this pull request
Jan 9, 2024
* [release-1.11] fix securityContext for Knative Service Pod (user-container and queue-proxy) (knative#14378) * add seccompProfile to queue container security context * run as non root by default * update tests to expect new default run as nonroot --------- Co-authored-by: Clay Kauzlaric <ckauzlaric@vmware.com> * Leave a comment which will trigger a new dot release (knative#14500) * [release-1.11] bump x/net to v0.17 (knative#14516) * [release-1.11] bump x/net to v1.17 * Re-generate test/config/tls/cert-secret.yaml (knative#14324) * Run hack/update-codegen.sh --upgrade --release 1.11 * Bound buffer for reading stats (knative#14542) Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com> * upgrade to latest dependencies (knative#14552) bumping knative.dev/pkg bd99f2f...56bfe0d: > 56bfe0d [release-1.11] [CVE-2023-44487] Disable http2 for webhooks (# 2875) bumping knative.dev/caching 24ff723...ee89f75: > ee89f75 upgrade to latest dependencies (# 797) Signed-off-by: Knative Automation <automation@knative.team> * Upgrade grpc for addressing GHSA-m425-mq94-257g (knative#14579) More info at GHSA-m425-mq94-257g * remove duplicate 'additionalPrinterColumns' (knative#14654) Signed-off-by: Kenny Leung <kleung@chainguard.dev> Co-authored-by: Kenny Leung <kleung@chainguard.dev> * [release-1.11] Bump to fix knative#14732 (knative#14734) * Bump to fix knative#14732 * Bump to fix serving/knative#14732 * Sync with upstream release-1.11 --------- Signed-off-by: Knative Automation <automation@knative.team> Signed-off-by: Kenny Leung <kleung@chainguard.dev> Co-authored-by: Knative Prow Robot <automation+prow-robot@knative.team> Co-authored-by: Clay Kauzlaric <ckauzlaric@vmware.com> Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com> Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com> Co-authored-by: Knative Automation <automation@knative.team> Co-authored-by: Juan Sanin <jsanin@vmware.com> Co-authored-by: Kenny Leung <kleung@chainguard.dev> Co-authored-by: Dave Protasowski <dprotaso@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct spec to document that
elafros.dev/configurationGenerationis an annotation. Thanks to @johnugeorge for the catch on #458./assign johnugeorge
/assign grantr