Skip to content

Update spec to move configurationGeneration to annotations #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grantr merged 1 commit into from
Apr 4, 2018
Merged

Update spec to move configurationGeneration to annotations #580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/spec/normative_examples.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ metadata:
name: def
labels:
elafros.dev/configuration: my-service
annotations:
elafros.dev/configurationGeneration: 1235
...
spec:
Expand Down Expand Up @@ -322,6 +323,7 @@ metadata:
labels:
# name and generation of the configuration that created the revision
elafros.dev/configuration: my-service
annotations:
elafros.dev/configurationGeneration: 1234
... # uid, resourceVersion, creationTimestamp, generation, selfLink, etc
spec:
Expand Down Expand Up @@ -791,6 +793,7 @@ metadata:
name: abc
labels:
elafros.dev/configuration: my-service
annotations:
elafros.dev/configurationGeneration: 1234
...
spec:
Expand Down
3 changes: 2 additions & 1 deletion docs/spec/spec.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,8 +209,9 @@ metadata:
namespace: default
labels:
elafros.dev/configuration: ... # to list configurations/revisions by service
elafros.dev/configurationGeneration: ... # generation of configuration that created this Revision
elafros.dev/type: "function" # convention, one of "function" or "app"
annotations:
elafros.dev/configurationGeneration: ... # generation of configuration that created this Revision
# system generated meta
uid: ...
  resourceVersion: ... # used for optimistic concurrency control
Expand Down