Skip to content

Set timeout for ingress prober#6465

Merged
knative-prow-robot merged 1 commit intoknative:masterfrom
MIBc:probe-timeout
Jan 9, 2020
Merged

Set timeout for ingress prober#6465
knative-prow-robot merged 1 commit intoknative:masterfrom
MIBc:probe-timeout

Conversation

@MIBc
Copy link
Copy Markdown
Contributor

@MIBc MIBc commented Jan 8, 2020 •
edited
Loading

Fixes #6407

Proposed Changes

  • Set timeout for dialContext.
  • Remove unused variable.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 8, 2020
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/networking labels Jan 8, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jan 8, 2020

Hi @MIBc. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 8, 2020
vagababov
vagababov reviewed Jan 8, 2020
View reviewed changes
Comment thread pkg/network/status/status.go Outdated

// TODO(https://github.com/knative/serving/issues/6407): Default timeouts may lead to hanging probes.
var dialContext = (&net.Dialer{}).DialContext
var dialContext = (&net.Dialer{Timeout: 5 * time.Second}).DialContext
Copy link
Copy Markdown
Contributor

@vagababov vagababov Jan 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 5s is a bit high. I'd limit to 1s, probably

Copy link
Copy Markdown
Contributor Author

@MIBc MIBc Jan 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@tcnghia
Copy link
Copy Markdown
Contributor

tcnghia commented Jan 9, 2020

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 9, 2020
@tcnghia
Copy link
Copy Markdown
Contributor

tcnghia commented Jan 9, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jan 9, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MIBc, tcnghia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2020
@knative-test-reporter-robot
Copy link
Copy Markdown

knative-test-reporter-robot commented Jan 9, 2020

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-unit-tests pull-knative-serving-unit-tests
pull-knative-serving-unit-tests		 2/3

Automatically retrying due to test flakiness...
/test pull-knative-serving-unit-tests

@knative-prow-robot knative-prow-robot merged commit 1b0ca1a into knative:master Jan 9, 2020
@MIBc MIBc deleted the probe-timeout branch January 20, 2020 03:16
@MIBc MIBc mentioned this pull request Aug 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markusthoemmes markusthoemmes Awaiting requested review from markusthoemmes

@nak3 nak3 Awaiting requested review from nak3

1 more reviewer

@vagababov vagababov vagababov left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@tcnghia tcnghia

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/networking cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ingress prober may need additional timeout settings

6 participants

@MIBc @knative-prow-robot @tcnghia @knative-test-reporter-robot @vagababov @googlebot