Skip to content

Set timeout for ingress prober #6465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow-robot merged 1 commit into from
Jan 9, 2020
Merged

Set timeout for ingress prober #6465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cmd/queue/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ const (
queueDepthN = "queue_depth"

healthURLTemplate = "http://127.0.0.1:%d"
tcpProbeTimeout = 100 * time.Millisecond
// The 25 millisecond retry interval is an unscientific compromise between wanting to get
// started as early as possible while still wanting to give the container some breathing
// room to get up and running.
Expand Down
5 changes: 3 additions & 2 deletions pkg/network/status/status.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,11 @@ const (
stateExpiration = 5 * time.Minute
// cleanupPeriod defines how often states are cleaned up
cleanupPeriod = 1 * time.Minute
//probeTimeout defines the maximum amount of time a request will wait
probeTimeout = 1 * time.Second
)

// TODO(https://github.com/knative/serving/issues/6407): Default timeouts may lead to hanging probes.
var dialContext = (&net.Dialer{}).DialContext
var dialContext = (&net.Dialer{Timeout: probeTimeout}).DialContext

// ingressState represents the probing progress at the Ingress scope
type ingressState struct {
Expand Down