Skip to content

Update prometheus config#6526

Merged
knative-prow-robot merged 1 commit intoknative:masterfrom
MIBc:prometheus-config
Jan 15, 2020
Merged

Update prometheus config#6526
knative-prow-robot merged 1 commit intoknative:masterfrom
MIBc:prometheus-config

Conversation

@MIBc
Copy link
Copy Markdown
Contributor

@MIBc MIBc commented Jan 14, 2020

Proposed Changes

  • Update prometheus scrape config. The container port name is outdated.

@MIBc
Update prometheus config
b2eea14 
Update prometheus scrape config. The container port name is outdated.
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 14, 2020
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 14, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jan 14, 2020

Hi @MIBc. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MIBc
Copy link
Copy Markdown
Contributor Author

MIBc commented Jan 14, 2020

/assign @yanweiguo

@yanweiguo
Copy link
Copy Markdown
Contributor

yanweiguo commented Jan 15, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jan 15, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MIBc, yanweiguo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2020
@knative-prow-robot knative-prow-robot merged commit 74ecc43 into knative:master Jan 15, 2020
@MIBc MIBc deleted the prometheus-config branch January 20, 2020 03:16
@anniefu anniefu mentioned this pull request Jan 28, 2020
Closed
@MIBc MIBc mentioned this pull request Aug 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vagababov vagababov Awaiting requested review from vagababov

@yanweiguo yanweiguo Awaiting requested review from yanweiguo

Assignees

@yanweiguo yanweiguo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/monitoring cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MIBc @knative-prow-robot @yanweiguo @googlebot