Skip to content

Update kube-state-metrics yaml#6567

Merged
knative-prow-robot merged 1 commit intoknative:masterfrom
MIBc:update-kube-state
Jan 23, 2020
Merged

Update kube-state-metrics yaml#6567
knative-prow-robot merged 1 commit intoknative:masterfrom
MIBc:update-kube-state

Conversation

@MIBc
Copy link
Copy Markdown
Contributor

@MIBc MIBc commented Jan 19, 2020

Fixes #6558

Proposed Changes

  • kube-state-metrics can not get k8s resource due to wrong service-account.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 19, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 19, 2020
@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 19, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jan 19, 2020

Hi @MIBc. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MIBc
Copy link
Copy Markdown
Contributor Author

MIBc commented Jan 19, 2020

/assign @yanweiguo

@markusthoemmes
Copy link
Copy Markdown
Contributor

markusthoemmes commented Jan 20, 2020

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 20, 2020
yanweiguo
yanweiguo reviewed Jan 22, 2020
View reviewed changes
Comment thread third_party/config/monitoring/metrics/prometheus/kubernetes/kube-state-metrics.yaml
kind: ClusterRole
metadata:
name: kube-state-metrics
namespace: knative-monitoring
Copy link
Copy Markdown
Contributor

@yanweiguo yanweiguo Jan 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to keep this ClusterRole and ClusterRoleBinding in knative-monitoring namespace?

Copy link
Copy Markdown
Contributor Author

@MIBc MIBc Jan 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ClusterRole and ClusterRoleBinging are k8s cluster resources. They are not belong to a specific namespace.
But it is OK, if set namespace for them. It has not any problems.

Copy link
Copy Markdown
Contributor

@yanweiguo yanweiguo Jan 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just took another look. Other ClusterRole and ClusterRoleBinging are in the default namespace. I think you're right and we should keep consistence.

yanweiguo
yanweiguo reviewed Jan 22, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@yanweiguo yanweiguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jan 22, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MIBc, yanweiguo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2020
@MIBc
Copy link
Copy Markdown
Contributor Author

MIBc commented Jan 22, 2020

/retest

@knative-test-reporter-robot
Copy link
Copy Markdown

knative-test-reporter-robot commented Jan 22, 2020

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-unit-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-serving-unit-tests:

pkg/reconciler/ingress.TestReconcile
pkg/reconciler/ingress.TestReconcile/clean_up_VirtualServices_when_ingress_class_annotation_is_not_istio

@MIBc
Copy link
Copy Markdown
Contributor Author

MIBc commented Jan 23, 2020

/retest

1 similar comment
@MIBc
Copy link
Copy Markdown
Contributor Author

MIBc commented Jan 23, 2020

/retest

@knative-prow-robot knative-prow-robot merged commit 2210d69 into knative:master Jan 23, 2020
@MIBc MIBc mentioned this pull request Aug 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vagababov vagababov Awaiting requested review from vagababov

1 more reviewer

@yanweiguo yanweiguo yanweiguo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@yanweiguo yanweiguo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/monitoring cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Wrong ClusterRoleBinding in monitoring.yaml

6 participants

@MIBc @knative-prow-robot @markusthoemmes @knative-test-reporter-robot @yanweiguo @googlebot