Skip to content

Update kube-state-metrics yaml #6567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow-robot merged 1 commit into from
Jan 23, 2020
Merged

Update kube-state-metrics yaml #6567

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions third_party/config/monitoring/metrics/prometheus/kubernetes/kube-state-metrics.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
name: kube-state-metrics
namespace: knative-monitoring
Copy link
Copy Markdown
Contributor

@yanweiguo yanweiguo Jan 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to keep this ClusterRole and ClusterRoleBinding in knative-monitoring namespace?

Copy link
Copy Markdown
Contributor Author

@MIBc MIBc Jan 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ClusterRole and ClusterRoleBinging are k8s cluster resources. They are not belong to a specific namespace.
But it is OK, if set namespace for them. It has not any problems.

Copy link
Copy Markdown
Contributor

@yanweiguo yanweiguo Jan 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just took another look. Other ClusterRole and ClusterRoleBinging are in the default namespace. I think you're right and we should keep consistence.

rules:
- apiGroups: [""]
resources:
Expand Down Expand Up @@ -100,15 +99,14 @@ apiVersion: rbac.authorization.k8s.io/v1beta1
kind: ClusterRoleBinding
metadata:
name: kube-state-metrics
namespace: knative-monitoring
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
name: kube-state-metrics
subjects:
- kind: ServiceAccount
name: kube-state-metrics
namespace: kube-system
namespace: knative-monitoring
---
apiVersion: apps/v1
kind: Deployment
Expand Down