Skip to content

Rename ConvertUp/Down to ConvertTo/From#6986

Merged
knative-prow-robot merged 3 commits into
knative:masterfrom
dprotaso:convert-x
Feb 25, 2020
Merged

Rename ConvertUp/Down to ConvertTo/From#6986
knative-prow-robot merged 3 commits into
knative:masterfrom
dprotaso:convert-x

Conversation

@dprotaso
Copy link
Copy Markdown
Member

@dprotaso dprotaso commented Feb 24, 2020

Contributes to knative/pkg#1122

Proposed Changes

  • Rename ConvertUp/Down to ConvertTo/From

Release Note

NONE

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 24, 2020
@knative-prow-robot knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. area/API API objects and controllers labels Feb 24, 2020
knative-prow-robot
knative-prow-robot reviewed Feb 24, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dprotaso: 24 warnings.

Details

In response to this:

Contributes to knative/pkg#1122

Proposed Changes

  • Rename ConvertUp/Down to ConvertTo/From

Release Note

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Comment thread pkg/apis/serving/v1alpha1/route_conversion.go
Comment thread pkg/apis/serving/v1alpha1/route_conversion.go
Comment thread pkg/apis/serving/v1alpha1/route_conversion.go
Comment thread pkg/apis/serving/v1alpha1/route_conversion.go
Comment thread pkg/apis/serving/v1alpha1/route_conversion.go
Comment thread pkg/apis/serving/v1alpha1/revision_conversion.go
Comment thread pkg/apis/serving/v1/revision_conversion.go
Comment thread pkg/apis/serving/v1beta1/revision_conversion.go
Comment thread pkg/apis/serving/v1/configuration_conversion.go
Comment thread pkg/apis/serving/v1/service_conversion.go
@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Feb 24, 2020

Meant to open a draft
/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 24, 2020
@dprotaso dprotaso changed the title Rename ConvertUp/Down to ConvertTo/From [WIP] Rename ConvertUp/Down to ConvertTo/From Feb 24, 2020
@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 24, 2020
@dprotaso dprotaso mentioned this pull request Feb 24, 2020
Merged
5 tasks
@n3wscott
Copy link
Copy Markdown
Contributor

n3wscott commented Feb 24, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2020
@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Feb 24, 2020

FYI - waiting on #6985 to merge before rebasing

@dprotaso dprotaso changed the title [WIP] Rename ConvertUp/Down to ConvertTo/From Rename ConvertUp/Down to ConvertTo/From Feb 24, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 24, 2020
@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Feb 24, 2020

Using prow hold so others can un-/hold it without editing the title
/hold

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 24, 2020
@dprotaso
bump knative.dev/pkg
1699503
@dprotaso
Rename ConvertUp/Down to ConvertTo/From
72ba924 
Replacing done via the commands:
```
rg -l ConvertDown | xargs -n1 sed -i ''  's/ConvertDown/ConvertFrom/g'
rg -l ConvertUp | xargs -n1 sed -i ''  's/ConvertUp/ConvertTo/g'
```
@knative-prow-robot knative-prow-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 24, 2020
@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Feb 24, 2020

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 24, 2020
@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Feb 24, 2020

/assign @mattmoor

mattmoor
mattmoor reviewed Feb 24, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Feb 24, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2020
@knative-test-reporter-robot
Copy link
Copy Markdown

knative-test-reporter-robot commented Feb 24, 2020

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-integration-tests pull-knative-serving-integration-tests
pull-knative-serving-integration-tests		 2/3

Automatically retrying due to test flakiness...
/test pull-knative-serving-integration-tests

@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Feb 24, 2020

/retest

@n3wscott
Copy link
Copy Markdown
Contributor

n3wscott commented Feb 25, 2020

let it in tide!!

@n3wscott
Copy link
Copy Markdown
Contributor

n3wscott commented Feb 25, 2020

/woof

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Feb 25, 2020

@n3wscott: dog image

Details

In response to this:

/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot merged commit b1f9910 into knative:master Feb 25, 2020
@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Feb 25, 2020 via email

@dprotaso dprotaso deleted the convert-x branch February 25, 2020 02:28
@n3wscott n3wscott mentioned this pull request Feb 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@dgerd dgerd Awaiting requested review from dgerd

@tcnghia tcnghia Awaiting requested review from tcnghia

+1 more reviewer

@mattmoor mattmoor mattmoor left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mattmoor mattmoor

@n3wscott n3wscott

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dprotaso @n3wscott @knative-prow-robot @knative-test-reporter-robot @mattmoor @googlebot