Skip to content

Fixed #1057 - Rename ConvertUp/Down to ConvertTo/From#1122

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
dprotaso:convert-x
Feb 24, 2020
Merged

Fixed #1057 - Rename ConvertUp/Down to ConvertTo/From#1122
knative-prow-robot merged 1 commit into
knative:masterfrom
dprotaso:convert-x

Conversation

@dprotaso
Copy link
Copy Markdown
Member

@dprotaso dprotaso commented Feb 24, 2020 •
edited
Loading

Downstream PRs

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 24, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 24, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 24, 2020
@dprotaso dprotaso mentioned this pull request Feb 24, 2020
Merged
@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Feb 24, 2020

knative/serving - knative/serving#6986

@n3wscott
Copy link
Copy Markdown
Contributor

n3wscott commented Feb 24, 2020

Might be easier to deprecate the old names and add the new one and then delete the old one?

@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Feb 24, 2020

Might be easier to deprecate the old names and add the new one and then delete the old one?

Easier for who?

@dprotaso dprotaso mentioned this pull request Feb 24, 2020
Merged
@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Feb 24, 2020

knative/eventing - knative/eventing#2632

@dprotaso dprotaso mentioned this pull request Feb 24, 2020
Closed
@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Feb 24, 2020

This is technically a NOOP and just a dependency bump
knative/eventing-contrib - knative/eventing-contrib#961

@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Feb 24, 2020

knative/sample-controller - no usage

@n3wscott
Copy link
Copy Markdown
Contributor

n3wscott commented Feb 24, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Feb 24, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2020
@dprotaso dprotaso marked this pull request as ready for review February 24, 2020 17:38
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 24, 2020
@knative-prow-robot knative-prow-robot merged commit d771641 into knative:master Feb 24, 2020
@dprotaso dprotaso deleted the convert-x branch February 24, 2020 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattmoor mattmoor Awaiting requested review from mattmoor

@n3wscott n3wscott Awaiting requested review from n3wscott

@tcnghia tcnghia Awaiting requested review from tcnghia

Assignees

@n3wscott n3wscott

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dprotaso @n3wscott @knative-prow-robot @googlebot