Skip to content

Add ZhiminXiang and nak3 to networking-approvers, JRBANCEL to networking-reviewers.#7203

Closed
tcnghia wants to merge 3 commits intoknative:masterfrom
tcnghia:add-approvers
Closed

Add ZhiminXiang and nak3 to networking-approvers, JRBANCEL to networking-reviewers.#7203
tcnghia wants to merge 3 commits intoknative:masterfrom
tcnghia:add-approvers

Conversation

@tcnghia
Copy link
Copy Markdown
Contributor

@tcnghia tcnghia commented Mar 10, 2020

git log --after=2019-12-05 --   ./pkg/reconciler/certificate ./pkg/reconciler/route ./pkg/controller/route ./pkg/webhook/route ./pkg/reconciler/clusteringress ./pkg/reconciler/ingress ./pkg/controller/ ./pkg/webhook/route   ./pkg/apis/networking ./pkg/queue ./cmd/queue ./pkg/activator ./pkg/h2c ./pkg/websocket ./third_party ./pkg/network | grep Author | cut -f2 -d: | sort | uniq -c | sort -k1 -n -r | grep -v 'sockpuppet'  | head -n 10
     40  Matt Moore <mattmoor@vmware.com>
     40  Markus Thömmes <markusthoemmes@me.com>
     37  Victor Agababov <vagababov@gmail.com>
     16  Nghia Tran <nghia@google.com>
     14  Kenjiro Nakayama <nakayamakenjiro@gmail.com>
      9  Zhimin Xiang <zhiminx@google.com>
      9  Knative Prow Robot <41213312+knative-prow-robot@users.noreply.github.com>
      6  Jean-Rémy Bancel <bancel@google.com>
      6  Dave Protasowski <dprotaso@gmail.com>
      5  Tara Gu <guw@ibm.com>

/assign @mattmoor

Proposed Changes

Release Note


Both are among the most active reviewers and contributors in
networking WG.
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 10, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 10, 2020
@tcnghia tcnghia changed the title Add ZhiminXiang and nak3 to networking-approvers. Add ZhiminXiang and nak3 to networking-approvers, JRBANCEL to networking-reviewers. Mar 10, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tcnghia
To complete the pull request process, please assign mattmoor
You can assign the PR to them by writing /assign @mattmoor in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Co-Authored-By: Matt Moore <mattmoor@vmware.com>
@mattmoor
Copy link
Copy Markdown
Member

Generally the format we've been following is here: #4426 (I believe @grantr pioneered this ⚒ )

@tcnghia
Copy link
Copy Markdown
Contributor Author

tcnghia commented Mar 11, 2020

/close

Will follow up with PRs in the right format

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@tcnghia: Closed this PR.

Details

In response to this:

/close

Will follow up with PRs in the right format

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tcnghia
Copy link
Copy Markdown
Contributor Author

tcnghia commented Mar 11, 2020

@mattmoor : #7215 & #7216

@tcnghia
Copy link
Copy Markdown
Contributor Author

tcnghia commented Mar 11, 2020

@mattmoor also #7217

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants