Add ZhiminXiang to networking-approvers.#7215
Merged
knative-prow-robot merged 2 commits intoknative:masterfrom Mar 13, 2020
Merged
Add ZhiminXiang to networking-approvers.#7215knative-prow-robot merged 2 commits intoknative:masterfrom
knative-prow-robot merged 2 commits intoknative:masterfrom
Conversation
knative-prow-robot
added
the
size/XS
tcnghia
changed the title
Contributor
|
🎉 |
vaikas
reviewed
Mar 12, 2020
added 2 commits
March 12, 2020 11:29
From ROLES.md 1/ Reviewer of the codebase for at least 3 months. knative#1687 is 1 year old. 2/ Primary reviewer for at least 10 substantial PRs to the codebase. 7 XLs: https://github.com/knative/serving/pulls?q=is%3Apr+assignee%3AZhiminXiang+is%3Aclosed+reviewed-by%3AZhiminXiang+label%3Asize%2FXXL 3 Ls: https://github.com/knative/serving/pulls?q=is%3Apr+assignee%3AZhiminXiang+is%3Aclosed+reviewed-by%3AZhiminXiang+label%3Asize%2FXL+ 9 Ms: https://github.com/knative/serving/pulls?q=is%3Apr+assignee%3AZhiminXiang+is%3Aclosed+reviewed-by%3AZhiminXiang+label%3Asize%2FM 3/ 33 Reviewed PRs https://github.com/knative/serving/pulls?q=is%3Apr+assignee%3AZhiminXiang+is%3Aclosed+reviewed-by%3AZhiminXiang+ 4/ 81 Merged PRs https://github.com/knative/serving/pulls?q=is%3Apr+is%3Aclosed+author%3AZhiminXiang 4/ Nominated by nghia@ with no objections from other leads
Contributor
Author
|
@vaikas updated PTAL |
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tcnghia, vaikas The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Contributor
|
I'll fix it 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From ROLES.md
1/ Reviewer of the codebase for at least 3 months.
#1687 is 1 year old.
2/ Primary reviewer for at least 10 substantial PRs to the codebase.
7 XLs
3 Ls
9 Ms
3/ 33 Reviewed PRs
4/ 81 Merged PRs
5/ Nominated by nghia@ with no objections from other leads
Fixes #
Proposed Changes
Release Note