Simplify minscale test.#7235
Merged
knative-prow-robot merged 1 commit intoknative:masterfrom Mar 13, 2020
Merged
Conversation
The only error returned from the function is when we fail to actually verify the scale. So return boolean instead.
knative-prow-robot
added
the
size/S
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
approved
|
The following jobs failed:
Automatically retrying due to test flakiness... |
markusthoemmes
pushed a commit
to markusthoemmes/knative-serving
that referenced
this pull request
Mar 16, 2020
The only error returned from the function is when we fail to actually verify the scale. So return boolean instead.
knative-prow-robot
pushed a commit
that referenced
this pull request
Mar 17, 2020
* Add route label to `LatestCreatedRevision` (#7110) * Test minScale during update to configuration * Add route label to LatestCreatedRevision * Use impl.Enqueue instead of tracker.OnChanged in labeler reconciler * Update minscale readiness e2e test * faster polling (250 ms) * more descriptive error for ensureDesiredScale * inlined latestCreatedRevisionName check * Enqueue route instead of config in labeler reconciler * Only label configurations of RunLatest traffic targets * Label configuration if it or it's revision is in a route * Only pull config for runLatest in labeler * Some cleanups in the e2e test (#7193) * Some cleanups in the e2e test * Some cleanups in the e2e test * fix nit * Simplify minscale test. (#7235) The only error returned from the function is when we fail to actually verify the scale. So return boolean instead. * Fix minscale on deploy (#7214) * Test minscale stability when configuration is created * Check both .spec.traffic and .status.traffic for resources to label * Inline condition * Inline owner reference check Co-authored-by: Tanzeeb Khalili <tkhalili@pivotal.io> Co-authored-by: Victor Agababov <vagababov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only error returned from the function is when we fail to actually verify the scale.
So return boolean instead.
/assign mattmoor