[RELEASE 0.13] Backport fixes to minScale behavior.#7272
[RELEASE 0.13] Backport fixes to minScale behavior.#7272knative-prow-robot merged 4 commits intoknative:release-0.13from
Conversation
* Test minScale during update to configuration * Add route label to LatestCreatedRevision * Use impl.Enqueue instead of tracker.OnChanged in labeler reconciler * Update minscale readiness e2e test * faster polling (250 ms) * more descriptive error for ensureDesiredScale * inlined latestCreatedRevisionName check * Enqueue route instead of config in labeler reconciler * Only label configurations of RunLatest traffic targets * Label configuration if it or it's revision is in a route * Only pull config for runLatest in labeler
* Some cleanups in the e2e test * Some cleanups in the e2e test * fix nit
The only error returned from the function is when we fail to actually verify the scale. So return boolean instead.
* Test minscale stability when configuration is created * Check both .spec.traffic and .status.traffic for resources to label * Inline condition * Inline owner reference check
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
knative-prow-robot
added
size/L
knative-prow-robot
left a comment
knative-prow-robot
left a comment
There was a problem hiding this comment.
@markusthoemmes: 0 warnings.
Details
In response to this:
Fixes for #6733 to be backported onto 0.13.
Release Note
Fixes a bug where a revision would be scaled down to 0 even if it has minScale applied to it./assign @mattmoor
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
knative-prow-robot
added
the
area/test-and-release
knative-prow-robot
added
the
approved
|
@vagababov @tanzeeb please leave your consent if you agree with this backport. |
|
The fix portion of this is relatively contained and has had a fair number of eyeballs on it at HEAD. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markusthoemmes, mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@googlebot I consent. |
|
@googlebot I consent |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
googlebot
added
cla: yes
6 participants
Fixes for #6733 to be backported onto 0.13.
Release Note
/assign @mattmoor