Skip to content

Use Webhook v1 APIs#8461

Merged
knative-prow-robot merged 2 commits into
knative:masterfrom
dprotaso:webhook-v1
Jun 24, 2020
Merged

Use Webhook v1 APIs#8461
knative-prow-robot merged 2 commits into
knative:masterfrom
dprotaso:webhook-v1

Conversation

@dprotaso
Copy link
Copy Markdown
Member

@dprotaso dprotaso commented Jun 24, 2020

Proposed Changes

  • Webhooks now use apiextensions.k8s.io/v1 APIs

Release Note

NONE

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 24, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 24, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2020
@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Jun 24, 2020 •
edited
Loading

/hold

I'm guessing this needs the TypeMeta in the response

https://github.com/knative/pkg/blob/master/webhook/admission.go#L91

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2020
@dprotaso dprotaso changed the title Use Webhook v1 APIs [WIP] Use Webhook v1 APIs Jun 24, 2020
@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 24, 2020
This was referenced Jun 24, 2020
Merged
Merged
@knative-test-reporter-robot
Copy link
Copy Markdown

knative-test-reporter-robot commented Jun 24, 2020

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-autotls-tests 0/3
pull-knative-serving-integration-tests 0/3
pull-knative-serving-upgrade-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-serving-upgrade-tests:

test/upgrade.TestServicePostUpgrade
test/upgrade.TestServicePostUpgradeFromScaleToZero
test/upgrade.TestBYORevisionPostUpgrade
test/upgrade.TestCreateNewServicePostUpgrade

@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 24, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jun 24, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Jun 24, 2020

hmmm....

/retest

@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Jun 24, 2020

/test pull-knative-serving-integration-tests

@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Jun 24, 2020

ok so the prior integration run that failed was the old commit that was being retried

@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 24, 2020
@dprotaso dprotaso changed the title [WIP] Use Webhook v1 APIs Use Webhook v1 APIs Jun 24, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 24, 2020
@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Jun 24, 2020

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2020
vagababov
vagababov reviewed Jun 24, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\o/
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2020
@dprotaso dprotaso added this to the Serving 0.16.x milestone Jun 24, 2020
@knative-prow-robot knative-prow-robot merged commit 8d7e4db into knative:master Jun 24, 2020
@dprotaso dprotaso deleted the webhook-v1 branch June 24, 2020 20:04
@anishj0shi anishj0shi mentioned this pull request Jun 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattmoor mattmoor Awaiting requested review from mattmoor

@mdemirhan mdemirhan Awaiting requested review from mdemirhan

1 more reviewer

@vagababov vagababov vagababov left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@vagababov vagababov

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

0.16.x

Development

Successfully merging this pull request may close these issues.

5 participants

@dprotaso @knative-test-reporter-robot @knative-prow-robot @vagababov @googlebot