Conversation
…verify-page Fix verify page note claim status on exhale
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d64e916874
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const pulse = Number.isFinite(meta.pulse ?? NaN) ? meta.pulse : meta.kaiPulse; | ||
| const beat = Number.isFinite(meta.beat ?? NaN) ? meta.beat : undefined; | ||
| const stepIndex = Number.isFinite(meta.stepIndex ?? NaN) ? meta.stepIndex : undefined; | ||
| const chakraDay = typeof meta.chakraDay === "string" ? meta.chakraDay : ""; | ||
| const seed = `${pulse ?? ""}|${beat ?? ""}|${stepIndex ?? ""}|${chakraDay ?? ""}`; |
There was a problem hiding this comment.
This fallback builds the hash seed with empty strings for missing numeric fields. Elsewhere, canonical hashes default missing pulse/beat/stepIndex to 0 (e.g. canonicalHash() in src/verifier/validator.ts uses ${meta.pulse ?? 0}|${meta.beat ?? 0}|${meta.stepIndex ?? 0}|...). For legacy sigils that omit beat/stepIndex but still need a deterministic canonical, this will compute a different parent hash, so note send/claim metadata won’t match the canonical used by verification/ledger. Consider reusing the existing canonical hash helper or applying the same ?? 0 defaults here.
Useful? React with 👍 / 👎.
1 participant
No description provided.