Threat each newline as separate word in diffWordsWithSpace#217
Merged
kpdecker merged 1 commit intokpdecker:masterfrom Aug 16, 2020
Merged
Threat each newline as separate word in diffWordsWithSpace#217kpdecker merged 1 commit intokpdecker:masterfrom
diffWordsWithSpace#217kpdecker merged 1 commit intokpdecker:masterfrom
Conversation
Contributor
Author
|
@kpdecker any feedback? |
… in `diffWordsWithSpace`
810269e to
9d69baa
Compare
Contributor
Author
|
@kpdecker, can we make progress with this? Better late than never |
Owner
|
Sorry for the delay on this, Have very few cycles for this project these days. |
Contributor
Author
|
Nice to see that you don't forgot the project |
tobiasso85
added a commit
to SAP-archive/ui5-migration
that referenced
this pull request
Apr 1, 2022
and there is no best solution. Breaking change is: kpdecker/jsdiff#217
tobiasso85
added a commit
to SAP-archive/ui5-migration
that referenced
this pull request
Apr 1, 2022
* Bump diff from 4.0.2 to 5.0.0 Bumps [diff](https://github.com/kpdecker/jsdiff) from 4.0.2 to 5.0.0. - [Release notes](https://github.com/kpdecker/jsdiff/releases) - [Changelog](https://github.com/kpdecker/jsdiff/blob/master/release-notes.md) - [Commits](kpdecker/jsdiff@v4.0.2...v5.0.0) Signed-off-by: dependabot[bot] <support@github.com> * fixed tests, the changes to the expected test files' content is minimal and there is no best solution. Breaking change is: kpdecker/jsdiff#217 Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tobias Sorn <tobias.sorn@sap.com>
Collaborator
|
IMO the behaviour this produces for ... and here's one with the code after this change: We're now only sort-of-ignoring whitespace in (In fairness, we were already doing a bad job of ignoring whitespace in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #180 & #211