Update the diff module to v5.2.0 for performance improvements#201
Merged
bilindhajer merged 5 commits intomasterfrom Apr 22, 2024
Merged
Update the diff module to v5.2.0 for performance improvements#201bilindhajer merged 5 commits intomasterfrom
bilindhajer merged 5 commits intomasterfrom
Conversation
bilindhajer
requested changes
Apr 17, 2024
added 3 commits
April 18, 2024 12:49
bilindhajer
requested changes
Apr 18, 2024
bilindhajer
approved these changes
Apr 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
difffrom v3.5.0 to v5.2.0. The update includes significant performance improvements (jsdiff/#448 & jsdiff/#411) which makes it possible to diff larger CloudFormation templates.For a full list of changes, see the changelog: https://github.com/kpdecker/jsdiff/blob/master/release-notes.md.
Review of breaking changes between version 3.5.0 and 5.2.0
v5.0.0
We are not affected, since cfn-config doesn't use UMD imports.
Changes in kpdecker/jsdiff#217 affect the diff return value of the
diffWordsfunction. We don't usediffWordsin cfn.config.cfn-config doesn't use the unified diff output. The changes in kpdecker/jsdiff#297 affect how unified diff chunks are formatted.
v4.0.0 - January 5th, 2019
Changes in kpdecker/jsdiff#94 affect only patches in unified diff format, which are not used in cfn-config.
Changes affect only patches in unified diff format, which are not used in cfn-config.
cfn-config is not affected by browser targets.
Changes in kpdecker/jsdiff@f27b899 affect word diffs, which are not used in cfn-config.
cfn-config doesn't use bower.