Pure Apollo integration based on `master` by piglovesyou · Pull Request #1664 · kriasoft/react-starter-kit

piglovesyou · 2018-09-04T08:16:12Z

Pure Apollo integration based on master.

Features

TypeScript implementation that Apollo primarily supports
apollo-client with full server-side rendering - No fetch()
Client-side state management with apollo-client@2.5 with networkStatus example
apollo-server serves GraphQL API
Codegen Flow types - Flow type checking follows GraphQL Schema
More Flow Types - More confident use of component properties
GraphQL Scalar type - Timestamp for an example

Branches

Master: piglovesyou:feature/apollo-pure
Stable: kriasoft:feature/apollo-pure

- [x] `apollo-client` with full server-side rendering - [x] `apollo-link-state` - Client-side state management with `networkStatus` example - [x] `apollo-server` Without: * Flux (Redux) store - replaced by `apollo-link-state` * Fetch function - No need when you have an `apolloClient`

langpavel · 2018-09-04T10:11:17Z

Hi! Great work, I will review it in my rare free time 🙂
Will be great if you prepare new PR which I can merge to master with updated README
— added link to feature/apollo-pure branch which I can create from this PR.

Please remind me in few days if I forget to do it 😉

piglovesyou · 2018-09-04T10:35:10Z

@langpavel Thank you for your support. I did on #1665 .

langpavel · 2018-09-04T13:28:25Z

Your work is now pushed in feature/apollo-pure branch

piglovesyou · 2018-09-04T13:47:39Z

@langpavel Wow, pleasure, thanks.

Then shall I delete this PR? Further commits and discussion seem to go in #1666.

langpavel · 2018-09-04T13:52:28Z

Don't delete this PR, you can push fresh commits here.
I believe that you can open new PRs against feature/apollo-pure branch from commits on top of this branch.

piglovesyou · 2018-09-04T14:27:31Z

All right. I'll push another to it when I feel like it.

piglovesyou · 2019-02-10T11:37:50Z

@langpavel I have a question. When I'd like to update kreasoft:feature/apollo-pure, I need to create a PR on it every time, is that correct? I'm thinking publishing another feature like apollo codegen.

piglovesyou · 2019-02-18T23:23:17Z

Sorry I missed your previous comment, I'll create a PR pointing to kreasoft:feature/apollo-pure.

* Upgrade all dependencies 1. ncu --upgradeAll 4. Leave "graphql" to be "^13.2.0" that apollo packages depend on 2. Apply patch of "npx babel-upgrade" output 3. Leave only necessary babel plugins 4. Pass "yarn fix" by disabling stricter rules * Pass "req" through GraphQL resolver context * Through rootValue it cannot be passed from browser GraphQL access * rm unnecessary code * Add "Timestamp" scalar type for convinience * rm unnecessary files * fix: Timestamp didn't work * npm graphql requires to be update vercel/next.js#5238 (comment) * Feature: Codegen from GraphQL schema and use more Flow types (#2) * install apllo * add apollo.config.js * apollo codegen succeeded * fix: updateNetworkStatus signature * rm @flow from files not ready * add flow-typed files * done: Using auto-generated types works * flow-bin@0.89+ has regression. Use ^0.88.0. * fix: invalid GraphQL primitive types * Add codegen script * done: import auto-generated file * refac: move impl for apollo-link-state to graphql dir as same as server side resolvers * codegen and ignore eslint these files * refactor: "networkStatus" * feat: codegen:standalone * refac: "OnMemoryState" is what I meant * Improve codegen (#3) * delete existing auto-generated types * change script name * ignore __generated__ folder * wip: disallow absolute path resolving under `src` dir * It causes disregard .js type checking under src * fix all flow error * modify: prevent `withStyles` drops component type * Modify targe Node versions * Fix build failure: Codegen before lint * Add Node v10 LTS for build target

* small README.md grammar change (kriasoft#1675) * Upgrade all dependencies including Babel 7 (kriasoft#1673) * Upgrade all dependencies including Babel 7 1. ncu --upgradeAll 4. Leave "graphql" to be "^13.2.0" that apollo packages depend on 2. Apply patch of "npx babel-upgrade" output 3. Leave only necessary babel plugins 4. Pass "yarn fix" by disabling stricter rules fixes kriasoft#1654 kriasoft#1626 kriasoft#1607 * Also ignore babel config file from webpack.config.js * Resolve conflict and follow upstream/master * small README.md grammar change (kriasoft#1675) * Upgrade all dependencies including Babel 7 (kriasoft#1673) * Upgrade all dependencies including Babel 7 * update apollo packages * Use new local state management of Apollo Client 2.5 * Client Schema * Simplify cache and cache defaults * User in local state instead of context * bye apollo-link-state * mod: better suppressing flow error for .graphql import * fix: jest error by updating jest * Upgrade all dependencies fix 2 breaking changes: * css-loader no longer accepts 'minimize' option * isomorphic-style-loader uses new React Context now * refac: Use functional component for components * fix: resolve apollo and graphql versions problem ref. apollographql/apollo-tooling#630 (comment)

improve eslint defs

* Sqlite3 is still working on supporting Node12 TryGhost/node-sqlite3#1151

piglovesyou · 2019-05-27T15:22:31Z

I think I can close this PR now. I'll keep maintaining feature/apollo-pure on #1666.

piglovesyou force-pushed the feature/apollo-pure branch 6 times, most recently from 24e02f8 to 5ef8174 Compare September 4, 2018 09:33

piglovesyou force-pushed the feature/apollo-pure branch from bc9958a to a1dc543 Compare September 4, 2018 09:40

piglovesyou mentioned this pull request Sep 4, 2018

TRACKING: feature/redux → feature/apollo #1147

Closed

5 tasks

langpavel assigned langpavel and piglovesyou Sep 4, 2018

langpavel added example labels Sep 4, 2018

langpavel self-requested a review September 4, 2018 10:06

piglovesyou mentioned this pull request Sep 4, 2018

Add a line linked to feature/apollo-purePR #1665

Merged

Merge branch 'master' into feature/apollo-pure

b1b784d

langpavel mentioned this pull request Sep 4, 2018

TRACKING: master → feature/apollo-pure #1666

Closed

langpavel added duplicate This issue or pull request already exists branch master and removed TRACKING labels Sep 4, 2018

piglovesyou force-pushed the feature/apollo-pure branch from 49bfabe to 787bbed Compare September 22, 2018 08:25

piglovesyou force-pushed the feature/apollo-pure branch from a99f62d to c15b123 Compare February 28, 2019 14:51

piglovesyou force-pushed the feature/apollo-pure branch from deb0578 to 27ba7d3 Compare March 21, 2019 07:51

piglovesyou force-pushed the feature/apollo-pure branch from 87fca22 to dced0fa Compare March 23, 2019 03:07

piglovesyou added 13 commits April 6, 2019 18:56

update apollo packages

503499e

bye apollo-link-state

51e76b5

fix: jest error by updating jest

0fefd74

mod: Make yarn codegen always executable

bce4fa7

mod: Take care non-js import in flowconfig

b1d934a

suppress 'sequelize deprecated String based operators' error

ca23b78

suppress 'Please use `require("history").PathUtils' error

5d2020c

refac: make all components functional

b54445c

Flow to Typescript (#13)

5a17ba5

get available port on codegen (#14)

dd04c5f

improve tyeps (#15)

9f3d56d

refactor typings

8af3499

remove unnecessary babel plugin

6d98c30

piglovesyou force-pushed the feature/apollo-pure branch from 9a2f3eb to 6d98c30 Compare April 6, 2019 10:11

piglovesyou added 5 commits April 6, 2019 22:27

Type models

682a14b

pass eslint --ext .ts --ext .tsx

bc2085b

mod: clear old type defs before codegen

7f19a67

improve eslint defs

ignore Node12 build

825af50

* Sqlite3 is still working on supporting Node12 TryGhost/node-sqlite3#1151

Fix Node 12 build failure

a778928

piglovesyou closed this May 27, 2019

piglovesyou deleted the feature/apollo-pure branch June 21, 2019 15:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Pure Apollo integration based on `master`#1664

Pure Apollo integration based on `master`#1664
piglovesyou wants to merge 22 commits into
kriasoft:masterfrom
piglovesyou:feature/apollo-pure

piglovesyou commented Sep 4, 2018 •

edited

Loading

Uh oh!

langpavel commented Sep 4, 2018

Uh oh!

piglovesyou commented Sep 4, 2018

Uh oh!

langpavel commented Sep 4, 2018

Uh oh!

piglovesyou commented Sep 4, 2018

Uh oh!

langpavel commented Sep 4, 2018

Uh oh!

piglovesyou commented Sep 4, 2018

Uh oh!

piglovesyou commented Feb 10, 2019

Uh oh!

piglovesyou commented Feb 18, 2019 •

edited

Loading

Uh oh!

piglovesyou commented May 27, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

piglovesyou commented Sep 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Features

Branches

Uh oh!

langpavel commented Sep 4, 2018

Uh oh!

piglovesyou commented Sep 4, 2018

Uh oh!

langpavel commented Sep 4, 2018

Uh oh!

piglovesyou commented Sep 4, 2018

Uh oh!

langpavel commented Sep 4, 2018

Uh oh!

piglovesyou commented Sep 4, 2018

Uh oh!

piglovesyou commented Feb 10, 2019

Uh oh!

piglovesyou commented Feb 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

piglovesyou commented May 27, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

piglovesyou commented Sep 4, 2018 •

edited

Loading

piglovesyou commented Feb 18, 2019 •

edited

Loading